blob: 9fd846d09695b4139637f5ce717599b5c4c55986 [file] [log] [blame]
Maxwell Hendersonfebee252023-01-28 16:53:52 -08001#include "y2023/vision/aprilrobotics.h"
2
Jim Ostrowski49be8232023-03-23 01:00:14 -07003#include <opencv2/highgui.hpp>
4
milind-ua30a4a12023-03-24 20:49:41 -07005#include "y2023/vision/vision_util.h"
6
Maxwell Hendersonfebee252023-01-28 16:53:52 -08007DEFINE_bool(
8 debug, false,
9 "If true, dump a ton of debug and crash on the first valid detection.");
10
milind-uc5a494f2023-02-24 15:39:22 -080011DEFINE_double(min_decision_margin, 75.0,
milind-uf2a4e322023-02-01 19:33:10 -080012 "Minimum decision margin (confidence) for an apriltag detection");
Jim Ostrowski14124a32023-03-03 22:16:07 -080013DEFINE_int32(pixel_border, 10,
Jim Ostrowski437b1fb2023-02-26 10:12:01 -080014 "Size of image border within which to reject detected corners");
milind-u60e7fe52023-02-26 16:13:50 -080015DEFINE_double(
milind-u8773c232023-03-11 14:59:06 -080016 max_expected_distortion, 0.314,
milind-u60e7fe52023-02-26 16:13:50 -080017 "Maximum expected value for unscaled distortion factors. Will scale "
18 "distortion factors so that this value (and a higher distortion) maps to "
19 "1.0.");
milind-uf2a4e322023-02-01 19:33:10 -080020
Maxwell Hendersonfebee252023-01-28 16:53:52 -080021namespace y2023 {
22namespace vision {
23
Austin Schuhd2667932023-02-04 16:22:39 -080024namespace chrono = std::chrono;
25
Maxwell Hendersonfebee252023-01-28 16:53:52 -080026AprilRoboticsDetector::AprilRoboticsDetector(aos::EventLoop *event_loop,
milind-ua30a4a12023-03-24 20:49:41 -070027 std::string_view channel_name,
28 bool flip_image)
James Kuszmauld67f6d22023-02-05 17:37:25 -080029 : calibration_data_(event_loop),
milind-uf5b3b4b2023-02-26 14:50:38 -080030 image_size_(0, 0),
milind-ua30a4a12023-03-24 20:49:41 -070031 flip_image_(flip_image),
32 node_name_(event_loop->node()->name()->string_view()),
Maxwell Hendersonfebee252023-01-28 16:53:52 -080033 ftrace_(),
milind-ua30a4a12023-03-24 20:49:41 -070034 image_callback_(
35 event_loop, channel_name,
36 [&](cv::Mat image_color_mat,
37 const aos::monotonic_clock::time_point eof) {
38 HandleImage(image_color_mat, eof);
39 },
40 chrono::milliseconds(5)),
Maxwell Hendersonfebee252023-01-28 16:53:52 -080041 target_map_sender_(
Yash Chainani728ae222023-02-04 19:48:12 -080042 event_loop->MakeSender<frc971::vision::TargetMap>("/camera")),
milind-u7aa29e22023-02-23 20:22:01 -080043 image_annotations_sender_(
milind-u99b1a762023-03-12 16:48:32 -070044 event_loop->MakeSender<foxglove::ImageAnnotations>("/camera")),
45 rejections_(0) {
Maxwell Hendersonfebee252023-01-28 16:53:52 -080046 tag_family_ = tag16h5_create();
47 tag_detector_ = apriltag_detector_create();
48
49 apriltag_detector_add_family_bits(tag_detector_, tag_family_, 1);
50 tag_detector_->nthreads = 6;
51 tag_detector_->wp = workerpool_create(tag_detector_->nthreads);
52 tag_detector_->qtp.min_white_black_diff = 5;
53 tag_detector_->debug = FLAGS_debug;
54
55 std::string hostname = aos::network::GetHostname();
56
57 // Check team string is valid
James Kuszmauld67f6d22023-02-05 17:37:25 -080058 calibration_ = FindCameraCalibration(
59 calibration_data_.constants(), event_loop->node()->name()->string_view());
milind-uf2a4e322023-02-01 19:33:10 -080060
61 extrinsics_ = CameraExtrinsics(calibration_);
Maxwell Hendersonfebee252023-01-28 16:53:52 -080062 intrinsics_ = CameraIntrinsics(calibration_);
milind-uf2a4e322023-02-01 19:33:10 -080063 // Create an undistort projection matrix using the intrinsics
64 projection_matrix_ = cv::Mat::zeros(3, 4, CV_64F);
65 intrinsics_.rowRange(0, 3).colRange(0, 3).copyTo(
66 projection_matrix_.rowRange(0, 3).colRange(0, 3));
67
68 dist_coeffs_ = CameraDistCoeffs(calibration_);
Maxwell Hendersonfebee252023-01-28 16:53:52 -080069
70 image_callback_.set_format(frc971::vision::ImageCallback::Format::GRAYSCALE);
71}
72
73AprilRoboticsDetector::~AprilRoboticsDetector() {
74 apriltag_detector_destroy(tag_detector_);
75 free(tag_family_);
76}
77
78void AprilRoboticsDetector::SetWorkerpoolAffinities() {
79 for (int i = 0; i < tag_detector_->wp->nthreads; i++) {
80 cpu_set_t affinity;
81 CPU_ZERO(&affinity);
82 CPU_SET(i, &affinity);
83 pthread_setaffinity_np(tag_detector_->wp->threads[i], sizeof(affinity),
84 &affinity);
85 struct sched_param param;
86 param.sched_priority = 20;
87 int res = pthread_setschedparam(tag_detector_->wp->threads[i], SCHED_FIFO,
88 &param);
89 PCHECK(res == 0) << "Failed to set priority of threadpool threads";
90 }
91}
92
milind-uf2a4e322023-02-01 19:33:10 -080093void AprilRoboticsDetector::HandleImage(cv::Mat image_grayscale,
milind-u09fb1252023-01-28 19:21:41 -080094 aos::monotonic_clock::time_point eof) {
milind-uf5b3b4b2023-02-26 14:50:38 -080095 image_size_ = image_grayscale.size();
96
milind-u99b1a762023-03-12 16:48:32 -070097 DetectionResult result = DetectTags(image_grayscale, eof);
Maxwell Hendersonfebee252023-01-28 16:53:52 -080098
99 auto builder = target_map_sender_.MakeBuilder();
100 std::vector<flatbuffers::Offset<frc971::vision::TargetPoseFbs>> target_poses;
milind-u99b1a762023-03-12 16:48:32 -0700101 for (const auto &detection : result.detections) {
milind-ufc8ab702023-02-26 14:14:39 -0800102 target_poses.emplace_back(BuildTargetPose(detection, builder.fbb()));
Maxwell Hendersonfebee252023-01-28 16:53:52 -0800103 }
104 const auto target_poses_offset = builder.fbb()->CreateVector(target_poses);
105 auto target_map_builder = builder.MakeBuilder<frc971::vision::TargetMap>();
Maxwell Hendersonfebee252023-01-28 16:53:52 -0800106 target_map_builder.add_target_poses(target_poses_offset);
milind-u09fb1252023-01-28 19:21:41 -0800107 target_map_builder.add_monotonic_timestamp_ns(eof.time_since_epoch().count());
milind-u99b1a762023-03-12 16:48:32 -0700108 target_map_builder.add_rejections(result.rejections);
Maxwell Hendersonfebee252023-01-28 16:53:52 -0800109 builder.CheckOk(builder.Send(target_map_builder.Finish()));
110}
111
112flatbuffers::Offset<frc971::vision::TargetPoseFbs>
milind-ufc8ab702023-02-26 14:14:39 -0800113AprilRoboticsDetector::BuildTargetPose(const Detection &detection,
milind-u681c4712023-02-23 21:22:50 -0800114 flatbuffers::FlatBufferBuilder *fbb) {
Maxwell Hendersonfebee252023-01-28 16:53:52 -0800115 const auto T =
milind-ufc8ab702023-02-26 14:14:39 -0800116 Eigen::Translation3d(detection.pose.t->data[0], detection.pose.t->data[1],
117 detection.pose.t->data[2]);
milind-u3f5f83c2023-01-29 15:23:51 -0800118 const auto position_offset =
119 frc971::vision::CreatePosition(*fbb, T.x(), T.y(), T.z());
120
milind-u633c4c02023-02-25 22:51:45 -0800121 // Aprilrobotics stores the rotation matrix in row-major order
122 const auto orientation = Eigen::Quaterniond(
milind-ufc8ab702023-02-26 14:14:39 -0800123 Eigen::Matrix<double, 3, 3, Eigen::RowMajor>(detection.pose.R->data));
milind-u3f5f83c2023-01-29 15:23:51 -0800124 const auto orientation_offset = frc971::vision::CreateQuaternion(
125 *fbb, orientation.w(), orientation.x(), orientation.y(), orientation.z());
126
milind-u681c4712023-02-23 21:22:50 -0800127 return frc971::vision::CreateTargetPoseFbs(
milind-ufc8ab702023-02-26 14:14:39 -0800128 *fbb, detection.det.id, position_offset, orientation_offset,
milind-uf5b3b4b2023-02-26 14:50:38 -0800129 detection.det.decision_margin, detection.pose_error,
130 detection.distortion_factor);
Maxwell Hendersonfebee252023-01-28 16:53:52 -0800131}
132
milind-uf2a4e322023-02-01 19:33:10 -0800133void AprilRoboticsDetector::UndistortDetection(
134 apriltag_detection_t *det) const {
135 // 4 corners
136 constexpr size_t kRows = 4;
137 // 2d points
138 constexpr size_t kCols = 2;
139
140 cv::Mat distorted_points(kRows, kCols, CV_64F, det->p);
141 cv::Mat undistorted_points = cv::Mat::zeros(kRows, kCols, CV_64F);
142
143 // Undistort the april tag points
144 cv::undistortPoints(distorted_points, undistorted_points, intrinsics_,
145 dist_coeffs_, cv::noArray(), projection_matrix_);
146
147 // Copy the undistorted points into det
148 for (size_t i = 0; i < kRows; i++) {
149 for (size_t j = 0; j < kCols; j++) {
150 det->p[i][j] = undistorted_points.at<double>(i, j);
151 }
152 }
153}
154
milind-uf5b3b4b2023-02-26 14:50:38 -0800155double AprilRoboticsDetector::ComputeDistortionFactor(
156 const std::vector<cv::Point2f> &orig_corners,
157 const std::vector<cv::Point2f> &corners) {
158 CHECK_EQ(orig_corners.size(), 4ul);
159 CHECK_EQ(corners.size(), 4ul);
160
161 double avg_distance = 0.0;
162 for (size_t i = 0; i < corners.size(); i++) {
163 avg_distance += cv::norm(orig_corners[i] - corners[i]);
164 }
165 avg_distance /= corners.size();
166
milind-u8773c232023-03-11 14:59:06 -0800167 // Normalize avg_distance by dividing by the image diagonal,
168 // and then the maximum expected distortion
milind-uf5b3b4b2023-02-26 14:50:38 -0800169 double distortion_factor =
170 avg_distance /
milind-u8773c232023-03-11 14:59:06 -0800171 cv::norm(cv::Point2d(image_size_.width, image_size_.height));
milind-u60e7fe52023-02-26 16:13:50 -0800172 return std::min(distortion_factor / FLAGS_max_expected_distortion, 1.0);
milind-uf5b3b4b2023-02-26 14:50:38 -0800173}
174
Jim Ostrowski5e2c5e62023-02-26 12:52:56 -0800175std::vector<cv::Point2f> AprilRoboticsDetector::MakeCornerVector(
176 const apriltag_detection_t *det) {
177 std::vector<cv::Point2f> corner_points;
178 corner_points.emplace_back(det->p[0][0], det->p[0][1]);
179 corner_points.emplace_back(det->p[1][0], det->p[1][1]);
180 corner_points.emplace_back(det->p[2][0], det->p[2][1]);
181 corner_points.emplace_back(det->p[3][0], det->p[3][1]);
182
183 return corner_points;
184}
185
milind-u99b1a762023-03-12 16:48:32 -0700186AprilRoboticsDetector::DetectionResult AprilRoboticsDetector::DetectTags(
milind-ufc8ab702023-02-26 14:14:39 -0800187 cv::Mat image, aos::monotonic_clock::time_point eof) {
Jim Ostrowski49be8232023-03-23 01:00:14 -0700188 cv::Mat color_image;
189 cvtColor(image, color_image, cv::COLOR_GRAY2RGB);
Maxwell Hendersonfebee252023-01-28 16:53:52 -0800190 const aos::monotonic_clock::time_point start_time =
191 aos::monotonic_clock::now();
192
193 image_u8_t im = {
milind-u09fb1252023-01-28 19:21:41 -0800194 .width = image.cols,
195 .height = image.rows,
196 .stride = image.cols,
197 .buf = image.data,
Maxwell Hendersonfebee252023-01-28 16:53:52 -0800198 };
Jim Ostrowski437b1fb2023-02-26 10:12:01 -0800199 const uint32_t min_x = FLAGS_pixel_border;
200 const uint32_t max_x = image.cols - FLAGS_pixel_border;
Jim Ostrowski0197d6b2023-03-04 12:41:13 -0800201 const uint32_t min_y = FLAGS_pixel_border;
202 const uint32_t max_y = image.rows - FLAGS_pixel_border;
Maxwell Hendersonfebee252023-01-28 16:53:52 -0800203
204 ftrace_.FormatMessage("Starting detect\n");
205 zarray_t *detections = apriltag_detector_detect(tag_detector_, &im);
206 ftrace_.FormatMessage("Done detecting\n");
207
milind-ufc8ab702023-02-26 14:14:39 -0800208 std::vector<Detection> results;
Maxwell Hendersonfebee252023-01-28 16:53:52 -0800209
milind-u7aa29e22023-02-23 20:22:01 -0800210 auto builder = image_annotations_sender_.MakeBuilder();
Jim Ostrowski5e2c5e62023-02-26 12:52:56 -0800211 std::vector<flatbuffers::Offset<foxglove::PointsAnnotation>> foxglove_corners;
Yash Chainani728ae222023-02-04 19:48:12 -0800212
Maxwell Hendersonfebee252023-01-28 16:53:52 -0800213 for (int i = 0; i < zarray_size(detections); i++) {
214 apriltag_detection_t *det;
215 zarray_get(detections, i, &det);
216
milind-uf2a4e322023-02-01 19:33:10 -0800217 if (det->decision_margin > FLAGS_min_decision_margin) {
Jim Ostrowski437b1fb2023-02-26 10:12:01 -0800218 if (det->p[0][0] < min_x || det->p[0][0] > max_x ||
219 det->p[1][0] < min_x || det->p[1][0] > max_x ||
220 det->p[2][0] < min_x || det->p[2][0] > max_x ||
Jim Ostrowski0197d6b2023-03-04 12:41:13 -0800221 det->p[3][0] < min_x || det->p[3][0] > max_x ||
222 det->p[0][1] < min_y || det->p[0][1] > max_y ||
223 det->p[1][1] < min_y || det->p[1][1] > max_y ||
224 det->p[2][1] < min_y || det->p[2][1] > max_y ||
225 det->p[3][1] < min_y || det->p[3][1] > max_y) {
Jim Ostrowski437b1fb2023-02-26 10:12:01 -0800226 VLOG(1) << "Rejecting detection because corner is outside pixel border";
Jim Ostrowski5e2c5e62023-02-26 12:52:56 -0800227 // Send rejected corner points in red
228 std::vector<cv::Point2f> rejected_corner_points = MakeCornerVector(det);
229 foxglove_corners.push_back(frc971::vision::BuildPointsAnnotation(
230 builder.fbb(), eof, rejected_corner_points,
231 std::vector<double>{1.0, 0.0, 0.0, 0.5}));
Jim Ostrowski437b1fb2023-02-26 10:12:01 -0800232 continue;
233 }
Maxwell Hendersonfebee252023-01-28 16:53:52 -0800234 VLOG(1) << "Found tag number " << det->id << " hamming: " << det->hamming
235 << " margin: " << det->decision_margin;
236
Maxwell Hendersonfebee252023-01-28 16:53:52 -0800237 // First create an apriltag_detection_info_t struct using your known
238 // parameters.
239 apriltag_detection_info_t info;
240 info.det = det;
241 info.tagsize = 0.1524;
milind-uf2a4e322023-02-01 19:33:10 -0800242
Maxwell Hendersonfebee252023-01-28 16:53:52 -0800243 info.fx = intrinsics_.at<double>(0, 0);
244 info.fy = intrinsics_.at<double>(1, 1);
245 info.cx = intrinsics_.at<double>(0, 2);
246 info.cy = intrinsics_.at<double>(1, 2);
247
Jim Ostrowski5e2c5e62023-02-26 12:52:56 -0800248 // Send original corner points in green
249 std::vector<cv::Point2f> orig_corner_points = MakeCornerVector(det);
250 foxglove_corners.push_back(frc971::vision::BuildPointsAnnotation(
251 builder.fbb(), eof, orig_corner_points,
252 std::vector<double>{0.0, 1.0, 0.0, 0.5}));
Jim Ostrowskid2b5c912023-02-26 00:59:35 -0800253
milind-ueccac3c2023-02-25 20:54:47 -0800254 UndistortDetection(det);
255
milind-uf5b3b4b2023-02-26 14:50:38 -0800256 const aos::monotonic_clock::time_point before_pose_estimation =
257 aos::monotonic_clock::now();
258
Maxwell Hendersonfebee252023-01-28 16:53:52 -0800259 apriltag_pose_t pose;
milind-uf5b3b4b2023-02-26 14:50:38 -0800260 double pose_error = estimate_tag_pose(&info, &pose);
Maxwell Hendersonfebee252023-01-28 16:53:52 -0800261
262 const aos::monotonic_clock::time_point after_pose_estimation =
263 aos::monotonic_clock::now();
Maxwell Hendersonfebee252023-01-28 16:53:52 -0800264 VLOG(1) << "Took "
Austin Schuhd2667932023-02-04 16:22:39 -0800265 << chrono::duration<double>(after_pose_estimation -
266 before_pose_estimation)
Maxwell Hendersonfebee252023-01-28 16:53:52 -0800267 .count()
268 << " seconds for pose estimation";
milind-uf5b3b4b2023-02-26 14:50:38 -0800269 VLOG(1) << "Pose err: " << pose_error;
Yash Chainani728ae222023-02-04 19:48:12 -0800270
Jim Ostrowski5e2c5e62023-02-26 12:52:56 -0800271 // Send undistorted corner points in pink
272 std::vector<cv::Point2f> corner_points = MakeCornerVector(det);
273 foxglove_corners.push_back(frc971::vision::BuildPointsAnnotation(
274 builder.fbb(), eof, corner_points,
275 std::vector<double>{1.0, 0.75, 0.8, 1.0}));
milind-uf5b3b4b2023-02-26 14:50:38 -0800276
277 double distortion_factor =
278 ComputeDistortionFactor(orig_corner_points, corner_points);
279
280 results.emplace_back(Detection{.det = *det,
281 .pose = pose,
282 .pose_error = pose_error,
283 .distortion_factor = distortion_factor});
Jim Ostrowski49be8232023-03-23 01:00:14 -0700284 if (FLAGS_visualize) {
285 // Draw raw (distorted) corner points in green
286 cv::line(color_image, orig_corner_points[0], orig_corner_points[1],
287 cv::Scalar(0, 255, 0), 2);
288 cv::line(color_image, orig_corner_points[1], orig_corner_points[2],
289 cv::Scalar(0, 255, 0), 2);
290 cv::line(color_image, orig_corner_points[2], orig_corner_points[3],
291 cv::Scalar(0, 255, 0), 2);
292 cv::line(color_image, orig_corner_points[3], orig_corner_points[0],
293 cv::Scalar(0, 255, 0), 2);
294
295 // Draw undistorted corner points in red
296 cv::line(color_image, corner_points[0], corner_points[1],
297 cv::Scalar(0, 0, 255), 2);
298 cv::line(color_image, corner_points[2], corner_points[1],
299 cv::Scalar(0, 0, 255), 2);
300 cv::line(color_image, corner_points[2], corner_points[3],
301 cv::Scalar(0, 0, 255), 2);
302 cv::line(color_image, corner_points[0], corner_points[3],
303 cv::Scalar(0, 0, 255), 2);
304 }
305
306 VLOG(1) << "Found tag number " << det->id << " hamming: " << det->hamming
307 << " margin: " << det->decision_margin;
308
milind-u99b1a762023-03-12 16:48:32 -0700309 } else {
310 rejections_++;
Maxwell Hendersonfebee252023-01-28 16:53:52 -0800311 }
312 }
Jim Ostrowski49be8232023-03-23 01:00:14 -0700313 if (FLAGS_visualize) {
314 // Display the result
315 // Rotate by 180 degrees to make it upright
milind-ua30a4a12023-03-24 20:49:41 -0700316 if (flip_image_) {
317 cv::rotate(color_image, color_image, 1);
318 }
319 cv::imshow(absl::StrCat("AprilRoboticsDetector Image ", node_name_),
320 color_image);
Jim Ostrowski49be8232023-03-23 01:00:14 -0700321 }
Maxwell Hendersonfebee252023-01-28 16:53:52 -0800322
Jim Ostrowski5e2c5e62023-02-26 12:52:56 -0800323 const auto corners_offset = builder.fbb()->CreateVector(foxglove_corners);
Yash Chainani10b7b022023-02-22 14:34:04 -0800324 foxglove::ImageAnnotations::Builder annotation_builder(*builder.fbb());
Jim Ostrowski5e2c5e62023-02-26 12:52:56 -0800325 annotation_builder.add_points(corners_offset);
326 builder.CheckOk(builder.Send(annotation_builder.Finish()));
Yash Chainani728ae222023-02-04 19:48:12 -0800327
Maxwell Hendersonfebee252023-01-28 16:53:52 -0800328 apriltag_detections_destroy(detections);
329
330 const aos::monotonic_clock::time_point end_time = aos::monotonic_clock::now();
331
milind-uf3ab8ba2023-02-04 17:56:16 -0800332 if (FLAGS_debug) {
333 timeprofile_display(tag_detector_->tp);
334 }
Maxwell Hendersonfebee252023-01-28 16:53:52 -0800335
Austin Schuhd2667932023-02-04 16:22:39 -0800336 VLOG(1) << "Took " << chrono::duration<double>(end_time - start_time).count()
Maxwell Hendersonfebee252023-01-28 16:53:52 -0800337 << " seconds to detect overall";
338
milind-u99b1a762023-03-12 16:48:32 -0700339 return {.detections = results, .rejections = rejections_};
Maxwell Hendersonfebee252023-01-28 16:53:52 -0800340}
341
Maxwell Hendersonfebee252023-01-28 16:53:52 -0800342} // namespace vision
343} // namespace y2023