Brian Silverman | 9c614bc | 2016-02-15 20:20:02 -0500 | [diff] [blame^] | 1 | // Protocol Buffers - Google's data interchange format |
| 2 | // Copyright 2008 Google Inc. All rights reserved. |
| 3 | // https://developers.google.com/protocol-buffers/ |
| 4 | // |
| 5 | // Redistribution and use in source and binary forms, with or without |
| 6 | // modification, are permitted provided that the following conditions are |
| 7 | // met: |
| 8 | // |
| 9 | // * Redistributions of source code must retain the above copyright |
| 10 | // notice, this list of conditions and the following disclaimer. |
| 11 | // * Redistributions in binary form must reproduce the above |
| 12 | // copyright notice, this list of conditions and the following disclaimer |
| 13 | // in the documentation and/or other materials provided with the |
| 14 | // distribution. |
| 15 | // * Neither the name of Google Inc. nor the names of its |
| 16 | // contributors may be used to endorse or promote products derived from |
| 17 | // this software without specific prior written permission. |
| 18 | // |
| 19 | // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS |
| 20 | // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT |
| 21 | // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR |
| 22 | // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT |
| 23 | // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, |
| 24 | // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT |
| 25 | // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, |
| 26 | // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY |
| 27 | // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT |
| 28 | // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE |
| 29 | // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. |
| 30 | |
| 31 | #include <google/protobuf/arena.h> |
| 32 | |
| 33 | #include <algorithm> |
| 34 | #include <cstring> |
| 35 | #include <memory> |
| 36 | #ifndef _SHARED_PTR_H |
| 37 | #include <google/protobuf/stubs/shared_ptr.h> |
| 38 | #endif |
| 39 | #include <string> |
| 40 | #include <typeinfo> |
| 41 | #include <vector> |
| 42 | |
| 43 | #include <google/protobuf/stubs/logging.h> |
| 44 | #include <google/protobuf/stubs/common.h> |
| 45 | #include <google/protobuf/stubs/scoped_ptr.h> |
| 46 | #include <google/protobuf/arena_test_util.h> |
| 47 | #include <google/protobuf/test_util.h> |
| 48 | #include <google/protobuf/unittest.pb.h> |
| 49 | #include <google/protobuf/unittest_arena.pb.h> |
| 50 | #include <google/protobuf/unittest_no_arena.pb.h> |
| 51 | #include <google/protobuf/io/coded_stream.h> |
| 52 | #include <google/protobuf/io/zero_copy_stream_impl_lite.h> |
| 53 | #include <google/protobuf/descriptor.h> |
| 54 | #include <google/protobuf/extension_set.h> |
| 55 | #include <google/protobuf/message.h> |
| 56 | #include <google/protobuf/message_lite.h> |
| 57 | #include <google/protobuf/repeated_field.h> |
| 58 | #include <google/protobuf/wire_format_lite.h> |
| 59 | #include <google/protobuf/unknown_field_set.h> |
| 60 | #include <gtest/gtest.h> |
| 61 | |
| 62 | |
| 63 | namespace google { |
| 64 | using proto2_arena_unittest::ArenaMessage; |
| 65 | using protobuf_unittest::TestAllTypes; |
| 66 | using protobuf_unittest::TestAllExtensions; |
| 67 | using protobuf_unittest::TestOneof2; |
| 68 | using protobuf_unittest::TestEmptyMessage; |
| 69 | |
| 70 | namespace protobuf { |
| 71 | namespace { |
| 72 | |
| 73 | class Notifier { |
| 74 | public: |
| 75 | Notifier() : count_(0) {} |
| 76 | void Notify() { |
| 77 | count_++; |
| 78 | } |
| 79 | int GetCount() { |
| 80 | return count_; |
| 81 | } |
| 82 | |
| 83 | private: |
| 84 | int count_; |
| 85 | }; |
| 86 | |
| 87 | class SimpleDataType { |
| 88 | public: |
| 89 | SimpleDataType() : notifier_(NULL) {} |
| 90 | void SetNotifier(Notifier* notifier) { |
| 91 | notifier_ = notifier; |
| 92 | } |
| 93 | virtual ~SimpleDataType() { |
| 94 | if (notifier_ != NULL) { |
| 95 | notifier_->Notify(); |
| 96 | } |
| 97 | }; |
| 98 | private: |
| 99 | Notifier* notifier_; |
| 100 | }; |
| 101 | |
| 102 | // A simple class that does not allow copying and so cannot be used as a |
| 103 | // parameter type without "const &". |
| 104 | class PleaseDontCopyMe { |
| 105 | public: |
| 106 | explicit PleaseDontCopyMe(int value) : value_(value) {} |
| 107 | |
| 108 | int value() const { return value_; } |
| 109 | |
| 110 | private: |
| 111 | int value_; |
| 112 | GOOGLE_DISALLOW_EVIL_CONSTRUCTORS(PleaseDontCopyMe); |
| 113 | }; |
| 114 | |
| 115 | // A class that takes four different types as constructor arguments. |
| 116 | class MustBeConstructedWithOneThroughFour { |
| 117 | public: |
| 118 | MustBeConstructedWithOneThroughFour( |
| 119 | int one, const char* two, const string& three, |
| 120 | const PleaseDontCopyMe* four) |
| 121 | : one_(one), two_(two), three_(three), four_(four) {} |
| 122 | |
| 123 | int one_; |
| 124 | const char* const two_; |
| 125 | string three_; |
| 126 | const PleaseDontCopyMe* four_; |
| 127 | |
| 128 | private: |
| 129 | GOOGLE_DISALLOW_EVIL_CONSTRUCTORS(MustBeConstructedWithOneThroughFour); |
| 130 | }; |
| 131 | |
| 132 | // A class that takes eight different types as constructor arguments. |
| 133 | class MustBeConstructedWithOneThroughEight { |
| 134 | public: |
| 135 | MustBeConstructedWithOneThroughEight( |
| 136 | int one, const char* two, const string& three, |
| 137 | const PleaseDontCopyMe* four, int five, const char* six, |
| 138 | const string& seven, const string& eight) |
| 139 | : one_(one), two_(two), three_(three), four_(four), five_(five), |
| 140 | six_(six), seven_(seven), eight_(eight) {} |
| 141 | |
| 142 | int one_; |
| 143 | const char* const two_; |
| 144 | string three_; |
| 145 | const PleaseDontCopyMe* four_; |
| 146 | int five_; |
| 147 | const char* const six_; |
| 148 | string seven_; |
| 149 | string eight_; |
| 150 | |
| 151 | private: |
| 152 | GOOGLE_DISALLOW_EVIL_CONSTRUCTORS(MustBeConstructedWithOneThroughEight); |
| 153 | }; |
| 154 | |
| 155 | } // namespace |
| 156 | |
| 157 | TEST(ArenaTest, ArenaConstructable) { |
| 158 | EXPECT_TRUE(Arena::is_arena_constructable<TestAllTypes>::type::value); |
| 159 | EXPECT_TRUE(Arena::is_arena_constructable<const TestAllTypes>::type::value); |
| 160 | EXPECT_FALSE(Arena::is_arena_constructable<Arena>::type::value); |
| 161 | } |
| 162 | |
| 163 | TEST(ArenaTest, BasicCreate) { |
| 164 | Arena arena; |
| 165 | EXPECT_TRUE(Arena::Create<int32>(&arena) != NULL); |
| 166 | EXPECT_TRUE(Arena::Create<int64>(&arena) != NULL); |
| 167 | EXPECT_TRUE(Arena::Create<float>(&arena) != NULL); |
| 168 | EXPECT_TRUE(Arena::Create<double>(&arena) != NULL); |
| 169 | EXPECT_TRUE(Arena::Create<string>(&arena) != NULL); |
| 170 | arena.Own(new int32); |
| 171 | arena.Own(new int64); |
| 172 | arena.Own(new float); |
| 173 | arena.Own(new double); |
| 174 | arena.Own(new string); |
| 175 | arena.Own<int>(NULL); |
| 176 | Notifier notifier; |
| 177 | SimpleDataType* data = Arena::Create<SimpleDataType>(&arena); |
| 178 | data->SetNotifier(¬ifier); |
| 179 | data = new SimpleDataType; |
| 180 | data->SetNotifier(¬ifier); |
| 181 | arena.Own(data); |
| 182 | arena.Reset(); |
| 183 | EXPECT_EQ(2, notifier.GetCount()); |
| 184 | } |
| 185 | |
| 186 | TEST(ArenaTest, CreateWithFourConstructorArguments) { |
| 187 | Arena arena; |
| 188 | const string three("3"); |
| 189 | const PleaseDontCopyMe four(4); |
| 190 | const MustBeConstructedWithOneThroughFour* new_object = |
| 191 | Arena::Create<MustBeConstructedWithOneThroughFour>( |
| 192 | &arena, 1, "2", three, &four); |
| 193 | EXPECT_TRUE(new_object != NULL); |
| 194 | ASSERT_EQ(1, new_object->one_); |
| 195 | ASSERT_STREQ("2", new_object->two_); |
| 196 | ASSERT_EQ("3", new_object->three_); |
| 197 | ASSERT_EQ(4, new_object->four_->value()); |
| 198 | } |
| 199 | |
| 200 | TEST(ArenaTest, CreateWithEightConstructorArguments) { |
| 201 | Arena arena; |
| 202 | const string three("3"); |
| 203 | const PleaseDontCopyMe four(4); |
| 204 | const string seven("7"); |
| 205 | const string eight("8"); |
| 206 | const MustBeConstructedWithOneThroughEight* new_object = |
| 207 | Arena::Create<MustBeConstructedWithOneThroughEight>( |
| 208 | &arena, 1, "2", three, &four, 5, "6", seven, eight); |
| 209 | EXPECT_TRUE(new_object != NULL); |
| 210 | ASSERT_EQ(1, new_object->one_); |
| 211 | ASSERT_STREQ("2", new_object->two_); |
| 212 | ASSERT_EQ("3", new_object->three_); |
| 213 | ASSERT_EQ(4, new_object->four_->value()); |
| 214 | ASSERT_EQ(5, new_object->five_); |
| 215 | ASSERT_STREQ("6", new_object->six_); |
| 216 | ASSERT_EQ("7", new_object->seven_); |
| 217 | ASSERT_EQ("8", new_object->eight_); |
| 218 | } |
| 219 | |
| 220 | TEST(ArenaTest, InitialBlockTooSmall) { |
| 221 | // Construct a small (64 byte) initial block of memory to be used by the |
| 222 | // arena allocator; then, allocate an object which will not fit in the |
| 223 | // initial block. |
| 224 | std::vector<char> arena_block(64); |
| 225 | ArenaOptions options; |
| 226 | options.initial_block = &arena_block[0]; |
| 227 | options.initial_block_size = arena_block.size(); |
| 228 | Arena arena(options); |
| 229 | |
| 230 | char* p = ::google::protobuf::Arena::CreateArray<char>(&arena, 96); |
| 231 | uintptr_t allocation = reinterpret_cast<uintptr_t>(p); |
| 232 | |
| 233 | // Ensure that the arena allocator did not return memory pointing into the |
| 234 | // initial block of memory. |
| 235 | uintptr_t arena_start = reinterpret_cast<uintptr_t>(&arena_block[0]); |
| 236 | uintptr_t arena_end = arena_start + arena_block.size(); |
| 237 | EXPECT_FALSE(allocation >= arena_start && allocation < arena_end); |
| 238 | |
| 239 | // Write to the memory we allocated; this should (but is not guaranteed to) |
| 240 | // trigger a check for heap corruption if the object was allocated from the |
| 241 | // initially-provided block. |
| 242 | memset(p, '\0', 96); |
| 243 | } |
| 244 | |
| 245 | TEST(ArenaTest, Parsing) { |
| 246 | TestAllTypes original; |
| 247 | TestUtil::SetAllFields(&original); |
| 248 | |
| 249 | // Test memory leak. |
| 250 | Arena arena; |
| 251 | TestAllTypes* arena_message = Arena::CreateMessage<TestAllTypes>(&arena); |
| 252 | arena_message->ParseFromString(original.SerializeAsString()); |
| 253 | TestUtil::ExpectAllFieldsSet(*arena_message); |
| 254 | |
| 255 | // Test that string fields have null terminator bytes (earlier bug). |
| 256 | EXPECT_EQ(strlen(original.optional_string().c_str()), |
| 257 | strlen(arena_message->optional_string().c_str())); |
| 258 | } |
| 259 | |
| 260 | TEST(ArenaTest, UnknownFields) { |
| 261 | TestAllTypes original; |
| 262 | TestUtil::SetAllFields(&original); |
| 263 | |
| 264 | // Test basic parsing into (populating) and reading out of unknown fields on |
| 265 | // an arena. |
| 266 | Arena arena; |
| 267 | TestEmptyMessage* arena_message = |
| 268 | Arena::CreateMessage<TestEmptyMessage>(&arena); |
| 269 | arena_message->ParseFromString(original.SerializeAsString()); |
| 270 | |
| 271 | TestAllTypes copied; |
| 272 | copied.ParseFromString(arena_message->SerializeAsString()); |
| 273 | TestUtil::ExpectAllFieldsSet(copied); |
| 274 | |
| 275 | // Exercise UFS manual manipulation (setters). |
| 276 | arena_message = Arena::CreateMessage<TestEmptyMessage>(&arena); |
| 277 | arena_message->mutable_unknown_fields()->AddVarint( |
| 278 | TestAllTypes::kOptionalInt32FieldNumber, 42); |
| 279 | copied.Clear(); |
| 280 | copied.ParseFromString(arena_message->SerializeAsString()); |
| 281 | EXPECT_TRUE(copied.has_optional_int32()); |
| 282 | EXPECT_EQ(42, copied.optional_int32()); |
| 283 | |
| 284 | // Exercise UFS swap path. |
| 285 | TestEmptyMessage* arena_message_2 = |
| 286 | Arena::CreateMessage<TestEmptyMessage>(&arena); |
| 287 | arena_message_2->Swap(arena_message); |
| 288 | copied.Clear(); |
| 289 | copied.ParseFromString(arena_message_2->SerializeAsString()); |
| 290 | EXPECT_TRUE(copied.has_optional_int32()); |
| 291 | EXPECT_EQ(42, copied.optional_int32()); |
| 292 | |
| 293 | // Test field manipulation. |
| 294 | TestEmptyMessage* arena_message_3 = |
| 295 | Arena::CreateMessage<TestEmptyMessage>(&arena); |
| 296 | arena_message_3->mutable_unknown_fields()->AddVarint(1000, 42); |
| 297 | arena_message_3->mutable_unknown_fields()->AddFixed32(1001, 42); |
| 298 | arena_message_3->mutable_unknown_fields()->AddFixed64(1002, 42); |
| 299 | arena_message_3->mutable_unknown_fields()->AddLengthDelimited(1003); |
| 300 | arena_message_3->mutable_unknown_fields()->DeleteSubrange(0, 2); |
| 301 | arena_message_3->mutable_unknown_fields()->DeleteByNumber(1002); |
| 302 | arena_message_3->mutable_unknown_fields()->DeleteByNumber(1003); |
| 303 | EXPECT_TRUE(arena_message_3->unknown_fields().empty()); |
| 304 | } |
| 305 | |
| 306 | TEST(ArenaTest, Swap) { |
| 307 | Arena arena1; |
| 308 | Arena arena2; |
| 309 | TestAllTypes* arena1_message; |
| 310 | TestAllTypes* arena2_message; |
| 311 | |
| 312 | // Case 1: Swap(), no UFS on either message, both messages on different |
| 313 | // arenas. Arena pointers should remain the same after swap. |
| 314 | arena1_message = Arena::CreateMessage<TestAllTypes>(&arena1); |
| 315 | arena2_message = Arena::CreateMessage<TestAllTypes>(&arena2); |
| 316 | arena1_message->Swap(arena2_message); |
| 317 | EXPECT_EQ(&arena1, arena1_message->GetArena()); |
| 318 | EXPECT_EQ(&arena2, arena2_message->GetArena()); |
| 319 | |
| 320 | // Case 2: Swap(), UFS on one message, both messages on different arenas. |
| 321 | arena1_message = Arena::CreateMessage<TestAllTypes>(&arena1); |
| 322 | arena2_message = Arena::CreateMessage<TestAllTypes>(&arena2); |
| 323 | arena1_message->mutable_unknown_fields()->AddVarint(1, 42); |
| 324 | arena1_message->Swap(arena2_message); |
| 325 | EXPECT_EQ(&arena1, arena1_message->GetArena()); |
| 326 | EXPECT_EQ(&arena2, arena2_message->GetArena()); |
| 327 | EXPECT_EQ(0, arena1_message->unknown_fields().field_count()); |
| 328 | EXPECT_EQ(1, arena2_message->unknown_fields().field_count()); |
| 329 | EXPECT_EQ(42, arena2_message->unknown_fields().field(0).varint()); |
| 330 | |
| 331 | // Case 3: Swap(), UFS on both messages, both messages on different arenas. |
| 332 | arena1_message = Arena::CreateMessage<TestAllTypes>(&arena1); |
| 333 | arena2_message = Arena::CreateMessage<TestAllTypes>(&arena2); |
| 334 | arena1_message->mutable_unknown_fields()->AddVarint(1, 42); |
| 335 | arena2_message->mutable_unknown_fields()->AddVarint(2, 84); |
| 336 | arena1_message->Swap(arena2_message); |
| 337 | EXPECT_EQ(&arena1, arena1_message->GetArena()); |
| 338 | EXPECT_EQ(&arena2, arena2_message->GetArena()); |
| 339 | EXPECT_EQ(1, arena1_message->unknown_fields().field_count()); |
| 340 | EXPECT_EQ(1, arena2_message->unknown_fields().field_count()); |
| 341 | EXPECT_EQ(84, arena1_message->unknown_fields().field(0).varint()); |
| 342 | EXPECT_EQ(42, arena2_message->unknown_fields().field(0).varint()); |
| 343 | } |
| 344 | |
| 345 | TEST(ArenaTest, SetAllocatedMessage) { |
| 346 | Arena arena; |
| 347 | TestAllTypes *arena_message = Arena::CreateMessage<TestAllTypes>(&arena); |
| 348 | TestAllTypes::NestedMessage* nested = new TestAllTypes::NestedMessage; |
| 349 | nested->set_bb(118); |
| 350 | arena_message->set_allocated_optional_nested_message(nested); |
| 351 | EXPECT_EQ(118, arena_message->optional_nested_message().bb()); |
| 352 | |
| 353 | protobuf_unittest_no_arena::TestNoArenaMessage no_arena_message; |
| 354 | EXPECT_FALSE(no_arena_message.has_arena_message()); |
| 355 | no_arena_message.set_allocated_arena_message(NULL); |
| 356 | EXPECT_FALSE(no_arena_message.has_arena_message()); |
| 357 | no_arena_message.set_allocated_arena_message(new ArenaMessage); |
| 358 | EXPECT_TRUE(no_arena_message.has_arena_message()); |
| 359 | } |
| 360 | |
| 361 | TEST(ArenaTest, ReleaseMessage) { |
| 362 | Arena arena; |
| 363 | TestAllTypes* arena_message = Arena::CreateMessage<TestAllTypes>(&arena); |
| 364 | arena_message->mutable_optional_nested_message()->set_bb(118); |
| 365 | google::protobuf::scoped_ptr<TestAllTypes::NestedMessage> nested( |
| 366 | arena_message->release_optional_nested_message()); |
| 367 | EXPECT_EQ(118, nested->bb()); |
| 368 | |
| 369 | TestAllTypes::NestedMessage* released_null = |
| 370 | arena_message->release_optional_nested_message(); |
| 371 | EXPECT_EQ(NULL, released_null); |
| 372 | } |
| 373 | |
| 374 | TEST(ArenaTest, SetAllocatedString) { |
| 375 | Arena arena; |
| 376 | TestAllTypes* arena_message = Arena::CreateMessage<TestAllTypes>(&arena); |
| 377 | string* allocated_str = new string("hello"); |
| 378 | arena_message->set_allocated_optional_string(allocated_str); |
| 379 | EXPECT_EQ("hello", arena_message->optional_string()); |
| 380 | } |
| 381 | |
| 382 | TEST(ArenaTest, ReleaseString) { |
| 383 | Arena arena; |
| 384 | TestAllTypes* arena_message = Arena::CreateMessage<TestAllTypes>(&arena); |
| 385 | arena_message->set_optional_string("hello"); |
| 386 | google::protobuf::scoped_ptr<string> released_str( |
| 387 | arena_message->release_optional_string()); |
| 388 | EXPECT_EQ("hello", *released_str); |
| 389 | |
| 390 | // Test default value. |
| 391 | } |
| 392 | |
| 393 | |
| 394 | TEST(ArenaTest, SwapBetweenArenasWithAllFieldsSet) { |
| 395 | Arena arena1; |
| 396 | TestAllTypes* arena1_message = Arena::CreateMessage<TestAllTypes>(&arena1); |
| 397 | { |
| 398 | Arena arena2; |
| 399 | TestAllTypes* arena2_message = Arena::CreateMessage<TestAllTypes>(&arena2); |
| 400 | TestUtil::SetAllFields(arena2_message); |
| 401 | arena2_message->Swap(arena1_message); |
| 402 | string output; |
| 403 | arena2_message->SerializeToString(&output); |
| 404 | EXPECT_EQ(0, output.size()); |
| 405 | } |
| 406 | TestUtil::ExpectAllFieldsSet(*arena1_message); |
| 407 | } |
| 408 | |
| 409 | TEST(ArenaTest, SwapBetweenArenaAndNonArenaWithAllFieldsSet) { |
| 410 | TestAllTypes non_arena_message; |
| 411 | TestUtil::SetAllFields(&non_arena_message); |
| 412 | { |
| 413 | Arena arena2; |
| 414 | TestAllTypes* arena2_message = Arena::CreateMessage<TestAllTypes>(&arena2); |
| 415 | TestUtil::SetAllFields(arena2_message); |
| 416 | arena2_message->Swap(&non_arena_message); |
| 417 | TestUtil::ExpectAllFieldsSet(*arena2_message); |
| 418 | TestUtil::ExpectAllFieldsSet(non_arena_message); |
| 419 | } |
| 420 | } |
| 421 | |
| 422 | TEST(ArenaTest, UnsafeArenaSwap) { |
| 423 | Arena shared_arena; |
| 424 | TestAllTypes* message1 = Arena::CreateMessage<TestAllTypes>(&shared_arena); |
| 425 | TestAllTypes* message2 = Arena::CreateMessage<TestAllTypes>(&shared_arena); |
| 426 | TestUtil::SetAllFields(message1); |
| 427 | message1->UnsafeArenaSwap(message2); |
| 428 | TestUtil::ExpectAllFieldsSet(*message2); |
| 429 | } |
| 430 | |
| 431 | TEST(ArenaTest, SwapBetweenArenasUsingReflection) { |
| 432 | Arena arena1; |
| 433 | TestAllTypes* arena1_message = Arena::CreateMessage<TestAllTypes>(&arena1); |
| 434 | { |
| 435 | Arena arena2; |
| 436 | TestAllTypes* arena2_message = Arena::CreateMessage<TestAllTypes>(&arena2); |
| 437 | TestUtil::SetAllFields(arena2_message); |
| 438 | const Reflection* r = arena2_message->GetReflection(); |
| 439 | r->Swap(arena1_message, arena2_message); |
| 440 | string output; |
| 441 | arena2_message->SerializeToString(&output); |
| 442 | EXPECT_EQ(0, output.size()); |
| 443 | } |
| 444 | TestUtil::ExpectAllFieldsSet(*arena1_message); |
| 445 | } |
| 446 | |
| 447 | TEST(ArenaTest, SwapBetweenArenaAndNonArenaUsingReflection) { |
| 448 | TestAllTypes non_arena_message; |
| 449 | TestUtil::SetAllFields(&non_arena_message); |
| 450 | { |
| 451 | Arena arena2; |
| 452 | TestAllTypes* arena2_message = Arena::CreateMessage<TestAllTypes>(&arena2); |
| 453 | TestUtil::SetAllFields(arena2_message); |
| 454 | const Reflection* r = arena2_message->GetReflection(); |
| 455 | r->Swap(&non_arena_message, arena2_message); |
| 456 | TestUtil::ExpectAllFieldsSet(*arena2_message); |
| 457 | TestUtil::ExpectAllFieldsSet(non_arena_message); |
| 458 | } |
| 459 | } |
| 460 | |
| 461 | TEST(ArenaTest, ReleaseFromArenaMessageMakesCopy) { |
| 462 | TestAllTypes::NestedMessage* nested_msg = NULL; |
| 463 | string* nested_string = NULL; |
| 464 | { |
| 465 | Arena arena; |
| 466 | TestAllTypes* arena_message = Arena::CreateMessage<TestAllTypes>(&arena); |
| 467 | arena_message->mutable_optional_nested_message()->set_bb(42); |
| 468 | *arena_message->mutable_optional_string() = "Hello"; |
| 469 | nested_msg = arena_message->release_optional_nested_message(); |
| 470 | nested_string = arena_message->release_optional_string(); |
| 471 | } |
| 472 | EXPECT_EQ(42, nested_msg->bb()); |
| 473 | EXPECT_EQ("Hello", *nested_string); |
| 474 | delete nested_msg; |
| 475 | delete nested_string; |
| 476 | } |
| 477 | |
| 478 | #ifndef GOOGLE_PROTOBUF_NO_RTTI |
| 479 | TEST(ArenaTest, ReleaseFromArenaMessageUsingReflectionMakesCopy) { |
| 480 | TestAllTypes::NestedMessage* nested_msg = NULL; |
| 481 | // Note: no string: reflection API only supports releasing submessages. |
| 482 | { |
| 483 | Arena arena; |
| 484 | TestAllTypes* arena_message = Arena::CreateMessage<TestAllTypes>(&arena); |
| 485 | arena_message->mutable_optional_nested_message()->set_bb(42); |
| 486 | const Reflection* r = arena_message->GetReflection(); |
| 487 | const FieldDescriptor* f = arena_message->GetDescriptor()->FindFieldByName( |
| 488 | "optional_nested_message"); |
| 489 | nested_msg = static_cast<TestAllTypes::NestedMessage*>( |
| 490 | r->ReleaseMessage(arena_message, f)); |
| 491 | } |
| 492 | EXPECT_EQ(42, nested_msg->bb()); |
| 493 | delete nested_msg; |
| 494 | } |
| 495 | #endif // !GOOGLE_PROTOBUF_NO_RTTI |
| 496 | |
| 497 | TEST(ArenaTest, UnsafeArenaReleaseDoesNotMakeCopy) { |
| 498 | Arena arena; |
| 499 | TestAllTypes* arena_message = Arena::CreateMessage<TestAllTypes>(&arena); |
| 500 | TestAllTypes::NestedMessage* nested_msg = NULL; |
| 501 | TestAllTypes::NestedMessage* orig_nested_msg = NULL; |
| 502 | string* nested_string = NULL; |
| 503 | string* orig_nested_string = NULL; |
| 504 | arena_message->mutable_optional_nested_message()->set_bb(42); |
| 505 | *arena_message->mutable_optional_string() = "Hello"; |
| 506 | orig_nested_msg = arena_message->mutable_optional_nested_message(); |
| 507 | orig_nested_string = arena_message->mutable_optional_string(); |
| 508 | nested_msg = arena_message->unsafe_arena_release_optional_nested_message(); |
| 509 | nested_string = arena_message->unsafe_arena_release_optional_string(); |
| 510 | |
| 511 | EXPECT_EQ(orig_nested_msg, nested_msg); |
| 512 | EXPECT_EQ(orig_nested_string, nested_string); |
| 513 | // Released pointers still on arena; no 'delete' calls needed here. |
| 514 | } |
| 515 | |
| 516 | TEST(ArenaTest, SetAllocatedAcrossArenas) { |
| 517 | Arena arena1; |
| 518 | TestAllTypes* arena1_message = Arena::CreateMessage<TestAllTypes>(&arena1); |
| 519 | TestAllTypes::NestedMessage* heap_submessage = |
| 520 | new TestAllTypes::NestedMessage(); |
| 521 | heap_submessage->set_bb(42); |
| 522 | arena1_message->set_allocated_optional_nested_message(heap_submessage); |
| 523 | // Should keep same object and add to arena's Own()-list. |
| 524 | EXPECT_EQ(heap_submessage, |
| 525 | arena1_message->mutable_optional_nested_message()); |
| 526 | { |
| 527 | Arena arena2; |
| 528 | TestAllTypes::NestedMessage* arena2_submessage = |
| 529 | Arena::CreateMessage<TestAllTypes::NestedMessage>(&arena2); |
| 530 | arena2_submessage->set_bb(42); |
| 531 | arena1_message->set_allocated_optional_nested_message(arena2_submessage); |
| 532 | EXPECT_NE(arena2_submessage, |
| 533 | arena1_message->mutable_optional_nested_message()); |
| 534 | } |
| 535 | |
| 536 | TestAllTypes::NestedMessage* arena1_submessage = |
| 537 | Arena::CreateMessage<TestAllTypes::NestedMessage>(&arena1); |
| 538 | arena1_submessage->set_bb(42); |
| 539 | TestAllTypes* heap_message = new TestAllTypes; |
| 540 | heap_message->set_allocated_optional_nested_message(arena1_submessage); |
| 541 | EXPECT_NE(arena1_submessage, |
| 542 | heap_message->mutable_optional_nested_message()); |
| 543 | delete heap_message; |
| 544 | } |
| 545 | |
| 546 | TEST(ArenaTest, SetAllocatedAcrossArenasWithReflection) { |
| 547 | // Same as above, with reflection. |
| 548 | Arena arena1; |
| 549 | TestAllTypes* arena1_message = Arena::CreateMessage<TestAllTypes>(&arena1); |
| 550 | const Reflection* r = arena1_message->GetReflection(); |
| 551 | const Descriptor* d = arena1_message->GetDescriptor(); |
| 552 | const FieldDescriptor* msg_field = d->FindFieldByName( |
| 553 | "optional_nested_message"); |
| 554 | TestAllTypes::NestedMessage* heap_submessage = |
| 555 | new TestAllTypes::NestedMessage(); |
| 556 | heap_submessage->set_bb(42); |
| 557 | r->SetAllocatedMessage(arena1_message, heap_submessage, msg_field); |
| 558 | // Should keep same object and add to arena's Own()-list. |
| 559 | EXPECT_EQ(heap_submessage, |
| 560 | arena1_message->mutable_optional_nested_message()); |
| 561 | { |
| 562 | Arena arena2; |
| 563 | TestAllTypes::NestedMessage* arena2_submessage = |
| 564 | Arena::CreateMessage<TestAllTypes::NestedMessage>(&arena2); |
| 565 | arena2_submessage->set_bb(42); |
| 566 | r->SetAllocatedMessage(arena1_message, arena2_submessage, msg_field); |
| 567 | EXPECT_NE(arena2_submessage, |
| 568 | arena1_message->mutable_optional_nested_message()); |
| 569 | } |
| 570 | |
| 571 | TestAllTypes::NestedMessage* arena1_submessage = |
| 572 | Arena::CreateMessage<TestAllTypes::NestedMessage>(&arena1); |
| 573 | arena1_submessage->set_bb(42); |
| 574 | TestAllTypes* heap_message = new TestAllTypes; |
| 575 | r->SetAllocatedMessage(heap_message, arena1_submessage, msg_field); |
| 576 | EXPECT_NE(arena1_submessage, |
| 577 | heap_message->mutable_optional_nested_message()); |
| 578 | delete heap_message; |
| 579 | } |
| 580 | |
| 581 | TEST(ArenaTest, AddAllocatedWithReflection) { |
| 582 | Arena arena1; |
| 583 | ArenaMessage* arena1_message = Arena::CreateMessage<ArenaMessage>(&arena1); |
| 584 | const Reflection* r = arena1_message->GetReflection(); |
| 585 | const Descriptor* d = arena1_message->GetDescriptor(); |
| 586 | const FieldDescriptor* fd = |
| 587 | d->FindFieldByName("repeated_import_no_arena_message"); |
| 588 | // Message with cc_enable_arenas = false; |
| 589 | r->AddMessage(arena1_message, fd); |
| 590 | r->AddMessage(arena1_message, fd); |
| 591 | r->AddMessage(arena1_message, fd); |
| 592 | EXPECT_EQ(3, r->FieldSize(*arena1_message, fd)); |
| 593 | // Message with cc_enable_arenas = true; |
| 594 | fd = d->FindFieldByName("repeated_nested_message"); |
| 595 | r->AddMessage(arena1_message, fd); |
| 596 | r->AddMessage(arena1_message, fd); |
| 597 | r->AddMessage(arena1_message, fd); |
| 598 | EXPECT_EQ(3, r->FieldSize(*arena1_message, fd)); |
| 599 | } |
| 600 | |
| 601 | TEST(ArenaTest, RepeatedPtrFieldAddClearedTest) { |
| 602 | { |
| 603 | RepeatedPtrField<TestAllTypes> repeated_field; |
| 604 | EXPECT_TRUE(repeated_field.empty()); |
| 605 | EXPECT_EQ(0, repeated_field.size()); |
| 606 | // Ownership is passed to repeated_field. |
| 607 | TestAllTypes* cleared = new TestAllTypes(); |
| 608 | repeated_field.AddCleared(cleared); |
| 609 | EXPECT_TRUE(repeated_field.empty()); |
| 610 | EXPECT_EQ(0, repeated_field.size()); |
| 611 | } |
| 612 | { |
| 613 | RepeatedPtrField<TestAllTypes> repeated_field; |
| 614 | EXPECT_TRUE(repeated_field.empty()); |
| 615 | EXPECT_EQ(0, repeated_field.size()); |
| 616 | // Ownership is passed to repeated_field. |
| 617 | TestAllTypes* cleared = new TestAllTypes(); |
| 618 | repeated_field.AddAllocated(cleared); |
| 619 | EXPECT_FALSE(repeated_field.empty()); |
| 620 | EXPECT_EQ(1, repeated_field.size()); |
| 621 | } |
| 622 | } |
| 623 | |
| 624 | TEST(ArenaTest, AddAllocatedToRepeatedField) { |
| 625 | // Heap->arena case. |
| 626 | Arena arena1; |
| 627 | TestAllTypes* arena1_message = Arena::CreateMessage<TestAllTypes>(&arena1); |
| 628 | for (int i = 0; i < 10; i++) { |
| 629 | TestAllTypes::NestedMessage* heap_submessage = |
| 630 | new TestAllTypes::NestedMessage(); |
| 631 | heap_submessage->set_bb(42); |
| 632 | arena1_message->mutable_repeated_nested_message()-> |
| 633 | AddAllocated(heap_submessage); |
| 634 | // Should not copy object -- will use arena_->Own(). |
| 635 | EXPECT_EQ(heap_submessage, |
| 636 | &arena1_message->repeated_nested_message(i)); |
| 637 | EXPECT_EQ(42, arena1_message->repeated_nested_message(i).bb()); |
| 638 | } |
| 639 | |
| 640 | // Arena1->Arena2 case. |
| 641 | arena1_message->Clear(); |
| 642 | for (int i = 0; i < 10; i++) { |
| 643 | Arena arena2; |
| 644 | TestAllTypes::NestedMessage* arena2_submessage = |
| 645 | Arena::CreateMessage<TestAllTypes::NestedMessage>(&arena2); |
| 646 | arena2_submessage->set_bb(42); |
| 647 | arena1_message->mutable_repeated_nested_message()-> |
| 648 | AddAllocated(arena2_submessage); |
| 649 | // Should copy object. |
| 650 | EXPECT_NE(arena2_submessage, |
| 651 | &arena1_message->repeated_nested_message(i)); |
| 652 | EXPECT_EQ(42, arena1_message->repeated_nested_message(i).bb()); |
| 653 | } |
| 654 | |
| 655 | // Arena->heap case. |
| 656 | TestAllTypes* heap_message = new TestAllTypes(); |
| 657 | for (int i = 0; i < 10; i++) { |
| 658 | Arena arena2; |
| 659 | TestAllTypes::NestedMessage* arena2_submessage = |
| 660 | Arena::CreateMessage<TestAllTypes::NestedMessage>(&arena2); |
| 661 | arena2_submessage->set_bb(42); |
| 662 | heap_message->mutable_repeated_nested_message()-> |
| 663 | AddAllocated(arena2_submessage); |
| 664 | // Should copy object. |
| 665 | EXPECT_NE(arena2_submessage, |
| 666 | &heap_message->repeated_nested_message(i)); |
| 667 | EXPECT_EQ(42, heap_message->repeated_nested_message(i).bb()); |
| 668 | } |
| 669 | delete heap_message; |
| 670 | |
| 671 | // Heap-arena case for strings (which are not arena-allocated). |
| 672 | arena1_message->Clear(); |
| 673 | for (int i = 0; i < 10; i++) { |
| 674 | string* s = new string("Test"); |
| 675 | arena1_message->mutable_repeated_string()-> |
| 676 | AddAllocated(s); |
| 677 | // Should not copy. |
| 678 | EXPECT_EQ(s, &arena1_message->repeated_string(i)); |
| 679 | EXPECT_EQ("Test", arena1_message->repeated_string(i)); |
| 680 | } |
| 681 | } |
| 682 | |
| 683 | TEST(ArenaTest, AddAllocatedToRepeatedFieldViaReflection) { |
| 684 | // Heap->arena case. |
| 685 | Arena arena1; |
| 686 | TestAllTypes* arena1_message = Arena::CreateMessage<TestAllTypes>(&arena1); |
| 687 | const Reflection* r = arena1_message->GetReflection(); |
| 688 | const Descriptor* d = arena1_message->GetDescriptor(); |
| 689 | const FieldDescriptor* fd = |
| 690 | d->FindFieldByName("repeated_nested_message"); |
| 691 | for (int i = 0; i < 10; i++) { |
| 692 | TestAllTypes::NestedMessage* heap_submessage = |
| 693 | new TestAllTypes::NestedMessage; |
| 694 | heap_submessage->set_bb(42); |
| 695 | r->AddAllocatedMessage(arena1_message, fd, heap_submessage); |
| 696 | // Should not copy object -- will use arena_->Own(). |
| 697 | EXPECT_EQ(heap_submessage, |
| 698 | &arena1_message->repeated_nested_message(i)); |
| 699 | EXPECT_EQ(42, arena1_message->repeated_nested_message(i).bb()); |
| 700 | } |
| 701 | |
| 702 | // Arena1->Arena2 case. |
| 703 | arena1_message->Clear(); |
| 704 | for (int i = 0; i < 10; i++) { |
| 705 | Arena arena2; |
| 706 | TestAllTypes::NestedMessage* arena2_submessage = |
| 707 | Arena::CreateMessage<TestAllTypes::NestedMessage>(&arena2); |
| 708 | arena2_submessage->set_bb(42); |
| 709 | r->AddAllocatedMessage(arena1_message, fd, arena2_submessage); |
| 710 | // Should copy object. |
| 711 | EXPECT_NE(arena2_submessage, |
| 712 | &arena1_message->repeated_nested_message(i)); |
| 713 | EXPECT_EQ(42, arena1_message->repeated_nested_message(i).bb()); |
| 714 | } |
| 715 | |
| 716 | // Arena->heap case. |
| 717 | TestAllTypes* heap_message = new TestAllTypes; |
| 718 | for (int i = 0; i < 10; i++) { |
| 719 | Arena arena2; |
| 720 | TestAllTypes::NestedMessage* arena2_submessage = |
| 721 | Arena::CreateMessage<TestAllTypes::NestedMessage>(&arena2); |
| 722 | arena2_submessage->set_bb(42); |
| 723 | r->AddAllocatedMessage(heap_message, fd, arena2_submessage); |
| 724 | // Should copy object. |
| 725 | EXPECT_NE(arena2_submessage, |
| 726 | &heap_message->repeated_nested_message(i)); |
| 727 | EXPECT_EQ(42, heap_message->repeated_nested_message(i).bb()); |
| 728 | } |
| 729 | delete heap_message; |
| 730 | } |
| 731 | |
| 732 | TEST(ArenaTest, ReleaseLastRepeatedField) { |
| 733 | // Release from arena-allocated repeated field and ensure that returned object |
| 734 | // is heap-allocated. |
| 735 | Arena arena; |
| 736 | TestAllTypes* arena_message = Arena::CreateMessage<TestAllTypes>(&arena); |
| 737 | for (int i = 0; i < 10; i++) { |
| 738 | TestAllTypes::NestedMessage* nested = |
| 739 | Arena::CreateMessage<TestAllTypes::NestedMessage>(&arena); |
| 740 | nested->set_bb(42); |
| 741 | arena_message->mutable_repeated_nested_message()->AddAllocated(nested); |
| 742 | } |
| 743 | |
| 744 | for (int i = 0; i < 10; i++) { |
| 745 | const TestAllTypes::NestedMessage *orig_submessage = |
| 746 | &arena_message->repeated_nested_message(10 - 1 - i); // last element |
| 747 | TestAllTypes::NestedMessage *released = |
| 748 | arena_message->mutable_repeated_nested_message()->ReleaseLast(); |
| 749 | EXPECT_NE(released, orig_submessage); |
| 750 | EXPECT_EQ(42, released->bb()); |
| 751 | delete released; |
| 752 | } |
| 753 | |
| 754 | // Test UnsafeArenaReleaseLast(). |
| 755 | for (int i = 0; i < 10; i++) { |
| 756 | TestAllTypes::NestedMessage* nested = |
| 757 | Arena::CreateMessage<TestAllTypes::NestedMessage>(&arena); |
| 758 | nested->set_bb(42); |
| 759 | arena_message->mutable_repeated_nested_message()->AddAllocated(nested); |
| 760 | } |
| 761 | |
| 762 | for (int i = 0; i < 10; i++) { |
| 763 | const TestAllTypes::NestedMessage *orig_submessage = |
| 764 | &arena_message->repeated_nested_message(10 - 1 - i); // last element |
| 765 | TestAllTypes::NestedMessage *released = |
| 766 | arena_message->mutable_repeated_nested_message()-> |
| 767 | UnsafeArenaReleaseLast(); |
| 768 | EXPECT_EQ(released, orig_submessage); |
| 769 | EXPECT_EQ(42, released->bb()); |
| 770 | // no delete -- |released| is on the arena. |
| 771 | } |
| 772 | |
| 773 | // Test string case as well. ReleaseLast() in this case must copy the string, |
| 774 | // even though it was originally heap-allocated and its pointer was simply |
| 775 | // appended to the repeated field's internal vector, because the string was |
| 776 | // placed on the arena's destructor list and cannot be removed from that list |
| 777 | // (so the arena permanently owns the original instance). |
| 778 | arena_message->Clear(); |
| 779 | for (int i = 0; i < 10; i++) { |
| 780 | string* s = new string("Test"); |
| 781 | arena_message->mutable_repeated_string()->AddAllocated(s); |
| 782 | } |
| 783 | for (int i = 0; i < 10; i++) { |
| 784 | const string* orig_element = &arena_message->repeated_string(10 - 1 - i); |
| 785 | string* released = arena_message->mutable_repeated_string()->ReleaseLast(); |
| 786 | EXPECT_NE(released, orig_element); |
| 787 | EXPECT_EQ("Test", *released); |
| 788 | delete released; |
| 789 | } |
| 790 | } |
| 791 | |
| 792 | TEST(ArenaTest, UnsafeArenaReleaseAdd) { |
| 793 | // Use unsafe_arena_release() and unsafe_arena_set_allocated() to transfer an |
| 794 | // arena-allocated string from one message to another. |
| 795 | Arena arena; |
| 796 | TestAllTypes* message1 = Arena::CreateMessage<TestAllTypes>(&arena); |
| 797 | TestAllTypes* message2 = Arena::CreateMessage<TestAllTypes>(&arena); |
| 798 | string* arena_string = Arena::Create<string>(&arena); |
| 799 | *arena_string = "Test content"; |
| 800 | |
| 801 | message1->unsafe_arena_set_allocated_optional_string(arena_string); |
| 802 | EXPECT_EQ(arena_string, message1->mutable_optional_string()); |
| 803 | message2->unsafe_arena_set_allocated_optional_string( |
| 804 | message1->unsafe_arena_release_optional_string()); |
| 805 | EXPECT_EQ(arena_string, message2->mutable_optional_string()); |
| 806 | } |
| 807 | |
| 808 | TEST(ArenaTest, UnsafeArenaAddAllocated) { |
| 809 | Arena arena; |
| 810 | TestAllTypes* message = Arena::CreateMessage<TestAllTypes>(&arena); |
| 811 | for (int i = 0; i < 10; i++) { |
| 812 | string* arena_string = Arena::Create<string>(&arena); |
| 813 | message->mutable_repeated_string()->UnsafeArenaAddAllocated(arena_string); |
| 814 | EXPECT_EQ(arena_string, message->mutable_repeated_string(i)); |
| 815 | } |
| 816 | } |
| 817 | |
| 818 | TEST(ArenaTest, UnsafeArenaRelease) { |
| 819 | Arena arena; |
| 820 | TestAllTypes* message = Arena::CreateMessage<TestAllTypes>(&arena); |
| 821 | |
| 822 | string* s = new string("test string"); |
| 823 | message->unsafe_arena_set_allocated_optional_string(s); |
| 824 | EXPECT_TRUE(message->has_optional_string()); |
| 825 | EXPECT_EQ("test string", message->optional_string()); |
| 826 | s = message->unsafe_arena_release_optional_string(); |
| 827 | EXPECT_FALSE(message->has_optional_string()); |
| 828 | delete s; |
| 829 | |
| 830 | s = new string("test string"); |
| 831 | message->unsafe_arena_set_allocated_oneof_string(s); |
| 832 | EXPECT_TRUE(message->has_oneof_string()); |
| 833 | EXPECT_EQ("test string", message->oneof_string()); |
| 834 | s = message->unsafe_arena_release_oneof_string(); |
| 835 | EXPECT_FALSE(message->has_oneof_string()); |
| 836 | delete s; |
| 837 | } |
| 838 | |
| 839 | TEST(ArenaTest, ArenaOneofReflection) { |
| 840 | Arena arena; |
| 841 | TestAllTypes* message = Arena::CreateMessage<TestAllTypes>(&arena); |
| 842 | const Descriptor* desc = message->GetDescriptor(); |
| 843 | const Reflection* refl = message->GetReflection(); |
| 844 | |
| 845 | const FieldDescriptor* string_field = desc->FindFieldByName( |
| 846 | "oneof_string"); |
| 847 | const FieldDescriptor* msg_field = desc->FindFieldByName( |
| 848 | "oneof_nested_message"); |
| 849 | const OneofDescriptor* oneof = desc->FindOneofByName( |
| 850 | "oneof_field"); |
| 851 | |
| 852 | refl->SetString(message, string_field, "Test value"); |
| 853 | EXPECT_TRUE(refl->HasOneof(*message, oneof)); |
| 854 | refl->ClearOneof(message, oneof); |
| 855 | EXPECT_FALSE(refl->HasOneof(*message, oneof)); |
| 856 | |
| 857 | Message* submsg = refl->MutableMessage(message, msg_field); |
| 858 | EXPECT_TRUE(refl->HasOneof(*message, oneof)); |
| 859 | refl->ClearOneof(message, oneof); |
| 860 | EXPECT_FALSE(refl->HasOneof(*message, oneof)); |
| 861 | refl->MutableMessage(message, msg_field); |
| 862 | EXPECT_TRUE(refl->HasOneof(*message, oneof)); |
| 863 | submsg = refl->ReleaseMessage(message, msg_field); |
| 864 | EXPECT_FALSE(refl->HasOneof(*message, oneof)); |
| 865 | EXPECT_TRUE(submsg->GetArena() == NULL); |
| 866 | delete submsg; |
| 867 | } |
| 868 | |
| 869 | namespace { |
| 870 | void TestSwapRepeatedField(Arena* arena1, Arena* arena2) { |
| 871 | // Test "safe" (copying) semantics for direct Swap() on RepeatedPtrField |
| 872 | // between arenas. |
| 873 | RepeatedPtrField<TestAllTypes> field1(arena1); |
| 874 | RepeatedPtrField<TestAllTypes> field2(arena2); |
| 875 | for (int i = 0; i < 10; i++) { |
| 876 | TestAllTypes* t = Arena::CreateMessage<TestAllTypes>(arena1); |
| 877 | t->set_optional_string("field1"); |
| 878 | t->set_optional_int32(i); |
| 879 | if (arena1 != NULL) { |
| 880 | field1.UnsafeArenaAddAllocated(t); |
| 881 | } else { |
| 882 | field1.AddAllocated(t); |
| 883 | } |
| 884 | } |
| 885 | for (int i = 0; i < 5; i++) { |
| 886 | TestAllTypes* t = Arena::CreateMessage<TestAllTypes>(arena2); |
| 887 | t->set_optional_string("field2"); |
| 888 | t->set_optional_int32(i); |
| 889 | if (arena2 != NULL) { |
| 890 | field2.UnsafeArenaAddAllocated(t); |
| 891 | } else { |
| 892 | field2.AddAllocated(t); |
| 893 | } |
| 894 | } |
| 895 | field1.Swap(&field2); |
| 896 | EXPECT_EQ(5, field1.size()); |
| 897 | EXPECT_EQ(10, field2.size()); |
| 898 | EXPECT_TRUE(string("field1") == field2.Get(0).optional_string()); |
| 899 | EXPECT_TRUE(string("field2") == field1.Get(0).optional_string()); |
| 900 | // Ensure that fields retained their original order: |
| 901 | for (int i = 0; i < field1.size(); i++) { |
| 902 | EXPECT_EQ(i, field1.Get(i).optional_int32()); |
| 903 | } |
| 904 | for (int i = 0; i < field2.size(); i++) { |
| 905 | EXPECT_EQ(i, field2.Get(i).optional_int32()); |
| 906 | } |
| 907 | } |
| 908 | } // namespace |
| 909 | |
| 910 | TEST(ArenaTest, SwapRepeatedField) { |
| 911 | Arena arena; |
| 912 | TestSwapRepeatedField(&arena, &arena); |
| 913 | } |
| 914 | |
| 915 | TEST(ArenaTest, SwapRepeatedFieldWithDifferentArenas) { |
| 916 | Arena arena1; |
| 917 | Arena arena2; |
| 918 | TestSwapRepeatedField(&arena1, &arena2); |
| 919 | } |
| 920 | |
| 921 | TEST(ArenaTest, SwapRepeatedFieldWithNoArenaOnRightHandSide) { |
| 922 | Arena arena; |
| 923 | TestSwapRepeatedField(&arena, NULL); |
| 924 | } |
| 925 | |
| 926 | TEST(ArenaTest, SwapRepeatedFieldWithNoArenaOnLeftHandSide) { |
| 927 | Arena arena; |
| 928 | TestSwapRepeatedField(NULL, &arena); |
| 929 | } |
| 930 | |
| 931 | TEST(ArenaTest, ExtensionsOnArena) { |
| 932 | Arena arena; |
| 933 | // Ensure no leaks. |
| 934 | TestAllExtensions* message_ext = |
| 935 | Arena::CreateMessage<TestAllExtensions>(&arena); |
| 936 | message_ext->SetExtension( |
| 937 | protobuf_unittest::optional_int32_extension, 42); |
| 938 | message_ext->SetExtension( |
| 939 | protobuf_unittest::optional_string_extension, string("test")); |
| 940 | message_ext->MutableExtension( |
| 941 | protobuf_unittest::optional_nested_message_extension)->set_bb(42); |
| 942 | } |
| 943 | |
| 944 | TEST(ArenaTest, RepeatedFieldOnArena) { |
| 945 | // Preallocate an initial arena block to avoid mallocs during hooked region. |
| 946 | std::vector<char> arena_block(1024 * 1024); |
| 947 | ArenaOptions options; |
| 948 | options.initial_block = &arena_block[0]; |
| 949 | options.initial_block_size = arena_block.size(); |
| 950 | Arena arena(options); |
| 951 | |
| 952 | { |
| 953 | internal::NoHeapChecker no_heap; |
| 954 | |
| 955 | // Fill some repeated fields on the arena to test for leaks. Also verify no |
| 956 | // memory allocations. |
| 957 | RepeatedField<int32> repeated_int32(&arena); |
| 958 | RepeatedPtrField<TestAllTypes> repeated_message(&arena); |
| 959 | for (int i = 0; i < 100; i++) { |
| 960 | repeated_int32.Add(42); |
| 961 | repeated_message.Add()->set_optional_int32(42); |
| 962 | EXPECT_EQ(&arena, repeated_message.Get(0).GetArena()); |
| 963 | const TestAllTypes* msg_in_repeated_field = &repeated_message.Get(0); |
| 964 | TestAllTypes* msg = repeated_message.UnsafeArenaReleaseLast(); |
| 965 | EXPECT_EQ(msg_in_repeated_field, msg); |
| 966 | } |
| 967 | |
| 968 | // UnsafeArenaExtractSubrange (i) should not leak and (ii) should return |
| 969 | // on-arena pointers. |
| 970 | for (int i = 0; i < 10; i++) { |
| 971 | repeated_message.Add()->set_optional_int32(42); |
| 972 | } |
| 973 | TestAllTypes* extracted_messages[5]; |
| 974 | repeated_message.UnsafeArenaExtractSubrange(0, 5, extracted_messages); |
| 975 | EXPECT_EQ(&arena, repeated_message.Get(0).GetArena()); |
| 976 | EXPECT_EQ(5, repeated_message.size()); |
| 977 | } |
| 978 | |
| 979 | // Now, outside the scope of the NoHeapChecker, test ExtractSubrange's copying |
| 980 | // semantics. |
| 981 | { |
| 982 | RepeatedPtrField<TestAllTypes> repeated_message(&arena); |
| 983 | for (int i = 0; i < 100; i++) { |
| 984 | repeated_message.Add()->set_optional_int32(42); |
| 985 | } |
| 986 | |
| 987 | TestAllTypes* extracted_messages[5]; |
| 988 | // ExtractSubrange should copy to the heap. |
| 989 | repeated_message.ExtractSubrange(0, 5, extracted_messages); |
| 990 | EXPECT_EQ(NULL, extracted_messages[0]->GetArena()); |
| 991 | // We need to free the heap-allocated messages to prevent a leak. |
| 992 | for (int i = 0; i < 5; i++) { |
| 993 | delete extracted_messages[i]; |
| 994 | extracted_messages[i] = NULL; |
| 995 | } |
| 996 | } |
| 997 | |
| 998 | // Now check that we can create RepeatedFields/RepeatedPtrFields themselves on |
| 999 | // the arena. They have the necessary type traits so that they can behave like |
| 1000 | // messages in this way. This is useful for higher-level generic templated |
| 1001 | // code that may allocate messages or repeated fields of messages on an arena. |
| 1002 | { |
| 1003 | RepeatedPtrField<TestAllTypes>* repeated_ptr_on_arena = |
| 1004 | Arena::CreateMessage< RepeatedPtrField<TestAllTypes> >(&arena); |
| 1005 | for (int i = 0; i < 10; i++) { |
| 1006 | // Add some elements and let the leak-checker ensure that everything is |
| 1007 | // freed. |
| 1008 | repeated_ptr_on_arena->Add(); |
| 1009 | } |
| 1010 | |
| 1011 | RepeatedField<int>* repeated_int_on_arena = |
| 1012 | Arena::CreateMessage< RepeatedField<int> >(&arena); |
| 1013 | for (int i = 0; i < 100; i++) { |
| 1014 | repeated_int_on_arena->Add(i); |
| 1015 | } |
| 1016 | |
| 1017 | } |
| 1018 | |
| 1019 | arena.Reset(); |
| 1020 | } |
| 1021 | |
| 1022 | |
| 1023 | #ifndef GOOGLE_PROTOBUF_NO_RTTI |
| 1024 | TEST(ArenaTest, MutableMessageReflection) { |
| 1025 | Arena arena; |
| 1026 | TestAllTypes* message = Arena::CreateMessage<TestAllTypes>(&arena); |
| 1027 | const Reflection* r = message->GetReflection(); |
| 1028 | const Descriptor* d = message->GetDescriptor(); |
| 1029 | const FieldDescriptor* field = d->FindFieldByName("optional_nested_message"); |
| 1030 | TestAllTypes::NestedMessage* submessage = |
| 1031 | static_cast<TestAllTypes::NestedMessage*>( |
| 1032 | r->MutableMessage(message, field)); |
| 1033 | TestAllTypes::NestedMessage* submessage_expected = |
| 1034 | message->mutable_optional_nested_message(); |
| 1035 | |
| 1036 | EXPECT_EQ(submessage_expected, submessage); |
| 1037 | EXPECT_EQ(&arena, submessage->GetArena()); |
| 1038 | |
| 1039 | const FieldDescriptor* oneof_field = d->FindFieldByName("oneof_nested_message"); |
| 1040 | submessage = static_cast<TestAllTypes::NestedMessage*>( |
| 1041 | r->MutableMessage(message, oneof_field)); |
| 1042 | submessage_expected = message->mutable_oneof_nested_message(); |
| 1043 | |
| 1044 | EXPECT_EQ(submessage_expected, submessage); |
| 1045 | EXPECT_EQ(&arena, submessage->GetArena()); |
| 1046 | } |
| 1047 | #endif // !GOOGLE_PROTOBUF_NO_RTTI |
| 1048 | |
| 1049 | |
| 1050 | namespace { |
| 1051 | |
| 1052 | void FillArenaAwareFields(TestAllTypes* message) { |
| 1053 | string test_string = "hello world"; |
| 1054 | message->set_optional_int32(42); |
| 1055 | message->set_optional_string(test_string); |
| 1056 | message->set_optional_bytes(test_string); |
| 1057 | message->mutable_optional_nested_message()->set_bb(42); |
| 1058 | |
| 1059 | message->set_oneof_uint32(42); |
| 1060 | message->mutable_oneof_nested_message()->set_bb(42); |
| 1061 | message->set_oneof_string(test_string); |
| 1062 | message->set_oneof_bytes(test_string); |
| 1063 | |
| 1064 | message->add_repeated_int32(42); |
| 1065 | // No repeated string: not yet arena-aware. |
| 1066 | message->add_repeated_nested_message()->set_bb(42); |
| 1067 | message->mutable_optional_lazy_message()->set_bb(42); |
| 1068 | } |
| 1069 | |
| 1070 | } |
| 1071 | |
| 1072 | // Test: no allocations occur on heap while touching all supported field types. |
| 1073 | TEST(ArenaTest, NoHeapAllocationsTest) { |
| 1074 | // Allocate a large initial block to avoid mallocs during hooked test. |
| 1075 | std::vector<char> arena_block(128 * 1024); |
| 1076 | ArenaOptions options; |
| 1077 | options.initial_block = &arena_block[0]; |
| 1078 | options.initial_block_size = arena_block.size(); |
| 1079 | Arena arena(options); |
| 1080 | |
| 1081 | { |
| 1082 | |
| 1083 | TestAllTypes* message = Arena::CreateMessage<TestAllTypes>(&arena); |
| 1084 | FillArenaAwareFields(message); |
| 1085 | } |
| 1086 | |
| 1087 | arena.Reset(); |
| 1088 | } |
| 1089 | |
| 1090 | #ifndef GOOGLE_PROTOBUF_NO_RTTI |
| 1091 | // Test construction on an arena via generic MessageLite interface. We should be |
| 1092 | // able to successfully deserialize on the arena without incurring heap |
| 1093 | // allocations, i.e., everything should still be arena-allocation-aware. |
| 1094 | TEST(ArenaTest, MessageLiteOnArena) { |
| 1095 | std::vector<char> arena_block(128 * 1024); |
| 1096 | ArenaOptions options; |
| 1097 | options.initial_block = &arena_block[0]; |
| 1098 | options.initial_block_size = arena_block.size(); |
| 1099 | Arena arena(options); |
| 1100 | const google::protobuf::MessageLite* prototype = &TestAllTypes::default_instance(); |
| 1101 | |
| 1102 | TestAllTypes initial_message; |
| 1103 | FillArenaAwareFields(&initial_message); |
| 1104 | string serialized; |
| 1105 | initial_message.SerializeToString(&serialized); |
| 1106 | |
| 1107 | { |
| 1108 | |
| 1109 | google::protobuf::MessageLite* generic_message = prototype->New(&arena); |
| 1110 | EXPECT_TRUE(generic_message != NULL); |
| 1111 | EXPECT_EQ(&arena, generic_message->GetArena()); |
| 1112 | EXPECT_TRUE(generic_message->ParseFromString(serialized)); |
| 1113 | TestAllTypes* deserialized = static_cast<TestAllTypes*>(generic_message); |
| 1114 | EXPECT_EQ(42, deserialized->optional_int32()); |
| 1115 | } |
| 1116 | |
| 1117 | arena.Reset(); |
| 1118 | } |
| 1119 | #endif // !GOOGLE_PROTOBUF_NO_RTTI |
| 1120 | |
| 1121 | |
| 1122 | // RepeatedField should support non-POD types, and invoke constructors and |
| 1123 | // destructors appropriately, because it's used this way by lots of other code |
| 1124 | // (even if this was not its original intent). |
| 1125 | TEST(ArenaTest, RepeatedFieldWithNonPODType) { |
| 1126 | { |
| 1127 | RepeatedField<string> field_on_heap; |
| 1128 | for (int i = 0; i < 100; i++) { |
| 1129 | *field_on_heap.Add() = "test string long enough to exceed inline buffer"; |
| 1130 | } |
| 1131 | } |
| 1132 | { |
| 1133 | Arena arena; |
| 1134 | RepeatedField<string> field_on_arena(&arena); |
| 1135 | for (int i = 0; i < 100; i++) { |
| 1136 | *field_on_arena.Add() = "test string long enough to exceed inline buffer"; |
| 1137 | } |
| 1138 | } |
| 1139 | } |
| 1140 | |
| 1141 | // Align n to next multiple of 8 |
| 1142 | namespace { |
| 1143 | uint64 Align8(uint64 n) { return (n + 7) & -8; } |
| 1144 | } // namespace |
| 1145 | |
| 1146 | TEST(ArenaTest, SpaceAllocated_and_Used) { |
| 1147 | ArenaOptions options; |
| 1148 | options.start_block_size = 256; |
| 1149 | options.max_block_size = 8192; |
| 1150 | Arena arena_1(options); |
| 1151 | EXPECT_EQ(0, arena_1.SpaceAllocated()); |
| 1152 | EXPECT_EQ(0, arena_1.SpaceUsed()); |
| 1153 | EXPECT_EQ(0, arena_1.Reset()); |
| 1154 | ::google::protobuf::Arena::CreateArray<char>(&arena_1, 320); |
| 1155 | // Arena will allocate slightly more than 320 for the block headers. |
| 1156 | EXPECT_LE(320, arena_1.SpaceAllocated()); |
| 1157 | EXPECT_EQ(Align8(320), arena_1.SpaceUsed()); |
| 1158 | EXPECT_LE(320, arena_1.Reset()); |
| 1159 | |
| 1160 | // Test with initial block. |
| 1161 | std::vector<char> arena_block(1024); |
| 1162 | options.initial_block = &arena_block[0]; |
| 1163 | options.initial_block_size = arena_block.size(); |
| 1164 | Arena arena_2(options); |
| 1165 | EXPECT_EQ(1024, arena_2.SpaceAllocated()); |
| 1166 | EXPECT_EQ(0, arena_2.SpaceUsed()); |
| 1167 | EXPECT_EQ(1024, arena_2.Reset()); |
| 1168 | ::google::protobuf::Arena::CreateArray<char>(&arena_2, 55); |
| 1169 | EXPECT_EQ(1024, arena_2.SpaceAllocated()); |
| 1170 | EXPECT_EQ(Align8(55), arena_2.SpaceUsed()); |
| 1171 | EXPECT_EQ(1024, arena_2.Reset()); |
| 1172 | |
| 1173 | // Reset options to test doubling policy explicitly. |
| 1174 | options.initial_block = NULL; |
| 1175 | options.initial_block_size = 0; |
| 1176 | Arena arena_3(options); |
| 1177 | EXPECT_EQ(0, arena_3.SpaceUsed()); |
| 1178 | ::google::protobuf::Arena::CreateArray<char>(&arena_3, 190); |
| 1179 | EXPECT_EQ(256, arena_3.SpaceAllocated()); |
| 1180 | EXPECT_EQ(Align8(190), arena_3.SpaceUsed()); |
| 1181 | ::google::protobuf::Arena::CreateArray<char>(&arena_3, 70); |
| 1182 | EXPECT_EQ(256 + 512, arena_3.SpaceAllocated()); |
| 1183 | EXPECT_EQ(Align8(190) + Align8(70), arena_3.SpaceUsed()); |
| 1184 | EXPECT_EQ(256 + 512, arena_3.Reset()); |
| 1185 | } |
| 1186 | |
| 1187 | TEST(ArenaTest, Alignment) { |
| 1188 | ::google::protobuf::Arena arena; |
| 1189 | for (int i = 0; i < 200; i++) { |
| 1190 | void* p = ::google::protobuf::Arena::CreateArray<char>(&arena, i); |
| 1191 | GOOGLE_CHECK_EQ(reinterpret_cast<uintptr_t>(p) % 8, 0) << i << ": " << p; |
| 1192 | } |
| 1193 | } |
| 1194 | |
| 1195 | TEST(ArenaTest, GetArenaShouldReturnTheArenaForArenaAllocatedMessages) { |
| 1196 | ::google::protobuf::Arena arena; |
| 1197 | ArenaMessage* message = Arena::CreateMessage<ArenaMessage>(&arena); |
| 1198 | const ArenaMessage* const_pointer_to_message = message; |
| 1199 | EXPECT_EQ(&arena, Arena::GetArena(message)); |
| 1200 | EXPECT_EQ(&arena, Arena::GetArena(const_pointer_to_message)); |
| 1201 | } |
| 1202 | |
| 1203 | TEST(ArenaTest, GetArenaShouldReturnNullForNonArenaAllocatedMessages) { |
| 1204 | ArenaMessage message; |
| 1205 | const ArenaMessage* const_pointer_to_message = &message; |
| 1206 | EXPECT_EQ(NULL, Arena::GetArena(&message)); |
| 1207 | EXPECT_EQ(NULL, Arena::GetArena(const_pointer_to_message)); |
| 1208 | } |
| 1209 | |
| 1210 | TEST(ArenaTest, UnsafeSetAllocatedOnArena) { |
| 1211 | ::google::protobuf::Arena arena; |
| 1212 | TestAllTypes* message = Arena::CreateMessage<TestAllTypes>(&arena); |
| 1213 | EXPECT_FALSE(message->has_optional_string()); |
| 1214 | |
| 1215 | string owned_string = "test with long enough content to heap-allocate"; |
| 1216 | message->unsafe_arena_set_allocated_optional_string(&owned_string); |
| 1217 | EXPECT_TRUE(message->has_optional_string()); |
| 1218 | |
| 1219 | message->unsafe_arena_set_allocated_optional_string(NULL); |
| 1220 | EXPECT_FALSE(message->has_optional_string()); |
| 1221 | } |
| 1222 | |
| 1223 | // A helper utility class to only contain static hook functions, some |
| 1224 | // counters to be used to verify the counters have been called and a cookie |
| 1225 | // value to be verified. |
| 1226 | class ArenaHooksTestUtil { |
| 1227 | public: |
| 1228 | static void* on_init(::google::protobuf::Arena* arena) { |
| 1229 | ++num_init; |
| 1230 | int* cookie = new int(kCookieValue); |
| 1231 | return static_cast<void*>(cookie); |
| 1232 | } |
| 1233 | |
| 1234 | static void on_allocation(const std::type_info* /*unused*/, uint64 alloc_size, |
| 1235 | void* cookie) { |
| 1236 | ++num_allocations; |
| 1237 | int cookie_value = *static_cast<int*>(cookie); |
| 1238 | EXPECT_EQ(kCookieValue, cookie_value); |
| 1239 | } |
| 1240 | |
| 1241 | static void on_reset(::google::protobuf::Arena* arena, void* cookie, |
| 1242 | uint64 space_used) { |
| 1243 | ++num_reset; |
| 1244 | int cookie_value = *static_cast<int*>(cookie); |
| 1245 | EXPECT_EQ(kCookieValue, cookie_value); |
| 1246 | } |
| 1247 | |
| 1248 | static void on_destruction(::google::protobuf::Arena* arena, void* cookie, |
| 1249 | uint64 space_used) { |
| 1250 | ++num_destruct; |
| 1251 | int cookie_value = *static_cast<int*>(cookie); |
| 1252 | EXPECT_EQ(kCookieValue, cookie_value); |
| 1253 | delete static_cast<int*>(cookie); |
| 1254 | } |
| 1255 | |
| 1256 | static const int kCookieValue = 999; |
| 1257 | static uint32 num_init; |
| 1258 | static uint32 num_allocations; |
| 1259 | static uint32 num_reset; |
| 1260 | static uint32 num_destruct; |
| 1261 | }; |
| 1262 | uint32 ArenaHooksTestUtil::num_init = 0; |
| 1263 | uint32 ArenaHooksTestUtil::num_allocations = 0; |
| 1264 | uint32 ArenaHooksTestUtil::num_reset = 0; |
| 1265 | uint32 ArenaHooksTestUtil::num_destruct = 0; |
| 1266 | const int ArenaHooksTestUtil::kCookieValue; |
| 1267 | |
| 1268 | // Test the hooks are correctly called and that the cookie is passed. |
| 1269 | TEST(ArenaTest, ArenaHooksSanity) { |
| 1270 | ::google::protobuf::ArenaOptions options; |
| 1271 | options.on_arena_init = ArenaHooksTestUtil::on_init; |
| 1272 | options.on_arena_allocation = ArenaHooksTestUtil::on_allocation; |
| 1273 | options.on_arena_reset = ArenaHooksTestUtil::on_reset; |
| 1274 | options.on_arena_destruction = ArenaHooksTestUtil::on_destruction; |
| 1275 | |
| 1276 | // Scope for defining the arena |
| 1277 | { |
| 1278 | ::google::protobuf::Arena arena(options); |
| 1279 | EXPECT_EQ(1, ArenaHooksTestUtil::num_init); |
| 1280 | EXPECT_EQ(0, ArenaHooksTestUtil::num_allocations); |
| 1281 | ::google::protobuf::Arena::Create<uint64>(&arena); |
| 1282 | if (google::protobuf::internal::has_trivial_destructor<uint64>::value) { |
| 1283 | EXPECT_EQ(1, ArenaHooksTestUtil::num_allocations); |
| 1284 | } else { |
| 1285 | EXPECT_EQ(2, ArenaHooksTestUtil::num_allocations); |
| 1286 | } |
| 1287 | arena.Reset(); |
| 1288 | arena.Reset(); |
| 1289 | EXPECT_EQ(2, ArenaHooksTestUtil::num_reset); |
| 1290 | } |
| 1291 | EXPECT_EQ(3, ArenaHooksTestUtil::num_reset); |
| 1292 | EXPECT_EQ(1, ArenaHooksTestUtil::num_destruct); |
| 1293 | } |
| 1294 | |
| 1295 | } // namespace protobuf |
| 1296 | } // namespace google |