Switch everything to platforms
This patch switches the codebase over from using the "cpu"
mechanism to using bazel platforms. See
https://docs.bazel.build/versions/master/platforms.html for some more
information.
Most of the substantial changes are in //tools. Instead of using
`cc_toolchain_suite` rules, we now use regular `toolchain` rules that
are registered in the WORKSPACE. That also means that bazel now uses
the target platform to select the compiler.
All --cpu=* arguments should now be --config=* arguments. For example,
`--cpu=roborio` should now be `--config=roborio`. The CI script and
all documentation has been updated to reflect that.
The remainder of the changes revolve around tagging all targets with
`target_compatible_with`. The old mechanism allowed us to specify
repo-wide defaults. The new mechanism does not. That means every
target that didn't have any compatibility specified, now requires
compatibility with `@platforms//os:linux`.
I used buildozer for the vast majority of `target_compatible_with`
changes. buildozer automatically buildifies any BUILD files it
touches. That means this patch also contains a few non-functional
changes that I was too lazy to remove.
Change-Id: I66d6e6ad9161520ee397597cdb492585820a3acd
diff --git a/aos/vision/blob/BUILD b/aos/vision/blob/BUILD
index e025ed3..2efd99e 100644
--- a/aos/vision/blob/BUILD
+++ b/aos/vision/blob/BUILD
@@ -1,4 +1,5 @@
-load("//tools/build_rules:gtk_dependent.bzl", "gtk_dependent_cc_binary", "gtk_dependent_cc_library")
+load("//tools:platforms.bzl", "platforms")
+load("//tools/build_rules:gtk_dependent.bzl", "gtk_dependent_cc_library")
package(default_visibility = ["//visibility:public"])
@@ -6,6 +7,7 @@
name = "range_image",
srcs = ["range_image.cc"],
hdrs = ["range_image.h"],
+ target_compatible_with = ["@platforms//os:linux"],
deps = [
"//aos/vision/debug:overlay",
"//aos/vision/image:image_types",
@@ -18,12 +20,14 @@
cc_library(
name = "region_alloc",
hdrs = ["region_alloc.h"],
+ target_compatible_with = ["@platforms//os:linux"],
)
cc_library(
name = "contour",
srcs = ["contour.cc"],
hdrs = ["contour.h"],
+ target_compatible_with = ["@platforms//os:linux"],
deps = [
":range_image",
":region_alloc",
@@ -40,6 +44,7 @@
hdrs = [
"threshold.h",
],
+ target_compatible_with = ["@platforms//os:linux"],
deps = [
":range_image",
"//aos/logging",
@@ -52,6 +57,7 @@
srcs = [
"threshold_test.cc",
],
+ target_compatible_with = ["@platforms//os:linux"],
deps = [
":range_image",
":threshold",
@@ -64,10 +70,10 @@
name = "hierarchical_contour_merge",
srcs = ["hierarchical_contour_merge.cc"],
hdrs = ["hierarchical_contour_merge.h"],
- restricted_to = [
- "//tools:k8",
- "//tools:armhf-debian",
- ],
+ target_compatible_with = platforms.any_of([
+ "@platforms//cpu:x86_64",
+ "//tools/platforms/hardware:raspberry_pi",
+ ]),
deps = [
":contour",
":disjoint_set",
@@ -79,12 +85,14 @@
cc_library(
name = "disjoint_set",
hdrs = ["disjoint_set.h"],
+ target_compatible_with = ["@platforms//os:linux"],
)
cc_library(
name = "find_blob",
srcs = ["find_blob.cc"],
hdrs = ["find_blob.h"],
+ target_compatible_with = ["@platforms//os:linux"],
deps = [
":disjoint_set",
":range_image",
@@ -98,6 +106,7 @@
name = "codec",
srcs = ["codec.cc"],
hdrs = ["codec.h"],
+ target_compatible_with = ["@platforms//os:linux"],
deps = [
":range_image",
"//aos/vision/debug:overlay",
@@ -109,6 +118,7 @@
cc_test(
name = "codec_test",
srcs = ["codec_test.cc"],
+ target_compatible_with = ["@platforms//os:linux"],
deps = [
":codec",
"//aos/testing:googletest",
@@ -119,6 +129,7 @@
name = "move_scale",
srcs = ["move_scale.cc"],
hdrs = ["move_scale.h"],
+ target_compatible_with = ["@platforms//os:linux"],
deps = [
":range_image",
"//aos/vision/image:image_types",
@@ -129,6 +140,7 @@
name = "test_utils",
srcs = ["test_utils.cc"],
hdrs = ["test_utils.h"],
+ target_compatible_with = ["@platforms//os:linux"],
deps = [
":range_image",
],
@@ -138,6 +150,7 @@
name = "transpose",
srcs = ["transpose.cc"],
hdrs = ["transpose.h"],
+ target_compatible_with = ["@platforms//os:linux"],
deps = [
":range_image",
],
@@ -146,6 +159,7 @@
cc_test(
name = "transpose_test",
srcs = ["transpose_test.cc"],
+ target_compatible_with = ["@platforms//os:linux"],
deps = [
":test_utils",
":transpose",
@@ -156,6 +170,7 @@
gtk_dependent_cc_library(
name = "stream_view",
hdrs = ["stream_view.h"],
+ target_compatible_with = ["@platforms//os:linux"],
deps = [
":range_image",
"//aos/vision/debug:debug_window",
diff --git a/aos/vision/debug/BUILD b/aos/vision/debug/BUILD
index 05d93ad..08d549e 100644
--- a/aos/vision/debug/BUILD
+++ b/aos/vision/debug/BUILD
@@ -1,10 +1,11 @@
-load("//tools/build_rules:gtk_dependent.bzl", "gtk_dependent_cc_binary", "gtk_dependent_cc_library")
+load("//tools/build_rules:gtk_dependent.bzl", "gtk_dependent_cc_library")
package(default_visibility = ["//visibility:public"])
cc_library(
name = "overlay",
hdrs = ["overlay.h"],
+ target_compatible_with = ["@platforms//os:linux"],
deps = [
"//aos/vision/image:image_types",
"//aos/vision/math:segment",
@@ -16,6 +17,7 @@
name = "debug_window",
srcs = ["debug_window.cc"],
hdrs = ["debug_window.h"],
+ target_compatible_with = ["@platforms//os:linux"],
deps = [
":overlay",
"//aos/vision/image:image_types",
@@ -34,6 +36,7 @@
"tcp-source.cc",
],
hdrs = ["debug_framework.h"],
+ target_compatible_with = ["@platforms//os:linux"],
deps = [
"//aos/logging",
"//aos/logging:implementations",
diff --git a/aos/vision/download/BUILD b/aos/vision/download/BUILD
index f22c18b..1352713 100644
--- a/aos/vision/download/BUILD
+++ b/aos/vision/download/BUILD
@@ -3,5 +3,6 @@
srcs = [
"downloader.py",
],
+ target_compatible_with = ["@platforms//os:linux"],
visibility = ["//visibility:public"],
)
diff --git a/aos/vision/events/BUILD b/aos/vision/events/BUILD
index a991968..c722acc 100644
--- a/aos/vision/events/BUILD
+++ b/aos/vision/events/BUILD
@@ -1,4 +1,4 @@
-load("//tools/build_rules:gtk_dependent.bzl", "gtk_dependent_cc_binary", "gtk_dependent_cc_library")
+load("//tools/build_rules:gtk_dependent.bzl", "gtk_dependent_cc_library")
package(default_visibility = ["//visibility:public"])
@@ -6,6 +6,7 @@
name = "epoll_events",
srcs = ["epoll_events.cc"],
hdrs = ["epoll_events.h"],
+ target_compatible_with = ["@platforms//os:linux"],
deps = [
"//aos/logging",
"//aos/scoped:scoped_fd",
@@ -16,6 +17,7 @@
cc_library(
name = "socket_types",
hdrs = ["socket_types.h"],
+ target_compatible_with = ["@platforms//os:linux"],
deps = [
"//aos/vision/events:tcp_server",
"//aos/vision/image:image_types",
@@ -26,12 +28,14 @@
cc_library(
name = "intrusive_free_list",
hdrs = ["intrusive_free_list.h"],
+ target_compatible_with = ["@platforms//os:linux"],
)
cc_library(
name = "tcp_server",
srcs = ["tcp_server.cc"],
hdrs = ["tcp_server.h"],
+ target_compatible_with = ["@platforms//os:linux"],
deps = [
":epoll_events",
":intrusive_free_list",
@@ -42,6 +46,7 @@
name = "tcp_client",
srcs = ["tcp_client.cc"],
hdrs = ["tcp_client.h"],
+ target_compatible_with = ["@platforms//os:linux"],
deps = [":epoll_events"],
)
@@ -49,6 +54,7 @@
name = "udp",
srcs = ["udp.cc"],
hdrs = ["udp.h"],
+ target_compatible_with = ["@platforms//os:linux"],
deps = [
"//aos:macros",
"//aos/scoped:scoped_fd",
@@ -59,6 +65,7 @@
cc_test(
name = "udp_test",
srcs = ["udp_test.cc"],
+ target_compatible_with = ["@platforms//os:linux"],
deps = [
":udp",
"//aos/testing:googletest",
@@ -68,6 +75,7 @@
gtk_dependent_cc_library(
name = "gtk_event",
srcs = ["gtk_event.cc"],
+ target_compatible_with = ["@platforms//os:linux"],
deps = [
":epoll_events",
"//aos/logging",
diff --git a/aos/vision/image/BUILD b/aos/vision/image/BUILD
index 9b6d30a..054b262 100644
--- a/aos/vision/image/BUILD
+++ b/aos/vision/image/BUILD
@@ -5,6 +5,7 @@
cc_library(
name = "image_types",
hdrs = ["image_types.h"],
+ target_compatible_with = ["@platforms//os:linux"],
deps = [
"@com_google_absl//absl/strings",
],
@@ -13,6 +14,7 @@
cc_proto_library(
name = "camera_params",
srcs = ["camera_params.proto"],
+ target_compatible_with = ["@platforms//os:linux"],
)
cc_library(
@@ -22,6 +24,7 @@
"V4L2.h",
"reader.h",
],
+ target_compatible_with = ["@platforms//os:linux"],
deps = [
":camera_params",
":image_types",
@@ -34,6 +37,7 @@
name = "jpeg_routines",
srcs = ["jpeg_routines.cc"],
hdrs = ["jpeg_routines.h"],
+ target_compatible_with = ["@platforms//os:linux"],
deps = [
":image_types",
"//aos/logging",
@@ -45,6 +49,7 @@
name = "image_dataset",
srcs = ["image_dataset.cc"],
hdrs = ["image_dataset.h"],
+ target_compatible_with = ["@platforms//os:linux"],
deps = [
":image_types",
],
@@ -54,6 +59,7 @@
name = "image_stream",
srcs = ["image_stream.cc"],
hdrs = ["image_stream.h"],
+ target_compatible_with = ["@platforms//os:linux"],
deps = [
"//aos/logging",
"//aos/vision/events:epoll_events",
diff --git a/aos/vision/math/BUILD b/aos/vision/math/BUILD
index 2c71e8f..fd7d876 100644
--- a/aos/vision/math/BUILD
+++ b/aos/vision/math/BUILD
@@ -3,6 +3,7 @@
cc_library(
name = "segment",
hdrs = ["segment.h"],
+ target_compatible_with = ["@platforms//os:linux"],
deps = [":vector"],
)
@@ -11,6 +12,7 @@
hdrs = [
"vector.h",
],
+ target_compatible_with = ["@platforms//os:linux"],
deps = [
"@org_tuxfamily_eigen//:eigen",
],
@@ -22,6 +24,7 @@
srcs = [
"vector_test.cc",
],
+ target_compatible_with = ["@platforms//os:linux"],
deps = [
":vector",
"//aos/testing:googletest",
diff --git a/aos/vision/tools/BUILD b/aos/vision/tools/BUILD
index 2ef3244..4be7fd7 100644
--- a/aos/vision/tools/BUILD
+++ b/aos/vision/tools/BUILD
@@ -3,6 +3,7 @@
gtk_dependent_cc_binary(
name = "jpeg_vision_test",
srcs = ["jpeg_vision_test.cc"],
+ target_compatible_with = ["@platforms//os:linux"],
deps = [
"//aos/logging",
"//aos/logging:implementations",
@@ -22,6 +23,7 @@
cc_binary(
name = "camera_primer",
srcs = ["camera_primer.cc"],
+ target_compatible_with = ["@platforms//os:linux"],
deps = [
"//aos/logging",
"//aos/logging:implementations",