commit dada107facf6a76af9d974fa6b17af76fa85e680
author Philipp Schrader <philipp.schrader@gmail.com> Tue Nov 24 11:34:46 2020 -0800
committer Philipp Schrader <philipp.schrader@gmail.com> Sat Dec 12 15:48:00 2020 -0800
tree 0e5b9c456e38573b94ade3d8b15c18f13b07d15b
parent fbbd93b5a87a6c01c24d750fedac568bc6ac8cbe

Switch everything to platforms

This patch switches the codebase over from using the "cpu"
mechanism to using bazel platforms. See
https://docs.bazel.build/versions/master/platforms.html for some more
information.

Most of the substantial changes are in //tools. Instead of using
`cc_toolchain_suite` rules, we now use regular `toolchain` rules that
are registered in the WORKSPACE. That also means that bazel now uses
the target platform to select the compiler.

All --cpu=* arguments should now be --config=* arguments. For example,
`--cpu=roborio` should now be `--config=roborio`. The CI script and
all documentation has been updated to reflect that.

The remainder of the changes revolve around tagging all targets with
`target_compatible_with`.  The old mechanism allowed us to specify
repo-wide defaults. The new mechanism does not. That means every
target that didn't have any compatibility specified, now requires
compatibility with `@platforms//os:linux`.

I used buildozer for the vast majority of `target_compatible_with`
changes. buildozer automatically buildifies any BUILD files it
touches. That means this patch also contains a few non-functional
changes that I was too lazy to remove.

Change-Id: I66d6e6ad9161520ee397597cdb492585820a3acd

aos/testing/BUILD

diff --git a/aos/testing/BUILD b/aos/testing/BUILD
index 4b2631a..116acc0 100644
--- a/aos/testing/BUILD
+++ b/aos/testing/BUILD
@@ -4,6 +4,7 @@
     srcs = [
         "gtest_main.cc",
     ],
+    target_compatible_with = ["@platforms//os:linux"],
     visibility = ["//visibility:public"],
     deps = [
         "//aos:init",
@@ -22,6 +23,7 @@
     hdrs = [
         "test_logging.h",
     ],
+    target_compatible_with = ["@platforms//os:linux"],
     visibility = ["//visibility:public"],
     deps = [
         ":googletest",
@@ -37,6 +39,7 @@
     srcs = [
         "test_logging_test.cc",
     ],
+    target_compatible_with = ["@platforms//os:linux"],
     deps = [
         ":googletest",
         ":test_logging",
@@ -53,6 +56,7 @@
     hdrs = [
         "prevent_exit.h",
     ],
+    target_compatible_with = ["@platforms//os:linux"],
     visibility = ["//visibility:public"],
     deps = [
         "@com_github_google_glog//:glog",
@@ -68,6 +72,7 @@
     hdrs = [
         "test_shm.h",
     ],
+    target_compatible_with = ["@platforms//os:linux"],
     visibility = ["//visibility:public"],
     deps = [
         ":test_logging",
@@ -85,6 +90,7 @@
     hdrs = [
         "random_seed.h",
     ],
+    target_compatible_with = ["@platforms//os:linux"],
     visibility = ["//visibility:public"],
 )
 
@@ -93,5 +99,6 @@
     testonly = True,
     srcs = ["tmpdir.cc"],
     hdrs = ["tmpdir.h"],
+    target_compatible_with = ["@platforms//os:linux"],
     visibility = ["//visibility:public"],
 )