Rename timer `Setup` function to `Schedule`
This patch was motivated by my desire to fix a typo in the function
name. The noun "setup" is 1 word. The verb "set up" is 2 words. All
other member functions are verbs, so this one should be a verb too.
That means that the function should be called `SetUp`. During the
discussion that resulted from the rename, James Kuszmaul pointed out
that "setting up" a timer can be confusing. It implies that you can
only "set up" a timer once. But the intent is to let users set up
timers as many times as they like. So we decided on renaming the
function to `Schedule`. That conveys the purpose and intent better.
I took this opportunity to fix some other typos involving the verb
"set up".
Signed-off-by: Philipp Schrader <philipp.schrader@gmail.com>
Change-Id: I2f557d1f946960af82711f248820d5e2d385a5d3
diff --git a/y2022/localizer/localizer.cc b/y2022/localizer/localizer.cc
index b774e18..ab91db3 100644
--- a/y2022/localizer/localizer.cc
+++ b/y2022/localizer/localizer.cc
@@ -897,8 +897,8 @@
}
});
event_loop_->OnRun([this, superstructure_timer]() {
- superstructure_timer->Setup(event_loop_->monotonic_now(),
- std::chrono::milliseconds(20));
+ superstructure_timer->Schedule(event_loop_->monotonic_now(),
+ std::chrono::milliseconds(20));
});
for (size_t camera_index = 0; camera_index < kPisToUse.size();
@@ -949,8 +949,8 @@
}
});
event_loop_->OnRun([this, estimate_timer]() {
- estimate_timer->Setup(event_loop_->monotonic_now(),
- std::chrono::milliseconds(100));
+ estimate_timer->Schedule(event_loop_->monotonic_now(),
+ std::chrono::milliseconds(100));
});
}