Brian Silverman | 8fce748 | 2020-01-05 13:18:21 -0800 | [diff] [blame] | 1 | <?xml version="1.0"?> |
| 2 | <ruleset name="WPILibRuleset" |
Austin Schuh | 812d0d1 | 2021-11-04 20:16:48 -0700 | [diff] [blame] | 3 | xmlns="http://pmd.sourceforge.net/ruleset/2.0.0" |
| 4 | xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" |
| 5 | xsi:schemaLocation="http://pmd.sourceforge.net/ruleset/2.0.0 http://pmd.sourceforge.net/ruleset_2_0_0.xsd"> |
Brian Silverman | 8fce748 | 2020-01-05 13:18:21 -0800 | [diff] [blame] | 6 | |
| 7 | <description>PMD Ruleset for WPILib</description> |
| 8 | |
| 9 | <exclude-pattern>.*/*JNI.*</exclude-pattern> |
| 10 | <exclude-pattern>.*/*IntegrationTests.*</exclude-pattern> |
| 11 | |
| 12 | <rule ref="category/java/bestpractices.xml"> |
| 13 | <exclude name="AccessorClassGeneration" /> |
| 14 | <exclude name="AccessorMethodGeneration" /> |
| 15 | <exclude name="AvoidPrintStackTrace" /> |
James Kuszmaul | cf32412 | 2023-01-14 14:07:17 -0800 | [diff] [blame^] | 16 | <exclude name="AvoidReassigningCatchVariables" /> |
Brian Silverman | 8fce748 | 2020-01-05 13:18:21 -0800 | [diff] [blame] | 17 | <exclude name="AvoidReassigningParameters" /> |
Austin Schuh | 812d0d1 | 2021-11-04 20:16:48 -0700 | [diff] [blame] | 18 | <exclude name="AvoidUsingHardCodedIP" /> |
| 19 | <exclude name="ConstantsInInterface" /> |
Brian Silverman | 8fce748 | 2020-01-05 13:18:21 -0800 | [diff] [blame] | 20 | <exclude name="JUnitAssertionsShouldIncludeMessage" /> |
| 21 | <exclude name="JUnitTestContainsTooManyAsserts" /> |
James Kuszmaul | cf32412 | 2023-01-14 14:07:17 -0800 | [diff] [blame^] | 22 | <exclude name="JUnitTestsShouldIncludeAssert" /> |
Brian Silverman | 8fce748 | 2020-01-05 13:18:21 -0800 | [diff] [blame] | 23 | <exclude name="JUnit4TestShouldUseAfterAnnotation" /> |
| 24 | <exclude name="JUnit4TestShouldUseBeforeAnnotation" /> |
| 25 | <exclude name="JUnit4TestShouldUseTestAnnotation" /> |
Austin Schuh | 812d0d1 | 2021-11-04 20:16:48 -0700 | [diff] [blame] | 26 | <exclude name="LooseCoupling" /> |
James Kuszmaul | cf32412 | 2023-01-14 14:07:17 -0800 | [diff] [blame^] | 27 | <exclude name="PreserveStackTrace" /> |
Brian Silverman | 8fce748 | 2020-01-05 13:18:21 -0800 | [diff] [blame] | 28 | <exclude name="ReplaceHashtableWithMap" /> |
| 29 | <exclude name="ReplaceVectorWithList" /> |
| 30 | <exclude name="SwitchStmtsShouldHaveDefault" /> |
| 31 | <exclude name="SystemPrintln" /> |
| 32 | <exclude name="UseVarargs" /> |
| 33 | </rule> |
| 34 | <rule ref="category/java/bestpractices.xml/UnusedPrivateMethod"> |
| 35 | <properties> |
| 36 | <property name="violationSuppressRegex" |
Austin Schuh | 812d0d1 | 2021-11-04 20:16:48 -0700 | [diff] [blame] | 37 | value=".*'.*Arguments\(\)'.*" /> |
Brian Silverman | 8fce748 | 2020-01-05 13:18:21 -0800 | [diff] [blame] | 38 | </properties> |
| 39 | </rule> |
| 40 | |
| 41 | <rule ref="category/java/design.xml"> |
Austin Schuh | 812d0d1 | 2021-11-04 20:16:48 -0700 | [diff] [blame] | 42 | <exclude name="AvoidThrowingRawExceptionTypes" /> |
Austin Schuh | 75263e3 | 2022-02-22 18:05:32 -0800 | [diff] [blame] | 43 | <exclude name="CognitiveComplexity" /> |
Austin Schuh | 812d0d1 | 2021-11-04 20:16:48 -0700 | [diff] [blame] | 44 | <exclude name="CyclomaticComplexity" /> |
Brian Silverman | 8fce748 | 2020-01-05 13:18:21 -0800 | [diff] [blame] | 45 | <exclude name="DataClass" /> |
Austin Schuh | 812d0d1 | 2021-11-04 20:16:48 -0700 | [diff] [blame] | 46 | <exclude name="ExcessiveClassLength" /> |
| 47 | <exclude name="ExcessiveImports" /> |
| 48 | <exclude name="ExcessiveMethodLength" /> |
| 49 | <exclude name="ExcessiveParameterList" /> |
| 50 | <exclude name="ExcessivePublicCount" /> |
| 51 | <exclude name="GodClass" /> |
Brian Silverman | 8fce748 | 2020-01-05 13:18:21 -0800 | [diff] [blame] | 52 | <exclude name="LawOfDemeter" /> |
| 53 | <exclude name="LoosePackageCoupling" /> |
Austin Schuh | 812d0d1 | 2021-11-04 20:16:48 -0700 | [diff] [blame] | 54 | <exclude name="NPathComplexity" /> |
Brian Silverman | 8fce748 | 2020-01-05 13:18:21 -0800 | [diff] [blame] | 55 | <exclude name="NcssConstructorCount" /> |
| 56 | <exclude name="NcssCount" /> |
| 57 | <exclude name="NcssMethodCount" /> |
Austin Schuh | 812d0d1 | 2021-11-04 20:16:48 -0700 | [diff] [blame] | 58 | <exclude name="TooManyFields" /> |
Austin Schuh | 1e69f94 | 2020-11-14 15:06:14 -0800 | [diff] [blame] | 59 | <exclude name="TooManyMethods" /> |
Brian Silverman | 8fce748 | 2020-01-05 13:18:21 -0800 | [diff] [blame] | 60 | </rule> |
| 61 | |
| 62 | <rule ref="category/java/errorprone.xml"> |
| 63 | <exclude name="AssignmentToNonFinalStatic" /> |
James Kuszmaul | cf32412 | 2023-01-14 14:07:17 -0800 | [diff] [blame^] | 64 | <exclude name="AvoidCatchingThrowable" /> |
Brian Silverman | 8fce748 | 2020-01-05 13:18:21 -0800 | [diff] [blame] | 65 | <exclude name="AvoidDuplicateLiterals" /> |
| 66 | <exclude name="AvoidLiteralsInIfCondition" /> |
| 67 | <exclude name="BeanMembersShouldSerialize" /> |
Austin Schuh | 75263e3 | 2022-02-22 18:05:32 -0800 | [diff] [blame] | 68 | <exclude name="CloseResource" /> |
Brian Silverman | 8fce748 | 2020-01-05 13:18:21 -0800 | [diff] [blame] | 69 | <exclude name="ConstructorCallsOverridableMethod" /> |
| 70 | <exclude name="DataflowAnomalyAnalysis" /> |
Austin Schuh | 75263e3 | 2022-02-22 18:05:32 -0800 | [diff] [blame] | 71 | <exclude name="DoNotTerminateVM" /> |
James Kuszmaul | cf32412 | 2023-01-14 14:07:17 -0800 | [diff] [blame^] | 72 | <exclude name="EmptyCatchBlock" /> |
| 73 | <exclude name="EmptyWhileStmt" /> |
Brian Silverman | 8fce748 | 2020-01-05 13:18:21 -0800 | [diff] [blame] | 74 | <exclude name="FinalizeDoesNotCallSuperFinalize" /> |
| 75 | <exclude name="JUnitSpelling" /> |
| 76 | <exclude name="MissingSerialVersionUID" /> |
| 77 | <exclude name="NullAssignment" /> |
| 78 | </rule> |
| 79 | |
| 80 | <rule ref="category/java/multithreading.xml"> |
| 81 | <exclude name="AvoidSynchronizedAtMethodLevel" /> |
| 82 | <exclude name="AvoidUsingVolatile" /> |
| 83 | <exclude name="DoNotUseThreads" /> |
| 84 | <exclude name="UseConcurrentHashMap" /> |
| 85 | </rule> |
| 86 | |
| 87 | <rule ref="category/java/performance.xml"> |
| 88 | <exclude name="AvoidUsingShortType" /> |
Austin Schuh | 812d0d1 | 2021-11-04 20:16:48 -0700 | [diff] [blame] | 89 | <exclude name="AvoidInstantiatingObjectsInLoops" /> |
Brian Silverman | 8fce748 | 2020-01-05 13:18:21 -0800 | [diff] [blame] | 90 | </rule> |
| 91 | |
Austin Schuh | 812d0d1 | 2021-11-04 20:16:48 -0700 | [diff] [blame] | 92 | <rule name="UnnecessaryCastRule" language="java" |
| 93 | message="Avoid unnecessary casts" |
Austin Schuh | 75263e3 | 2022-02-22 18:05:32 -0800 | [diff] [blame] | 94 | class="net.sourceforge.pmd.lang.java.rule.codestyle.UnnecessaryCastRule" |
| 95 | externalInfoUrl="https://github.com/pmd/pmd/blob/master/pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/codestyle/UnnecessaryCastRule.java" /> |
Brian Silverman | 8fce748 | 2020-01-05 13:18:21 -0800 | [diff] [blame] | 96 | |
| 97 | <!-- Custom Rules --> |
| 98 | <rule name="UseRequireNonNull" |
Austin Schuh | 812d0d1 | 2021-11-04 20:16:48 -0700 | [diff] [blame] | 99 | message="Use Objects.requireNonNull() instead of throwing a NullPointerException yourself." |
| 100 | language="java" class="net.sourceforge.pmd.lang.rule.XPathRule"> |
Brian Silverman | 8fce748 | 2020-01-05 13:18:21 -0800 | [diff] [blame] | 101 | <description>Use Objects.requireNonNull() instead of throwing a |
Austin Schuh | 812d0d1 | 2021-11-04 20:16:48 -0700 | [diff] [blame] | 102 | NullPointerException yourself.</description> |
Brian Silverman | 8fce748 | 2020-01-05 13:18:21 -0800 | [diff] [blame] | 103 | <properties> |
| 104 | <property name="xpath"> |
| 105 | <value> |
| 106 | <![CDATA[ |
| 107 | //IfStatement[child::Expression//NullLiteral]/Statement//ThrowStatement/Expression/PrimaryExpression/PrimaryPrefix/AllocationExpression/ClassOrInterfaceType[@Image='NullPointerException'] |
| 108 | ]]> |
| 109 | </value> |
| 110 | </property> |
| 111 | </properties> |
| 112 | <priority>3</priority> |
| 113 | <example> |
| 114 | <![CDATA[ |
| 115 | public class Example { |
| 116 | public Example(Object example) { |
| 117 | if (example == null) { |
| 118 | throw new NullPointerException(); |
| 119 | } |
| 120 | } |
| 121 | } |
| 122 | ]]> |
| 123 | </example> |
| 124 | </rule> |
| 125 | </ruleset> |