commit fe457dea6a9ec3f1e3abb5d497212b8f3085570d
author Brian Silverman <brians> Mon May 26 22:04:08 2014 -0700
committer Brian Silverman <brians> Mon May 26 22:04:08 2014 -0700
tree e0eb6b24ba2915ac7bb35204aac1d901d218a2a1
parent 0534df69fbd425588e4ee2662202e383f46e4110

removed lots of asserts

Some of them relied on the side effects of evaluating their argument but
for most of them it just makes more sense to use CHECK.

aos/common/condition_test.cc

diff --git a/aos/common/condition_test.cc b/aos/common/condition_test.cc
index 65a1028..6914a8b 100644
--- a/aos/common/condition_test.cc
+++ b/aos/common/condition_test.cc
@@ -75,7 +75,7 @@
     new (shared_) Shared();
   }
   ~ConditionTestProcess() {
-    assert(child_ == -1);
+    CHECK_EQ(child_, -1);
   }
 
   void Start() {
@@ -87,7 +87,7 @@
       Run();
       exit(EXIT_SUCCESS);
     } else {  // in parent
-      assert(child_ != -1);
+      CHECK_NE(child_, -1);
 
       shared_->ready.Lock();
 
@@ -170,16 +170,16 @@
   }
 
   void Join() {
-    assert(child_ != -1);
+    CHECK_NE(child_, -1);
     int status;
     do {
-      assert(waitpid(child_, &status, 0) == child_);
+      CHECK_EQ(waitpid(child_, &status, 0), child_);
     } while (!(WIFEXITED(status) || WIFSIGNALED(status)));
     child_ = -1;
   }
   void Kill() {
-    assert(child_ != -1);
-    assert(kill(child_, SIGTERM) == 0);
+    CHECK_NE(child_, -1);
+    PCHECK(kill(child_, SIGTERM));
     Join();
   }