Fix flaky //scouting/webserver/requests/debug/cli:cli_test
We're seeing timeouts in this test. After adding some debugging, it
looks like it's fixed by making stronger guarantees about the startup
order. Every once in a while the scouting server started up faster
than the fake TBA server and fail to scrape the data. Since we only
scrape the data every 10 minutes, the test times out before scraping
completes.
The fix here is to start the fake TBA server before the webserver.
That lets the webserver scrape successfully on startup.
I left the additional debugging in place because it might be helpful
in the future.
Signed-off-by: Philipp Schrader <philipp.schrader@gmail.com>
Change-Id: Ibe32b0e622319ff4813c056054aea8543e4ae2e2
diff --git a/scouting/testing/scouting_test_servers.py b/scouting/testing/scouting_test_servers.py
index 40412c0..95c146e 100644
--- a/scouting/testing/scouting_test_servers.py
+++ b/scouting/testing/scouting_test_servers.py
@@ -101,22 +101,23 @@
])
wait_for_server(5432)
+ # Create a fake TBA server to serve the static match list.
+ # Make sure it starts up first so that the webserver successfully
+ # scrapes the TBA data on startup.
+ set_up_tba_api_dir(self.tmpdir, year, event_code)
+ self.fake_tba_api = subprocess.Popen(
+ ["python3", "-m", "http.server", "7000"],
+ cwd=self.tmpdir,
+ )
+ wait_for_server(7000)
+
+ # Wait for the scouting webserver to start up.
self.webserver = subprocess.Popen([
RUNFILES.Rlocation("org_frc971/scouting/scouting"),
f"--port={port}",
f"--db_config={db_config}",
f"--tba_config={tba_config}",
])
-
- # Create a fake TBA server to serve the static match list.
- set_up_tba_api_dir(self.tmpdir, year, event_code)
- self.fake_tba_api = subprocess.Popen(
- ["python3", "-m", "http.server", "7000"],
- cwd=self.tmpdir,
- )
-
- # Wait for the TBA server and the scouting webserver to start up.
- wait_for_server(7000)
wait_for_server(port)
if notify_fd: