Fix various little bugs and loosen up various warnings
Change-Id: Iead48ac030290290c7c448b6f72a31380c2e8326
diff --git a/aos/common/actions/actions.h b/aos/common/actions/actions.h
index fd88903..b26f732 100644
--- a/aos/common/actions/actions.h
+++ b/aos/common/actions/actions.h
@@ -147,7 +147,7 @@
void DoWaitUntilDone() override;
- bool DoCheckIteration(bool blocking);
+ bool DoCheckIteration(bool blocking) override;
// Sets the started flag (also possibly the interrupted flag).
void CheckStarted();
diff --git a/frc971/control_loops/BUILD b/frc971/control_loops/BUILD
index c220b96..1fba54f 100644
--- a/frc971/control_loops/BUILD
+++ b/frc971/control_loops/BUILD
@@ -65,6 +65,7 @@
deps = [
':queues',
':gaussian_noise',
+ '//external:libm',
],
)
@@ -76,6 +77,9 @@
hdrs = [
'gaussian_noise.h',
],
+ deps = [
+ '//external:libm',
+ ],
)
cc_library(
diff --git a/third_party/cddlib/BUILD b/third_party/cddlib/BUILD
index 4d3f000..d197954 100644
--- a/third_party/cddlib/BUILD
+++ b/third_party/cddlib/BUILD
@@ -18,4 +18,11 @@
hdrs = [
'lib-src/cdd.h',
],
+ copts = [
+ '-Wno-sometimes-uninitialized',
+ '-Wno-unused-parameter',
+ '-Wno-switch-enum',
+ '-Wno-empty-body',
+ '-Wno-sign-compare',
+ ],
)
diff --git a/third_party/cddlib/lib-src/cdd.h b/third_party/cddlib/lib-src/cdd.h
index 6925745..3c37254 100644
--- a/third_party/cddlib/lib-src/cdd.h
+++ b/third_party/cddlib/lib-src/cdd.h
@@ -225,7 +225,7 @@
void dd_FreeDDMemory0(dd_ConePtr);
void dd_fread_rational_value (FILE *f, mytype value);
-void dd_sread_rational_value (const char *s, mytype value);
+void dd_sread_rational_value (char *s, mytype value);
void dd_AddNewHalfspace1(dd_ConePtr, dd_rowrange);
void dd_AddNewHalfspace2(dd_ConePtr, dd_rowrange);
void dd_AddRay(dd_ConePtr, mytype *);
diff --git a/third_party/cddlib/lib-src/cddio.c b/third_party/cddlib/lib-src/cddio.c
index 58545d5..783dd1c 100644
--- a/third_party/cddlib/lib-src/cddio.c
+++ b/third_party/cddlib/lib-src/cddio.c
@@ -68,7 +68,7 @@
void dd_SetWriteFileName(dd_DataFileType inputfile, dd_DataFileType outfile, char cflag, dd_RepresentationType rep)
{
- char *extension;
+ const char *extension;
dd_DataFileType ifilehead="";
int i,dotpos;
@@ -1931,7 +1931,7 @@
/****************************************************************************************/
/* rational number (a/b) read is taken from Vinci by Benno Bueeler and Andreas Enge */
/****************************************************************************************/
-void dd_sread_rational_value (const char *s, mytype value)
+void dd_sread_rational_value (char *s, mytype value)
/* reads a rational value from the specified string "s" and assigns it to "value" */
{
diff --git a/third_party/cddlib/lib-src/cddlp.c b/third_party/cddlib/lib-src/cddlp.c
index 46f98b5..6605c02 100644
--- a/third_party/cddlib/lib-src/cddlp.c
+++ b/third_party/cddlib/lib-src/cddlp.c
@@ -2951,7 +2951,7 @@
} /* endwhile */
} else {
/* No interior point is found. Apply the standard LP technique. */
- if (localdebug) printf("No interior-point is found and thus the standard LP technique will be used.\n", ired);
+ if (localdebug) printf("No interior-point is found and thus the standard LP technique will be used.\n");
redset=dd_RedundantRows(M, error);
}
diff --git a/third_party/gflags/BUILD b/third_party/gflags/BUILD
index 46118ba..9642c6f 100644
--- a/third_party/gflags/BUILD
+++ b/third_party/gflags/BUILD
@@ -18,6 +18,10 @@
'-DGFLAGS_IS_A_DLL=0',
'-DGFLAGS_DLL_DECL=',
'-DGFLAGS_DLL_DEFINE_FLAG=',
+
+ '-Wno-format-nonliteral',
+ '-Wno-unused-local-typedef',
+ '-Wno-sign-compare',
]
cc_library(
@@ -36,6 +40,9 @@
'include/gflags/gflags.h',
'include/gflags/gflags_completions.h',
],
+ deps = [
+ '//external:libpthread',
+ ],
copts = common_copts,
includes = [ 'include' ],
)
diff --git a/third_party/googletest/BUILD b/third_party/googletest/BUILD
index a5dd79e..861ce5d 100644
--- a/third_party/googletest/BUILD
+++ b/third_party/googletest/BUILD
@@ -34,6 +34,9 @@
"-g",
"-Wall",
"-Wextra",
+ "-Wno-format-nonliteral",
+ "-Wno-switch-enum",
+ "-Wno-missing-field-initializers",
],
linkopts = [
"-pthread",
@@ -77,6 +80,9 @@
"-g",
"-Wall",
"-Wextra",
+ "-Wno-switch-enum",
+ "-Wno-missing-field-initializers",
+ "-Wno-unused-parameter",
],
linkopts = [
"-pthread",
@@ -143,7 +149,7 @@
tests = [
":googlemock_gmock_actions_test",
":googlemock_gmock_cardinalities_test",
- ":googlemock_gmock_ex_test",
+ #":googlemock_gmock_ex_test",
":googlemock_gmock_generated_actions_test",
":googlemock_gmock-generated_function_mockers_test",
":googlemock_gmock-generated_internal_utils_test",
@@ -422,6 +428,7 @@
],
)
+'''
cc_test(
name = "googlemock_gmock_ex_test",
srcs = [
@@ -432,6 +439,7 @@
":googletest_main",
],
)
+'''
cc_test(
name = "googlemock_gmock_generated_actions_test",
@@ -475,6 +483,9 @@
":googlemock",
":googletest_main",
],
+ copts = [
+ "-Wno-unused-parameter",
+ ],
)
cc_test(
@@ -533,6 +544,9 @@
":googlemock",
":googletest_main",
],
+ copts = [
+ "-Wno-unused-parameter",
+ ],
)
cc_test(
diff --git a/third_party/libevent/BUILD b/third_party/libevent/BUILD
index 7c3fc10..50f714a 100644
--- a/third_party/libevent/BUILD
+++ b/third_party/libevent/BUILD
@@ -48,5 +48,15 @@
copts = [
'-Ithird_party/libevent/compat',
'-Ithird_party/libevent/include',
+
+ # TODO(Brian): Fix the places in the code it uses char* as an intermediate
+ # type while doing offsetof stuff.
+ '-Wno-cast-align',
+
+ '-Wno-unused-parameter',
+ '-Wno-format-nonliteral',
+ '-Wno-cast-qual',
+ '-Wno-incompatible-pointer-types-discards-qualifiers',
+ '-Wno-unused-function',
],
)
diff --git a/third_party/libevent/buffer.c b/third_party/libevent/buffer.c
index 8510955..80a9e1b 100644
--- a/third_party/libevent/buffer.c
+++ b/third_party/libevent/buffer.c
@@ -1680,7 +1680,7 @@
} else if (chain->misalign) {
/* we can only fit some of the data. */
memcpy(chain->buffer,
- (char*)data + datlen - chain->misalign,
+ (const char*)data + datlen - chain->misalign,
(size_t)chain->misalign);
chain->off += (size_t)chain->misalign;
buf->total_len += (size_t)chain->misalign;
@@ -2749,7 +2749,7 @@
if (!chain)
return (-1);
chain->flags |= EVBUFFER_REFERENCE | EVBUFFER_IMMUTABLE;
- chain->buffer = (u_char *)data;
+ chain->buffer = (const u_char *)data;
chain->buffer_len = datlen;
chain->off = datlen;
diff --git a/third_party/libevent/evdns.c b/third_party/libevent/evdns.c
index 60b1048..3ae5d8b 100644
--- a/third_party/libevent/evdns.c
+++ b/third_party/libevent/evdns.c
@@ -2471,7 +2471,7 @@
ASSERT_LOCKED(base);
if (server) {
do {
- if (!evutil_sockaddr_cmp((struct sockaddr*)&server->address, address, 1)) return 3;
+ if (!evutil_sockaddr_cmp((const struct sockaddr*)&server->address, address, 1)) return 3;
server = server->next;
} while (server != started_at);
}
diff --git a/third_party/libevent/event_tagging.c b/third_party/libevent/event_tagging.c
index eea4bfc..ece9a0d 100644
--- a/third_party/libevent/event_tagging.c
+++ b/third_party/libevent/event_tagging.c
@@ -250,7 +250,7 @@
{
evtag_encode_tag(evbuf, tag);
evtag_encode_int(evbuf, len);
- evbuffer_add(evbuf, (void *)data, len);
+ evbuffer_add(evbuf, (const void *)data, len);
}
void
diff --git a/third_party/libevent/evutil_rand.c b/third_party/libevent/evutil_rand.c
index 284341c..8641f3d 100644
--- a/third_party/libevent/evutil_rand.c
+++ b/third_party/libevent/evutil_rand.c
@@ -174,7 +174,7 @@
void
evutil_secure_rng_add_bytes(const char *buf, size_t n)
{
- arc4random_addrandom((unsigned char*)buf,
+ arc4random_addrandom((const unsigned char*)buf,
n>(size_t)INT_MAX ? INT_MAX : (int)n);
}
diff --git a/third_party/libevent/ht-internal.h b/third_party/libevent/ht-internal.h
index 4673825..a56c4a6 100644
--- a/third_party/libevent/ht-internal.h
+++ b/third_party/libevent/ht-internal.h
@@ -137,7 +137,7 @@
/* Helper: returns a pointer to the right location in the table \
* 'head' to find or insert the element 'elm'. */ \
static inline struct type ** \
- _##name##_HT_FIND_P(struct name *head, struct type *elm) \
+ _##name##_HT_FIND_P(const struct name *head, struct type *elm) \
{ \
struct type **p; \
if (!head->hth_table) \
@@ -156,7 +156,7 @@
name##_HT_FIND(const struct name *head, struct type *elm) \
{ \
struct type **p; \
- struct name *h = (struct name *) head; \
+ const struct name *h = (const struct name *) head; \
_HT_SET_HASH(elm, field, hashfn); \
p = _##name##_HT_FIND_P(h, elm); \
return p ? *p : NULL; \
diff --git a/third_party/seasocks/BUILD b/third_party/seasocks/BUILD
index 57e0c01..9dc7c61 100644
--- a/third_party/seasocks/BUILD
+++ b/third_party/seasocks/BUILD
@@ -10,4 +10,12 @@
'src/main/internal/**/*',
]),
includes = ['src/main/c'],
+ copts = [
+ # TODO(Brian): Don't apply this to all of the code...
+ '-Wno-cast-align',
+
+ '-Wno-switch-enum',
+ '-Wno-format-nonliteral',
+ '-Wno-unused-parameter',
+ ],
)