commit f0bb837b012da1f6b304a41cab96b8fc33e2c290
author Brian Silverman <brians> Wed Apr 30 15:58:55 2014 -0700
committer Brian Silverman <brians> Wed Apr 30 17:58:04 2014 -0700
tree cd2d3ad9d8bf197e6a8f0b1db1f3a2243ba36da1
parent 2945823430da4c27bbb7d1b9a4492fd5163f59ee

fixed a buffer overrun that made the test fail falsely

aos/common/logging/logging_impl_test.cc

diff --git a/aos/common/logging/logging_impl_test.cc b/aos/common/logging/logging_impl_test.cc
index f472bef..34bcdd1 100644
--- a/aos/common/logging/logging_impl_test.cc
+++ b/aos/common/logging/logging_impl_test.cc
@@ -4,7 +4,6 @@
 
 #include "aos/common/logging/logging_impl.h"
 #include "aos/common/time.h"
-#include "aos/common/die.h"
 #include <inttypes.h>
 
 using ::testing::AssertionResult;
@@ -54,13 +53,16 @@
     }
     internal::Context *context = internal::Context::Get();
     if (log_implementation->message().source != context->source) {
-      Die("got a message from %" PRIu32 ", but we're %" PRIu32 "\n",
+      LOG(FATAL, "got a message from %" PRIu32 ", but we're %" PRIu32 "\n",
           static_cast<uint32_t>(log_implementation->message().source),
           static_cast<uint32_t>(context->source));
     }
-    if (strcmp(log_implementation->message().name,
-               context->name.c_str()) != 0) {
-      Die("got a message from %s, but we're %s\n",
+    if (log_implementation->message().name_length != context->name.size() ||
+        memcmp(log_implementation->message().name, context->name.c_str(),
+               context->name.size()) !=
+            0) {
+      LOG(FATAL, "got a message from %.*s, but we're %s\n",
+          static_cast<int>(log_implementation->message().name_length),
           log_implementation->message().name, context->name.c_str());
     }
     if (strstr(log_implementation->message().message, message.c_str())