commit eb9f6fbb317120243ad2ced75adf8c4b3bf7f6ec
author James Kuszmaul <jabukuszmaul@gmail.com> Sun Feb 27 21:04:00 2022 -0800
committer James Kuszmaul <jabukuszmaul+collab@gmail.com> Tue Mar 01 19:32:21 2022 -0800
tree 45205ba495595aca312c5ec983912380010047e9
parent 296710bc088979541bccefe8ddde98c926dd32dc

Die on duplicate/invalid DigitalInput's

Haven't actually checked whether running FATAL checks on every single
access causes any issues, but the CHECK's in the constructors are fine
at least.

Change-Id: Icdca5556c5d041f8812468b19de6690dc80bf416
Signed-off-by: James Kuszmaul <jabukuszmaul+collab@gmail.com>

frc971/wpilib/ahal/DigitalOutput.cc

diff --git a/frc971/wpilib/ahal/DigitalOutput.cc b/frc971/wpilib/ahal/DigitalOutput.cc
index cc1f3d2..ac00df3 100644
--- a/frc971/wpilib/ahal/DigitalOutput.cc
+++ b/frc971/wpilib/ahal/DigitalOutput.cc
@@ -43,6 +43,7 @@
   if (status != 0) {
     wpi_setErrorWithContextRange(status, 0, HAL_GetNumDigitalChannels(),
                                  channel, HAL_GetErrorMessage(status));
+    HAL_CHECK_STATUS(status);
     m_channel = std::numeric_limits<int>::max();
     m_handle = HAL_kInvalidHandle;
     return;
@@ -75,6 +76,7 @@
   int32_t status = 0;
   HAL_SetDIO(m_handle, value, &status);
   wpi_setErrorWithContext(status, HAL_GetErrorMessage(status));
+  HAL_CHECK_STATUS(status);
 }
 
 /**
@@ -88,6 +90,7 @@
   int32_t status = 0;
   bool val = HAL_GetDIO(m_handle, &status);
   wpi_setErrorWithContext(status, HAL_GetErrorMessage(status));
+  HAL_CHECK_STATUS(status);
   return val;
 }
 
@@ -110,6 +113,7 @@
   int32_t status = 0;
   HAL_Pulse(m_handle, length, &status);
   wpi_setErrorWithContext(status, HAL_GetErrorMessage(status));
+  HAL_CHECK_STATUS(status);
 }
 
 /**
@@ -123,6 +127,7 @@
   int32_t status = 0;
   bool value = HAL_IsPulsing(m_handle, &status);
   wpi_setErrorWithContext(status, HAL_GetErrorMessage(status));
+  HAL_CHECK_STATUS(status);
   return value;
 }
 
@@ -142,6 +147,7 @@
   int32_t status = 0;
   HAL_SetDigitalPWMRate(rate, &status);
   wpi_setErrorWithContext(status, HAL_GetErrorMessage(status));
+  HAL_CHECK_STATUS(status);
 }
 
 /**
@@ -173,6 +179,8 @@
   if (StatusIsFatal()) return;
   HAL_SetDigitalPWMOutputChannel(m_pwmGenerator, m_channel, &status);
   wpi_setErrorWithContext(status, HAL_GetErrorMessage(status));
+
+  HAL_CHECK_STATUS(status);
 }
 
 /**
@@ -194,6 +202,8 @@
   wpi_setErrorWithContext(status, HAL_GetErrorMessage(status));
 
   m_pwmGenerator = HAL_kInvalidHandle;
+
+  HAL_CHECK_STATUS(status);
 }
 
 /**
@@ -210,6 +220,8 @@
   int32_t status = 0;
   HAL_SetDigitalPWMDutyCycle(m_pwmGenerator, dutyCycle, &status);
   wpi_setErrorWithContext(status, HAL_GetErrorMessage(status));
+
+  HAL_CHECK_STATUS(status);
 }
 
 /**