scouting: Migrate to using npm-style packages for deps
Using the npm style for tracking dependencies makes it easier to write
common modules that our existing modules can import.
I was trying to set up a shared `Pipe` class for some modules and
couldn't work around this issue:
scouting/www/entry/entry.module.ts:10:13 - error NG3004: Unable to import class PipeModule.
The file /dev/shm/bazel-sandbox.62240ff599163761312fdbd652f7452abc23edc253dee6214f406f29dde5568b/linux-sandbox/192/execroot/org_frc971/bazel-out/k8-fastbuild/bin/scouting/www/pipes/pipes.module.d.ts is outside of the configured 'rootDir'.
10 exports: [PipeModule, EntryComponent],
The simplest way to work around it is by using npm modules everywhere.
This meant that I had to convert the existing fbs messages into an npm
module too.
There should be no functional changes.
Signed-off-by: Philipp Schrader <philipp.schrader@gmail.com>
Change-Id: I4813fd304302a8bd664443023ef21aa147b80d2e
diff --git a/scouting/www/pit_scouting/BUILD b/scouting/www/pit_scouting/BUILD
index 740dee1..cfaf5d4 100644
--- a/scouting/www/pit_scouting/BUILD
+++ b/scouting/www/pit_scouting/BUILD
@@ -9,10 +9,7 @@
"//scouting/www:app_common_css",
],
deps = [
- ":node_modules/@angular/forms",
- "//scouting/webserver/requests/messages:error_response_ts_fbs",
- "//scouting/webserver/requests/messages:submit_pit_image_response_ts_fbs",
- "//scouting/webserver/requests/messages:submit_pit_image_ts_fbs",
- "@com_github_google_flatbuffers//ts:flatbuffers_ts",
+ ":node_modules",
+ "//:node_modules/flatbuffers",
],
)
diff --git a/scouting/www/pit_scouting/package.json b/scouting/www/pit_scouting/package.json
index f41150f..2eb2783 100644
--- a/scouting/www/pit_scouting/package.json
+++ b/scouting/www/pit_scouting/package.json
@@ -2,6 +2,7 @@
"name": "@org_frc971/scouting/www/pit_scouting",
"private": true,
"dependencies": {
- "@angular/forms": "v16-lts"
+ "@angular/forms": "v16-lts",
+ "@org_frc971/scouting/webserver/requests/messages": "workspace:*"
}
}
diff --git a/scouting/www/pit_scouting/pit_scouting.component.ts b/scouting/www/pit_scouting/pit_scouting.component.ts
index 7bb884c..294eca2 100644
--- a/scouting/www/pit_scouting/pit_scouting.component.ts
+++ b/scouting/www/pit_scouting/pit_scouting.component.ts
@@ -6,8 +6,8 @@
ViewChildren,
} from '@angular/core';
import {Builder, ByteBuffer} from 'flatbuffers';
-import {ErrorResponse} from '../../webserver/requests/messages/error_response_generated';
-import {SubmitPitImage} from '../../webserver/requests/messages/submit_pit_image_generated';
+import {ErrorResponse} from '@org_frc971/scouting/webserver/requests/messages/error_response_generated';
+import {SubmitPitImage} from '@org_frc971/scouting/webserver/requests/messages/submit_pit_image_generated';
type Section = 'TeamSelection' | 'Data';