commit e02b0d17efdb3cfefca584101e72aefe0873d8de
author Sarah Newman <sarah.newman@bluerivertech.com> Wed Mar 30 12:18:55 2022 -0700
committer James Kuszmaul <james.kuszmaul@bluerivertech.com> Tue May 03 15:48:54 2022 -0700
tree 7e192ecdff34daead72967e843f71e4193490c5c
parent 03c00da0ef4fae4f85e69748bb4a443054d49320

sctp_client: don't bind to the socket

Binding to the socket appears to be Mostly Harmless, but
the proper sequence for a one-to-many client in this style is:

            1. socket()
            2. sendmsg()
            3. recvmsg()
            4. close()

Per

https://www.man7.org/linux/man-pages/man7/sctp.7.html

Change-Id: Iadc908a4595a6dca41c92fa18d03afafda1ef397
Signed-off-by: James Kuszmaul <james.kuszmaul@bluerivertech.com>

aos/network/sctp_client.cc

diff --git a/aos/network/sctp_client.cc b/aos/network/sctp_client.cc
index 1033e31..fac1114 100644
--- a/aos/network/sctp_client.cc
+++ b/aos/network/sctp_client.cc
@@ -39,12 +39,6 @@
     int on = 1;
     PCHECK(setsockopt(fd(), IPPROTO_SCTP, SCTP_NODELAY, &on, sizeof(int)) == 0);
   }
-
-  PCHECK(bind(fd(), (struct sockaddr *)&sockaddr_local_,
-              sockaddr_local_.ss_family == AF_INET6
-                  ? sizeof(struct sockaddr_in6)
-                  : sizeof(struct sockaddr_in)) == 0);
-  VLOG(1) << "bind(" << fd() << ", " << Address(sockaddr_local_) << ")";
 }
 
 void SctpClient::LogSctpStatus(sctp_assoc_t assoc_id) {