commit dada107facf6a76af9d974fa6b17af76fa85e680
author Philipp Schrader <philipp.schrader@gmail.com> Tue Nov 24 11:34:46 2020 -0800
committer Philipp Schrader <philipp.schrader@gmail.com> Sat Dec 12 15:48:00 2020 -0800
tree 0e5b9c456e38573b94ade3d8b15c18f13b07d15b
parent fbbd93b5a87a6c01c24d750fedac568bc6ac8cbe

Switch everything to platforms

This patch switches the codebase over from using the "cpu"
mechanism to using bazel platforms. See
https://docs.bazel.build/versions/master/platforms.html for some more
information.

Most of the substantial changes are in //tools. Instead of using
`cc_toolchain_suite` rules, we now use regular `toolchain` rules that
are registered in the WORKSPACE. That also means that bazel now uses
the target platform to select the compiler.

All --cpu=* arguments should now be --config=* arguments. For example,
`--cpu=roborio` should now be `--config=roborio`. The CI script and
all documentation has been updated to reflect that.

The remainder of the changes revolve around tagging all targets with
`target_compatible_with`.  The old mechanism allowed us to specify
repo-wide defaults. The new mechanism does not. That means every
target that didn't have any compatibility specified, now requires
compatibility with `@platforms//os:linux`.

I used buildozer for the vast majority of `target_compatible_with`
changes. buildozer automatically buildifies any BUILD files it
touches. That means this patch also contains a few non-functional
changes that I was too lazy to remove.

Change-Id: I66d6e6ad9161520ee397597cdb492585820a3acd

y2019/vision/server/BUILD

diff --git a/y2019/vision/server/BUILD b/y2019/vision/server/BUILD
index 3d63e09..c20357f 100644
--- a/y2019/vision/server/BUILD
+++ b/y2019/vision/server/BUILD
@@ -9,6 +9,7 @@
     srcs = [
         "demo.ts",
     ],
+    target_compatible_with = ["@platforms//os:linux"],
 )
 
 gen_embedded(
@@ -17,6 +18,7 @@
         include = ["www_defaults/**/*"],
         exclude = ["www/**/*"],
     ),
+    target_compatible_with = ["@platforms//os:linux"],
 )
 
 aos_downloader_dir(
@@ -26,12 +28,14 @@
         "//y2019/vision/server/www:visualizer_bundle",
     ],
     dir = "www",
+    target_compatible_with = ["@platforms//os:linux"],
     visibility = ["//visibility:public"],
 )
 
 cc_proto_library(
     name = "server_data_proto",
     srcs = ["server_data.proto"],
+    target_compatible_with = ["@platforms//os:linux"],
 )
 
 cc_binary(
@@ -43,6 +47,7 @@
         "//y2019/vision/server/www:files",
         "//y2019/vision/server/www:visualizer_bundle",
     ],
+    target_compatible_with = ["@platforms//os:linux"],
     visibility = ["//visibility:public"],
     deps = [
         ":gen_embedded",

y2019/vision/server/www/BUILD

diff --git a/y2019/vision/server/www/BUILD b/y2019/vision/server/www/BUILD
index 7631d5e..62c1f13 100644
--- a/y2019/vision/server/www/BUILD
+++ b/y2019/vision/server/www/BUILD
@@ -15,11 +15,13 @@
     srcs = glob([
         "*.ts",
     ]) + ["camera_constants.ts"],
+    target_compatible_with = ["@platforms//os:linux"],
 )
 
 cc_binary(
     name = "generate_camera",
     srcs = ["generate_camera.cc"],
+    target_compatible_with = ["@platforms//os:linux"],
     deps = ["//y2019:constants"],
 )
 
@@ -27,6 +29,7 @@
     name = "gen_cam_ts",
     outs = ["camera_constants.ts"],
     cmd = "$(location :generate_camera) $@",
+    target_compatible_with = ["@platforms//os:linux"],
     tools = [":generate_camera"],
 )
 
@@ -34,6 +37,7 @@
     name = "visualizer_bundle",
     enable_code_splitting = False,
     entry_point = "main.ts",
+    target_compatible_with = ["@platforms//os:linux"],
     deps = [
         ":visualizer",
     ],