commit d930f28921ed20cc82b4c9a28cadcffc07a1a6b9
author Brian Silverman <bsilver16384@gmail.com> Sat Nov 04 23:09:12 2017 -0400
committer Brian Silverman <bsilver16384@gmail.com> Sun Nov 26 22:35:15 2017 -0500
tree b4f4a37b4123d5fb1d6e46d1df25a2bf856af2e8
parent 6501d23a4490759c185c144c1dc57f790c2d9e4c

Add a simple HID device

It currently has a hard-coded report of 4 2-byte joystick values
plus 8 buttons.

Also fix a few things I noticed in the CDC code while working on the HID
code.

Change-Id: Icce6c6ad686fdf974924daab6cb40b7b7d0f7996

motors/usb/cdc.cc

diff --git a/motors/usb/cdc.cc b/motors/usb/cdc.cc
index 0b59aef..5136937 100644
--- a/motors/usb/cdc.cc
+++ b/motors/usb/cdc.cc
@@ -167,11 +167,12 @@
   }
 
   {
-    const auto abstract_control_management =
-        CreateDescriptor(cdc_descriptor_subtype::abstract_control_management_length(),
-                         UsbClassDescriptorType::kInterface);
+    const auto abstract_control_management = CreateDescriptor(
+        cdc_descriptor_subtype::abstract_control_management_length(),
+        UsbClassDescriptorType::kInterface);
     abstract_control_management->AddByte(
-        cdc_descriptor_subtype::abstract_control_management());  // bDescriptorSubtype
+        cdc_descriptor_subtype::
+            abstract_control_management());  // bDescriptorSubtype
     // We support:
     //   line_coding and serial_state
     //   send_break
@@ -198,7 +199,7 @@
                                  m_endpoint_address_in());  // bEndpointAddress
     endpoint_descriptor->AddByte(
         m_endpoint_attributes_interrupt());                // bmAttributes
-    endpoint_descriptor->AddUint16(kStatusMaxPacketSize);  // wMaxEndpointSize
+    endpoint_descriptor->AddUint16(kStatusMaxPacketSize);  // wMaxPacketSize
     // Set it to the max because we have nothing to send, so no point using bus
     // bandwidth asking.
     endpoint_descriptor->AddByte(255);  // bInterval
@@ -225,7 +226,7 @@
         endpoint_descriptor_length(), UsbDescriptorType::kEndpoint);
     endpoint_descriptor->AddByte(data_rx_endpoint_);  // bEndpointAddress
     endpoint_descriptor->AddByte(m_endpoint_attributes_bulk());  // bmAttributes
-    endpoint_descriptor->AddUint16(kDataMaxPacketSize);  // wMaxEndpointSize
+    endpoint_descriptor->AddUint16(kDataMaxPacketSize);  // wMaxPacketSize
     endpoint_descriptor->AddByte(1);                     // bInterval
   }
 
@@ -235,7 +236,7 @@
     endpoint_descriptor->AddByte(data_tx_endpoint_ |
                                  m_endpoint_address_in());  // bEndpointAddress
     endpoint_descriptor->AddByte(m_endpoint_attributes_bulk());  // bmAttributes
-    endpoint_descriptor->AddUint16(kDataMaxPacketSize);  // wMaxEndpointSize
+    endpoint_descriptor->AddUint16(kDataMaxPacketSize);  // wMaxPacketSize
     endpoint_descriptor->AddByte(1);                     // bInterval
   }
 }
@@ -365,8 +366,8 @@
     device()->ConfigureEndpointFor(status_endpoint_, false, true, true);
   } else if (endpoint == data_tx_endpoint_) {
     device()->ConfigureEndpointFor(data_tx_endpoint_, false, true, true);
-    next_tx_toggle_ = Data01::kData0;
     DisableInterrupts disable_interrupts;
+    next_tx_toggle_ = Data01::kData0;
     EnqueueTxData(disable_interrupts);
   } else if (endpoint == data_rx_endpoint_) {
     device()->ConfigureEndpointFor(data_rx_endpoint_, true, false, true);