commit bfbaa37afda9820b65df8c71c3e1a128ba04cfc0
author Austin Schuh <austin.linux@gmail.com> Fri Feb 15 23:05:31 2019 -0800
committer Austin Schuh <austin.linux@gmail.com> Fri Feb 15 23:18:18 2019 -0800
tree 61bf6a8c704d1c64c1fad15989c410f9772957c3
parent ba23ba9e0b48ce532eda780ee9869623fa67f9fc

Fix memory leak of BufferedPcm in y2018

Change-Id: Id9c4be344a1f3844411362762472260873f4ce26

y2018/wpilib_interface.cc

diff --git a/y2018/wpilib_interface.cc b/y2018/wpilib_interface.cc
index 2d5e556..2de1741 100644
--- a/y2018/wpilib_interface.cc
+++ b/y2018/wpilib_interface.cc
@@ -728,14 +728,14 @@
     ::std::thread superstructure_writer_thread(
         ::std::ref(superstructure_writer));
 
-    ::frc971::wpilib::BufferedPcm *pcm = new ::frc971::wpilib::BufferedPcm();
-    SolenoidWriter solenoid_writer(pcm);
-    solenoid_writer.set_left_drivetrain_shifter(pcm->MakeSolenoid(0));
-    solenoid_writer.set_right_drivetrain_shifter(pcm->MakeSolenoid(1));
-    solenoid_writer.set_claw(pcm->MakeSolenoid(2));
-    solenoid_writer.set_arm_brakes(pcm->MakeSolenoid(3));
-    solenoid_writer.set_hook(pcm->MakeSolenoid(4));
-    solenoid_writer.set_forks(pcm->MakeSolenoid(5));
+    ::frc971::wpilib::BufferedPcm pcm;
+    SolenoidWriter solenoid_writer(&pcm);
+    solenoid_writer.set_left_drivetrain_shifter(pcm.MakeSolenoid(0));
+    solenoid_writer.set_right_drivetrain_shifter(pcm.MakeSolenoid(1));
+    solenoid_writer.set_claw(pcm.MakeSolenoid(2));
+    solenoid_writer.set_arm_brakes(pcm.MakeSolenoid(3));
+    solenoid_writer.set_hook(pcm.MakeSolenoid(4));
+    solenoid_writer.set_forks(pcm.MakeSolenoid(5));
 
     ::std::thread solenoid_thread(::std::ref(solenoid_writer));