Don't run DH_check() in rawrtc when on the rio
It's obnoxiously expensive. Sounds like there should be some cleaner
solution that would let this happen on startup rather than happening
when the first connection is attempted.
Change-Id: I2cb5bf774345e94b7092a7da47742a657081397d
Signed-off-by: James Kuszmaul <jabukuszmaul@gmail.com>
diff --git a/third_party/rawrtc/rawrtc/src/diffie_hellman_parameters/parameters.c b/third_party/rawrtc/rawrtc/src/diffie_hellman_parameters/parameters.c
index 7783e59..952511f 100644
--- a/third_party/rawrtc/rawrtc/src/diffie_hellman_parameters/parameters.c
+++ b/third_party/rawrtc/rawrtc/src/diffie_hellman_parameters/parameters.c
@@ -20,6 +20,12 @@
struct ssl_ctx_st* const ssl_context, // not checked
DH const* const dh // not checked
) {
+
+ // Running DH_check on the roborio is obnoxious expensive (~40-50 seconds,
+ // optimized); just YOLO it. Note that this could probably be moved to
+ // somewhere where the cost could be incurred at startup instead of
+ // on connection (or even cached at build-time).
+#ifndef AOS_ARCHITECTURE_arm_frc
int codes;
// Check that the parameters are "likely enough to be valid"
@@ -70,6 +76,9 @@
#endif
return RAWRTC_CODE_INVALID_ARGUMENT;
}
+#else
+ dbg_warning("Skipping DH_check() due to performance concerns.\n");
+#endif
// Apply Diffie-Hellman parameters
if (!SSL_CTX_set_tmp_dh(ssl_context, dh)) {