commit b5c6f97ea5ceefb4d32abe053247d727a7329593
author Austin Schuh <austin.linux@gmail.com> Sun Mar 14 21:53:07 2021 -0700
committer Austin Schuh <austin.linux@gmail.com> Mon Mar 15 13:07:05 2021 -0700
tree 11f42dfdcd431b1215c801f50fdb63de0317c4e7
parent f068dca23592cfa989d3bf405861a31ad284f9e7

Use overloading instead of default values

As we are getting ready to add the send boot UUID everywhere, that will
require a UUID as an argument to all the Send methods with a default
that is event_loop_->boot_uuid().  That doesn't work.  Instead, use
overloading to achieve the same purpose.

There are few call sites for all of these, so it isn't hard to change
them all.

Change-Id: Id1e17bbef2e63c72fa6ad2b038c69d452610e86e

aos/ipc_lib/lockless_queue.cc

diff --git a/aos/ipc_lib/lockless_queue.cc b/aos/ipc_lib/lockless_queue.cc
index 2b704ef..a0c68cb 100644
--- a/aos/ipc_lib/lockless_queue.cc
+++ b/aos/ipc_lib/lockless_queue.cc
@@ -906,29 +906,27 @@
 
 bool LocklessQueueSender::Send(
     const char *data, size_t length,
-    aos::monotonic_clock::time_point monotonic_remote_time,
-    aos::realtime_clock::time_point realtime_remote_time,
+    monotonic_clock::time_point monotonic_remote_time,
+    realtime_clock::time_point realtime_remote_time,
     uint32_t remote_queue_index,
-    aos::monotonic_clock::time_point *monotonic_sent_time,
-    aos::realtime_clock::time_point *realtime_sent_time,
-    uint32_t *queue_index) {
+    monotonic_clock::time_point *monotonic_sent_time,
+    realtime_clock::time_point *realtime_sent_time, uint32_t *queue_index) {
   CHECK_LE(length, size());
   // Flatbuffers write from the back of the buffer to the front.  If we are
   // going to write an explicit chunk of memory into the buffer, we need to
   // adhere to this convention and place it at the end.
   memcpy((reinterpret_cast<char *>(Data()) + size() - length), data, length);
   return Send(length, monotonic_remote_time, realtime_remote_time,
-              remote_queue_index, monotonic_sent_time, realtime_sent_time,
-              queue_index);
+              remote_queue_index, monotonic_sent_time,
+              realtime_sent_time, queue_index);
 }
 
 bool LocklessQueueSender::Send(
-    size_t length, aos::monotonic_clock::time_point monotonic_remote_time,
-    aos::realtime_clock::time_point realtime_remote_time,
+    size_t length, monotonic_clock::time_point monotonic_remote_time,
+    realtime_clock::time_point realtime_remote_time,
     uint32_t remote_queue_index,
-    aos::monotonic_clock::time_point *monotonic_sent_time,
-    aos::realtime_clock::time_point *realtime_sent_time,
-    uint32_t *queue_index) {
+    monotonic_clock::time_point *monotonic_sent_time,
+    realtime_clock::time_point *realtime_sent_time, uint32_t *queue_index) {
   const size_t queue_size = memory_->queue_size();
   CHECK_LE(length, size());
 
@@ -1207,11 +1205,12 @@
 
 LocklessQueueReader::Result LocklessQueueReader::Read(
     uint32_t uint32_queue_index,
-    ::aos::monotonic_clock::time_point *monotonic_sent_time,
-    ::aos::realtime_clock::time_point *realtime_sent_time,
-    ::aos::monotonic_clock::time_point *monotonic_remote_time,
-    ::aos::realtime_clock::time_point *realtime_remote_time,
-    uint32_t *remote_queue_index, size_t *length, char *data) const {
+    monotonic_clock::time_point *monotonic_sent_time,
+    realtime_clock::time_point *realtime_sent_time,
+    monotonic_clock::time_point *monotonic_remote_time,
+    realtime_clock::time_point *realtime_remote_time,
+    uint32_t *remote_queue_index, size_t *length,
+    char *data) const {
   const size_t queue_size = memory_->queue_size();
 
   // Build up the QueueIndex.