commit b5224ec4b9aeae1ef2ffa55a9e3b2af985fceddb
author Austin Schuh <austin.schuh@bluerivertech.com> Wed Mar 27 15:20:09 2024 -0700
committer Austin Schuh <austin.linux@gmail.com> Sat May 11 14:59:28 2024 -0700
tree ffcbdd6be8fd31fb877cfe20ce5b356863061d6a
parent 8707d3442f7359465161f8838b2f4667402689ae

Log, replay, and solve with transmit timestamps

Now that we have our fancy new transmit timestamps, we can use them to
solve our original ambiguous replay problem.  Add them to the logfile
header, read them back, and use them in all the sorting code.  We also
want to test the contents carefully to make sure that they get logged
correctly.

Change-Id: I8a284a9d70fab406bf69efd7ca7f7ab4e213a861
Signed-off-by: James Kuszmaul <james.kuszmaul@bluerivertech.com>

aos/events/logging/logfile_utils_test.cc

diff --git a/aos/events/logging/logfile_utils_test.cc b/aos/events/logging/logfile_utils_test.cc
index cba74ed..0c1cafd 100644
--- a/aos/events/logging/logfile_utils_test.cc
+++ b/aos/events/logging/logfile_utils_test.cc
@@ -3070,6 +3070,10 @@
         aos::realtime_clock::epoch() +
         chrono::nanoseconds(time_distribution(random_number_generator_));
 
+    context.monotonic_remote_transmit_time =
+        aos::monotonic_clock::epoch() +
+        chrono::nanoseconds(time_distribution(random_number_generator_));
+
     context.queue_index = uint32_distribution(random_number_generator_);
     context.remote_queue_index = uint32_distribution(random_number_generator_);
     context.size = data_.size();
@@ -3109,6 +3113,9 @@
     builder.add_remote_queue_index(
         uint8_distribution(random_number_generator_));
 
+    builder.add_monotonic_remote_transmit_time(
+        time_distribution(random_number_generator_));
+
     fbb.FinishSizePrefixed(builder.Finish());
     return fbb.Release();
   }
@@ -3282,11 +3289,18 @@
           repacked_message.size(),
           PackMessageInline(repacked_message.data(), context, channel_index,
                             type, 0u, repacked_message.size()));
-      EXPECT_EQ(absl::Span<uint8_t>(repacked_message),
+      for (size_t i = 0; i < fbb.GetBufferSpan().size(); ++i) {
+        ASSERT_EQ(absl::Span<uint8_t>(repacked_message)[i],
+                  absl::Span<uint8_t>(fbb.GetBufferSpan().data(),
+                                      fbb.GetBufferSpan().size())[i])
+            << ": On index " << i;
+      }
+      ASSERT_EQ(absl::Span<uint8_t>(repacked_message),
                 absl::Span<uint8_t>(fbb.GetBufferSpan().data(),
                                     fbb.GetBufferSpan().size()))
           << AnnotateBinaries(schema, "aos/events/logging/logger.bfbs",
-                              fbb.GetBufferSpan());
+                              fbb.GetBufferSpan())
+          << " for log type " << static_cast<int>(type);
 
       // Ok, now we want to confirm that we can build up arbitrary pieces of
       // said flatbuffer.  Try all of them since it is cheap.