Add TODO on queueing in log_reader
We currently queue until the end when we find a problem. This explodes
memory usage. Document that as a future improvement.
Change-Id: Ib93ffeb8228d433e189008ee8b66c6af02584102
Signed-off-by: Austin Schuh <austin.linux@gmail.com>
diff --git a/aos/events/logging/log_reader.cc b/aos/events/logging/log_reader.cc
index a1269e1..5fe61cd 100644
--- a/aos/events/logging/log_reader.cc
+++ b/aos/events/logging/log_reader.cc
@@ -825,6 +825,9 @@
// all. Read the rest of the messages and drop them on the floor while
// doing some basic validation.
while (state->OldestMessageTime() != BootTimestamp::max_time()) {
+ // TODO(austin): This force queues up the rest of the log file for all
+ // the other nodes. We should do this through the timer instead to
+ // keep memory usage down.
TimestampedMessage next = state->PopOldest();
// Make sure that once we have seen the last message on a channel,
// data doesn't start back up again. If the user wants to play