Rename timer `Setup` function to `Schedule`
This patch was motivated by my desire to fix a typo in the function
name. The noun "setup" is 1 word. The verb "set up" is 2 words. All
other member functions are verbs, so this one should be a verb too.
That means that the function should be called `SetUp`. During the
discussion that resulted from the rename, James Kuszmaul pointed out
that "setting up" a timer can be confusing. It implies that you can
only "set up" a timer once. But the intent is to let users set up
timers as many times as they like. So we decided on renaming the
function to `Schedule`. That conveys the purpose and intent better.
I took this opportunity to fix some other typos involving the verb
"set up".
Signed-off-by: Philipp Schrader <philipp.schrader@gmail.com>
Change-Id: I2f557d1f946960af82711f248820d5e2d385a5d3
diff --git a/y2022/vision/camera_reader.cc b/y2022/vision/camera_reader.cc
index ba7abaf..012a2db 100644
--- a/y2022/vision/camera_reader.cc
+++ b/y2022/vision/camera_reader.cc
@@ -197,8 +197,8 @@
}
// If we are not reading from the disk, we read the live camera stream.
if (!reader_->ReadLatestImage()) {
- read_image_timer_->Setup(event_loop_->monotonic_now() +
- std::chrono::milliseconds(10));
+ read_image_timer_->Schedule(event_loop_->monotonic_now() +
+ std::chrono::milliseconds(10));
return;
}
@@ -212,7 +212,7 @@
ProcessImage(image_mat, image.monotonic_timestamp_ns());
reader_->SendLatestImage();
- read_image_timer_->Setup(event_loop_->monotonic_now());
+ read_image_timer_->Schedule(event_loop_->monotonic_now());
// Disable the LEDs based on localizer output
if (localizer_output_fetcher_.Fetch()) {