Rename timer `Setup` function to `Schedule`
This patch was motivated by my desire to fix a typo in the function
name. The noun "setup" is 1 word. The verb "set up" is 2 words. All
other member functions are verbs, so this one should be a verb too.
That means that the function should be called `SetUp`. During the
discussion that resulted from the rename, James Kuszmaul pointed out
that "setting up" a timer can be confusing. It implies that you can
only "set up" a timer once. But the intent is to let users set up
timers as many times as they like. So we decided on renaming the
function to `Schedule`. That conveys the purpose and intent better.
I took this opportunity to fix some other typos involving the verb
"set up".
Signed-off-by: Philipp Schrader <philipp.schrader@gmail.com>
Change-Id: I2f557d1f946960af82711f248820d5e2d385a5d3
diff --git a/y2020/control_loops/drivetrain/localizer_test.cc b/y2020/control_loops/drivetrain/localizer_test.cc
index bb85921..3e2cf6b 100644
--- a/y2020/control_loops/drivetrain/localizer_test.cc
+++ b/y2020/control_loops/drivetrain/localizer_test.cc
@@ -603,7 +603,7 @@
event_loop_factory()->set_network_delay(std::chrono::nanoseconds(1));
test_event_loop_
->AddTimer([this]() { drivetrain_plant_.set_send_messages(false); })
- ->Setup(test_event_loop_->monotonic_now());
+ ->Schedule(test_event_loop_->monotonic_now());
test_event_loop_->AddPhasedLoop(
[this](int) {
auto builder = camera_sender_.MakeBuilder();
@@ -617,7 +617,7 @@
drivetrain_plant_.set_send_messages(true);
SimulateSensorReset();
})
- ->Setup(test_event_loop_->monotonic_now() + std::chrono::seconds(10));
+ ->Schedule(test_event_loop_->monotonic_now() + std::chrono::seconds(10));
RunFor(chrono::seconds(20));
}