Rename timer `Setup` function to `Schedule`
This patch was motivated by my desire to fix a typo in the function
name. The noun "setup" is 1 word. The verb "set up" is 2 words. All
other member functions are verbs, so this one should be a verb too.
That means that the function should be called `SetUp`. During the
discussion that resulted from the rename, James Kuszmaul pointed out
that "setting up" a timer can be confusing. It implies that you can
only "set up" a timer once. But the intent is to let users set up
timers as many times as they like. So we decided on renaming the
function to `Schedule`. That conveys the purpose and intent better.
I took this opportunity to fix some other typos involving the verb
"set up".
Signed-off-by: Philipp Schrader <philipp.schrader@gmail.com>
Change-Id: I2f557d1f946960af82711f248820d5e2d385a5d3
diff --git a/aos/starter/subprocess_test.cc b/aos/starter/subprocess_test.cc
index d7f8be4..3633d1f 100644
--- a/aos/starter/subprocess_test.cc
+++ b/aos/starter/subprocess_test.cc
@@ -47,8 +47,8 @@
event_loop.OnRun([&event_loop, exit_timer]() {
// Note: we are using the backup poll in this test to capture SIGCHLD. This
// runs at 1 hz, so make sure we let it run at least once.
- exit_timer->Setup(event_loop.monotonic_now() +
- std::chrono::milliseconds(1500));
+ exit_timer->Schedule(event_loop.monotonic_now() +
+ std::chrono::milliseconds(1500));
});
event_loop.Run();
@@ -90,7 +90,7 @@
// Note: we are using the backup poll in this test to capture SIGCHLD. This
// runs at 1 hz, so make sure we let it run at least once.
event_loop.AddTimer([&event_loop]() { event_loop.Exit(); })
- ->Setup(event_loop.monotonic_now() + std::chrono::milliseconds(1500));
+ ->Schedule(event_loop.monotonic_now() + std::chrono::milliseconds(1500));
event_loop.Run();