Rename timer `Setup` function to `Schedule`
This patch was motivated by my desire to fix a typo in the function
name. The noun "setup" is 1 word. The verb "set up" is 2 words. All
other member functions are verbs, so this one should be a verb too.
That means that the function should be called `SetUp`. During the
discussion that resulted from the rename, James Kuszmaul pointed out
that "setting up" a timer can be confusing. It implies that you can
only "set up" a timer once. But the intent is to let users set up
timers as many times as they like. So we decided on renaming the
function to `Schedule`. That conveys the purpose and intent better.
I took this opportunity to fix some other typos involving the verb
"set up".
Signed-off-by: Philipp Schrader <philipp.schrader@gmail.com>
Change-Id: I2f557d1f946960af82711f248820d5e2d385a5d3
diff --git a/aos/starter/starterd_lib.cc b/aos/starter/starterd_lib.cc
index 949c8a7..7c94863 100644
--- a/aos/starter/starterd_lib.cc
+++ b/aos/starter/starterd_lib.cc
@@ -50,8 +50,8 @@
event_loop_.SkipAosLog();
event_loop_.OnRun([this] {
- status_timer_->Setup(event_loop_.monotonic_now(),
- std::chrono::milliseconds(1000));
+ status_timer_->Schedule(event_loop_.monotonic_now(),
+ std::chrono::milliseconds(1000));
});
if (!aos::configuration::MultiNode(config_msg_)) {
@@ -172,8 +172,8 @@
for (auto &application : applications_) {
application.second.Terminate();
}
- cleanup_timer_->Setup(event_loop_.monotonic_now() +
- std::chrono::milliseconds(1500));
+ cleanup_timer_->Schedule(event_loop_.monotonic_now() +
+ std::chrono::milliseconds(1500));
}
void Starter::OnSignal(signalfd_siginfo info) {