Buildify the world
Change-Id: I41c06a3f567bc45d401386cc32d9c40cb6ed95d8
diff --git a/aos/logging/BUILD b/aos/logging/BUILD
index 214df63..68a493b 100644
--- a/aos/logging/BUILD
+++ b/aos/logging/BUILD
@@ -156,6 +156,6 @@
flatbuffer_cc_library(
name = "log_message_fbs",
srcs = ["log_message.fbs"],
- visibility = ["//visibility:public"],
gen_reflections = 1,
+ visibility = ["//visibility:public"],
)
diff --git a/aos/network/www/BUILD b/aos/network/www/BUILD
index bab5198..67e54f8 100644
--- a/aos/network/www/BUILD
+++ b/aos/network/www/BUILD
@@ -7,7 +7,7 @@
"**/*.html",
"**/*.css",
]),
- visibility=["//visibility:public"],
+ visibility = ["//visibility:public"],
)
ts_library(
@@ -16,12 +16,12 @@
"config_handler.ts",
"proxy.ts",
],
+ visibility = ["//visibility:public"],
deps = [
- "//aos/network:web_proxy_ts_fbs",
- "//aos/network:connect_ts_fbs",
"//aos:configuration_ts_fbs",
+ "//aos/network:connect_ts_fbs",
+ "//aos/network:web_proxy_ts_fbs",
],
- visibility=["//visibility:public"],
)
ts_library(
@@ -39,10 +39,10 @@
rollup_bundle(
name = "main_bundle",
entry_point = "aos/network/www/main",
+ visibility = ["//aos:__subpackages__"],
deps = [
"main",
],
- visibility=["//aos:__subpackages__"],
)
genrule(
@@ -54,5 +54,5 @@
"flatbuffers.js",
],
cmd = "cp $(location @com_github_google_flatbuffers//:flatjs) $@",
- visibility=["//aos:__subpackages__"],
+ visibility = ["//aos:__subpackages__"],
)
diff --git a/aos/testing/BUILD b/aos/testing/BUILD
index 9aa058d..8693f27 100644
--- a/aos/testing/BUILD
+++ b/aos/testing/BUILD
@@ -24,9 +24,9 @@
visibility = ["//visibility:public"],
deps = [
":googletest",
- "@com_google_absl//absl/base",
"//aos/logging:implementations",
"//aos/mutex",
+ "@com_google_absl//absl/base",
],
)
diff --git a/debian/webrtc.BUILD b/debian/webrtc.BUILD
index e90e268..23e029d 100644
--- a/debian/webrtc.BUILD
+++ b/debian/webrtc.BUILD
@@ -2,17 +2,17 @@
cc_library(
name = "webrtc",
- visibility = ["//visibility:public"],
- hdrs = glob(["include/**/*.h"]),
srcs = cpu_select({
"arm": ["lib/arm/Release/libwebrtc_full.a"],
"else": ["lib/x64/Release/libwebrtc_full.a"],
}),
+ hdrs = glob(["include/**/*.h"]),
includes = ["include"],
+ visibility = ["//visibility:public"],
deps = [
+ "@com_google_absl//absl/algorithm:container",
"@com_google_absl//absl/strings",
"@com_google_absl//absl/types:optional",
"@com_google_absl//absl/types:variant",
- "@com_google_absl//absl/algorithm:container",
],
)
diff --git a/frc971/control_loops/python/BUILD b/frc971/control_loops/python/BUILD
index 1fae02b..7953474 100644
--- a/frc971/control_loops/python/BUILD
+++ b/frc971/control_loops/python/BUILD
@@ -167,22 +167,22 @@
name = "spline_graph",
srcs = [
"color.py",
- "spline_drawing.py",
- "spline_writer.py",
+ "graph.py",
"path_edit.py",
"points.py",
- "graph.py",
+ "spline_drawing.py",
"spline_graph.py",
+ "spline_writer.py",
],
legacy_create_init = False,
restricted_to = ["//tools:k8"],
visibility = ["//visibility:public"],
deps = [
+ ":basic_window",
":libspline",
":python_init",
- "@python_gtk",
"@matplotlib_repo//:matplotlib2.7",
- ":basic_window",
+ "@python_gtk",
],
)
diff --git a/third_party/BUILD b/third_party/BUILD
index 13f015e..fd10d43 100644
--- a/third_party/BUILD
+++ b/third_party/BUILD
@@ -99,4 +99,3 @@
"roborio": ["@webrtc_rio//:webrtc"],
}),
)
-
diff --git a/third_party/flatbuffers/build_defs.bzl b/third_party/flatbuffers/build_defs.bzl
index 6ac1d87..f4c1dc7 100644
--- a/third_party/flatbuffers/build_defs.bzl
+++ b/third_party/flatbuffers/build_defs.bzl
@@ -282,7 +282,7 @@
been parsed. As such, we just force the user to manually specify
things.
"""
- python_files = ["%s/%s.py" % (namespace.replace('.', '/'), table) for table in tables]
+ python_files = ["%s/%s.py" % (namespace.replace(".", "/"), table) for table in tables]
srcs_lib = "%s_srcs" % (name)
flatbuffer_library_public(
diff --git a/third_party/gperftools/BUILD b/third_party/gperftools/BUILD
index 25a8740..7f5e9d6 100644
--- a/third_party/gperftools/BUILD
+++ b/third_party/gperftools/BUILD
@@ -86,7 +86,7 @@
"-DPERFTOOLS_DLL_DECL=",
"-DSTDC_HEADERS=1",
"-DSTL_NAMESPACE=std",
- "-DPACKAGE_STRING=\\\"gperftools\ 2.4\\\"",
+ "-DPACKAGE_STRING=\\\"gperftools\\ 2.4\\\"",
"-DPACKAGE_BUGREPORT=\\\"http://www.frc971.org/contact\\\"",
"-DPACKAGE_VERSION=\\\"2.4\\\"",
] + cpu_select({
@@ -141,7 +141,7 @@
"-lrt",
"-lpthread",
],
- nocopts = "-std=gnu\+\+1y",
+ nocopts = "-std=gnu\\+\\+1y",
visibility = ["//visibility:public"],
deps = [
"//third_party/empty_config_h",
diff --git a/third_party/libevent/BUILD b/third_party/libevent/BUILD
index da05f3c..347ec0b 100644
--- a/third_party/libevent/BUILD
+++ b/third_party/libevent/BUILD
@@ -148,7 +148,7 @@
"_EVENT_STDC_HEADERS=1",
"_EVENT_TIME_WITH_SYS_TIME=1",
"_EVENT_NUMERIC_VERSION=0x02001600",
- '_EVENT_VERSION=\\"2.0.22-stable\\"',
+ "_EVENT_VERSION=\\\"2.0.22-stable\\\"",
] + address_size_select({
"32": [
"_EVENT_SIZEOF_LONG_LONG=4",
diff --git a/y2020/control_loops/python/BUILD b/y2020/control_loops/python/BUILD
index 923d239..e218571 100644
--- a/y2020/control_loops/python/BUILD
+++ b/y2020/control_loops/python/BUILD
@@ -133,8 +133,8 @@
legacy_create_init = False,
restricted_to = ["//tools:k8"],
deps = [
- ":python_init",
":flywheel",
+ ":python_init",
"//external:python-gflags",
"//external:python-glog",
],
@@ -148,8 +148,8 @@
legacy_create_init = False,
restricted_to = ["//tools:k8"],
deps = [
- ":python_init",
":flywheel",
+ ":python_init",
"//external:python-gflags",
"//external:python-glog",
],
diff --git a/y2020/vision/BUILD b/y2020/vision/BUILD
index 6850a27..60276c9 100644
--- a/y2020/vision/BUILD
+++ b/y2020/vision/BUILD
@@ -16,6 +16,7 @@
hdrs = [
"v4l2_reader.h",
],
+ visibility = ["//y2020:__subpackages__"],
deps = [
":vision_fbs",
"//aos/events:event_loop",
@@ -23,7 +24,6 @@
"@com_github_google_glog//:glog",
"@com_google_absl//absl/base",
],
- visibility = ["//y2020:__subpackages__"],
)
cc_binary(
@@ -35,6 +35,7 @@
"//tools:k8",
"//tools:armhf-debian",
],
+ visibility = ["//y2020:__subpackages__"],
deps = [
":v4l2_reader",
":vision_fbs",
@@ -43,12 +44,11 @@
"//aos/events:shm_event_loop",
"//aos/network:team_number",
"//third_party:opencv",
- "//y2020/vision/tools/python_code:sift_training_data",
"//y2020/vision/sift:sift971",
"//y2020/vision/sift:sift_fbs",
"//y2020/vision/sift:sift_training_fbs",
+ "//y2020/vision/tools/python_code:sift_training_data",
],
- visibility = ["//y2020:__subpackages__"],
)
flatbuffer_ts_library(
diff --git a/y2020/vision/sift/fast_gaussian.bzl b/y2020/vision/sift/fast_gaussian.bzl
index a1c3173..0905423 100644
--- a/y2020/vision/sift/fast_gaussian.bzl
+++ b/y2020/vision/sift/fast_gaussian.bzl
@@ -1,55 +1,55 @@
def fast_gaussian(sigmas, sizes):
- files = []
- for _, sigma_name, _ in sigmas:
+ files = []
+ for _, sigma_name, _ in sigmas:
+ for cols, rows in sizes:
+ files.append("fast_gaussian_%dx%d_%s" % (cols, rows, sigma_name))
+ for _, sigma_name, _ in sigmas:
+ for cols, rows in sizes:
+ files.append("fast_gaussian_subtract_%dx%d_%s" % (cols, rows, sigma_name))
for cols, rows in sizes:
- files.append("fast_gaussian_%dx%d_%s" % (cols, rows, sigma_name))
- for _, sigma_name, _ in sigmas:
- for cols, rows in sizes:
- files.append("fast_gaussian_subtract_%dx%d_%s" % (cols, rows, sigma_name))
- for cols, rows in sizes:
- files.append('fast_subtract_%dx%d' % (cols, rows))
+ files.append("fast_subtract_%dx%d" % (cols, rows))
- params = struct(
- sigmas = sigmas,
- sizes = sizes,
- )
+ params = struct(
+ sigmas = sigmas,
+ sizes = sizes,
+ )
- headers = [f + '.h' for f in files] + [
- 'fast_gaussian_all.h',
- ]
- objects = [f + '.o' for f in files] + [
- 'fast_gaussian_runtime.o',
- ]
- htmls = [f + '.html' for f in files]
+ headers = [f + ".h" for f in files] + [
+ "fast_gaussian_all.h",
+ ]
+ objects = [f + ".o" for f in files] + [
+ "fast_gaussian_runtime.o",
+ ]
+ htmls = [f + ".html" for f in files]
- native.genrule(
- name = "generate_fast_gaussian",
- tools = [
- ":fast_gaussian_runner",
- ],
- cmd = ' '.join([
- '$(location fast_gaussian_runner)',
- "'" + params.to_json() + "'",
- # TODO(Brian): This should be RULEDIR once we have support for that.
- '$(@D)',
- '$(TARGET_CPU)',
- ]),
- outs = headers + objects + htmls,
- restricted_to = [
- "//tools:k8",
- "//tools:armhf-debian",
- ],
- )
+ native.genrule(
+ name = "generate_fast_gaussian",
+ tools = [
+ ":fast_gaussian_runner",
+ ],
+ cmd = " ".join([
+ "$(location fast_gaussian_runner)",
+ "'" + params.to_json() + "'",
+ # TODO(Brian): This should be RULEDIR once we have support for that.
+ "$(@D)",
+ "$(TARGET_CPU)",
+ ]),
+ outs = headers + objects + htmls,
+ restricted_to = [
+ "//tools:k8",
+ "//tools:armhf-debian",
+ ],
+ )
- native.cc_library(
- name = 'fast_gaussian_all',
- hdrs = ['fast_gaussian_all.h'],
- srcs = headers + objects,
- deps = [
- '//third_party:halide_runtime',
- ],
- restricted_to = [
- "//tools:k8",
- "//tools:armhf-debian",
- ],
- )
+ native.cc_library(
+ name = "fast_gaussian_all",
+ hdrs = ["fast_gaussian_all.h"],
+ srcs = headers + objects,
+ deps = [
+ "//third_party:halide_runtime",
+ ],
+ restricted_to = [
+ "//tools:k8",
+ "//tools:armhf-debian",
+ ],
+ )
diff --git a/y2020/vision/tools/python_code/BUILD b/y2020/vision/tools/python_code/BUILD
index a130ed6..8bbb5c8 100644
--- a/y2020/vision/tools/python_code/BUILD
+++ b/y2020/vision/tools/python_code/BUILD
@@ -22,10 +22,10 @@
default_python_version = "PY3",
srcs_version = "PY2AND3",
deps = [
+ "//external:python-glog",
"//y2020/vision/sift:sift_fbs_python",
"@bazel_tools//tools/python/runfiles",
"@opencv_contrib_nonfree_amd64//:python_opencv",
- "//external:python-glog",
],
)
@@ -71,10 +71,10 @@
main = "load_sift_training.py",
srcs_version = "PY2AND3",
deps = [
+ "//external:python-glog",
"//y2020/vision/sift:sift_fbs_python",
"@bazel_tools//tools/python/runfiles",
"@opencv_contrib_nonfree_amd64//:python_opencv",
- "//external:python-glog",
],
)
diff --git a/y2020/www/BUILD b/y2020/www/BUILD
index c0daa07..c280e91 100644
--- a/y2020/www/BUILD
+++ b/y2020/www/BUILD
@@ -4,24 +4,24 @@
ts_library(
name = "main",
srcs = [
- "main.ts",
"image_handler.ts",
+ "main.ts",
],
+ visibility = ["//y2020:__subpackages__"],
deps = [
"//aos/network/www:proxy",
"//y2020/vision:vision_ts_fbs",
"//y2020/vision/sift:sift_ts_fbs",
],
- visibility = ["//y2020:__subpackages__"],
)
rollup_bundle(
name = "main_bundle",
entry_point = "y2020/www/main",
+ visibility = ["//y2020:__subpackages__"],
deps = [
"main",
],
- visibility = ["//y2020:__subpackages__"],
)
filegroup(
@@ -30,7 +30,7 @@
"**/*.html",
"**/*.css",
]),
- visibility=["//visibility:public"],
+ visibility = ["//visibility:public"],
)
genrule(
@@ -42,5 +42,5 @@
"flatbuffers.js",
],
cmd = "cp $(location @com_github_google_flatbuffers//:flatjs) $@",
- visibility=["//y2020:__subpackages__"],
+ visibility = ["//y2020:__subpackages__"],
)