commit 9896c7544c62b755785bd4b1e54d54541af65188
author Sanjay Narayanan <sanjay.narayanan@bluerivertech.com> Wed Sep 01 16:16:48 2021 -0700
committer Sanjay Narayanan <sanjay.narayanan@bluerivertech.com> Mon Sep 13 15:57:00 2021 -0700
tree 6f8505fc2c7f8dd41971c7cd5b43b8e6beaf0c0a
parent 25873e09980c12e5034ebf10f11d69fb16691420

Fix logic to find log start time

For any node, we were considering candidate start times that were set to
min_time due to lack of context. These are just invalid. Let's ignore
them so we can pick a meaningful start time.

Change-Id: I3e9d956b1402062846676e097b1aa5f46ea4dc44
Signed-off-by: Sanjay Narayanan <sanjay.narayanan@bluerivertech.com>

aos/events/logging/logfile_utils.cc

diff --git a/aos/events/logging/logfile_utils.cc b/aos/events/logging/logfile_utils.cc
index 6d73d67..8a10876 100644
--- a/aos/events/logging/logfile_utils.cc
+++ b/aos/events/logging/logfile_utils.cc
@@ -796,11 +796,21 @@
   monotonic_start_time_ = monotonic_clock::max_time;
   realtime_start_time_ = realtime_clock::max_time;
   for (const LogPartsSorter &parts_sorter : parts_sorters_) {
-    if (parts_sorter.monotonic_start_time() < monotonic_start_time_) {
+    // We want to capture the earliest meaningful start time here. The start
+    // time defaults to min_time when there's no meaningful value to report, so
+    // let's ignore those.
+    if (parts_sorter.monotonic_start_time() != monotonic_clock::min_time &&
+        parts_sorter.monotonic_start_time() < monotonic_start_time_) {
       monotonic_start_time_ = parts_sorter.monotonic_start_time();
       realtime_start_time_ = parts_sorter.realtime_start_time();
     }
   }
+
+  // If there was no meaningful start time reported, just use min_time.
+  if (monotonic_start_time_ == monotonic_clock::max_time) {
+    monotonic_start_time_ = monotonic_clock::min_time;
+    realtime_start_time_ = realtime_clock::min_time;
+  }
 }
 
 std::vector<const LogParts *> NodeMerger::Parts() const {
@@ -1150,7 +1160,7 @@
   CHECK(message.data.message().has_remote_queue_index());
   const BootQueueIndex remote_queue_index =
       BootQueueIndex{.boot = message.monotonic_remote_boot,
-                    .index = message.data.message().remote_queue_index()};
+                     .index = message.data.message().remote_queue_index()};
 
   CHECK(message.data.message().has_monotonic_remote_time());
   CHECK(message.data.message().has_realtime_remote_time());