Make Debug() respect --bounds_offset_error
This makes it so we can provide a magic set of flags to solve any
problem, even if the solution is invalid, to get a sense of what is
happening to triage further.
Change-Id: I52a6f6295872cdbdb4da4581ab89c2fa6dbd74cf
Signed-off-by: Austin Schuh <austin.linux@gmail.com>
diff --git a/aos/network/multinode_timestamp_filter.cc b/aos/network/multinode_timestamp_filter.cc
index 8c48fa1..32d345a 100644
--- a/aos/network/multinode_timestamp_filter.cc
+++ b/aos/network/multinode_timestamp_filter.cc
@@ -1306,16 +1306,29 @@
// hitting this anymore. I'm also likely the one who will be debugging
// it next and would rather spend the time debugging it when I get a bug
// report.
- gradients[i].emplace_back(
- std::string("- ") +
- filter.filter->DebugOffsetError(
- filter.b_filter, NoncausalTimestampFilter::Pointer(),
- base_clock_[i], 0.0, base_clock_[filter.b_index], 0.0, i,
- filter.b_index));
- gradients[filter.b_index].emplace_back(filter.filter->DebugOffsetError(
- filter.b_filter, NoncausalTimestampFilter::Pointer(),
- base_clock_[i], 0.0, base_clock_[filter.b_index], 0.0, i,
- filter.b_index));
+ if (FLAGS_bounds_offset_error) {
+ gradients[i].emplace_back(
+ std::string("- ") +
+ filter.filter->DebugOffsetError(
+ nullptr, NoncausalTimestampFilter::Pointer(), base_clock_[i],
+ 0.0, base_clock_[filter.b_index], 0.0, i, filter.b_index));
+ gradients[filter.b_index].emplace_back(
+ filter.filter->DebugOffsetError(
+ nullptr, NoncausalTimestampFilter::Pointer(), base_clock_[i],
+ 0.0, base_clock_[filter.b_index], 0.0, i, filter.b_index));
+ } else {
+ gradients[i].emplace_back(
+ std::string("- ") +
+ filter.filter->DebugOffsetError(
+ filter.b_filter, NoncausalTimestampFilter::Pointer(),
+ base_clock_[i], 0.0, base_clock_[filter.b_index], 0.0, i,
+ filter.b_index));
+ gradients[filter.b_index].emplace_back(
+ filter.filter->DebugOffsetError(
+ filter.b_filter, NoncausalTimestampFilter::Pointer(),
+ base_clock_[i], 0.0, base_clock_[filter.b_index], 0.0, i,
+ filter.b_index));
+ }
}
}
}