Buildify some hand-written BUILD files
We currently exclude third_party BUILD files from buildifier, but some
of these are hand-written and so can be reasonably formatted.
Also, fixes a random flatbuffers BUILD file that I believe had randomly
diverged from upstream for some reason.
Change-Id: I03141e25556f52b7b80b46c700f570689cc38a1f
Signed-off-by: James Kuszmaul <james.kuszmaul@bluerivertech.com>
diff --git a/third_party/flatbuffers/tests/ts/test_dir/BUILD.bazel b/third_party/flatbuffers/tests/ts/test_dir/BUILD.bazel
index 768fe83..8b0acca 100644
--- a/third_party/flatbuffers/tests/ts/test_dir/BUILD.bazel
+++ b/third_party/flatbuffers/tests/ts/test_dir/BUILD.bazel
@@ -10,5 +10,5 @@
name = "include_ts_fbs",
srcs = ["typescript_include.fbs"],
visibility = ["//visibility:public"],
- deps = [":typescript_transitive_ts_ts_fbs"],
+ deps = [":typescript_transitive_ts_fbs"],
)
diff --git a/third_party/julia/julia.BUILD b/third_party/julia/julia.BUILD
index 94988ca..7f25671 100644
--- a/third_party/julia/julia.BUILD
+++ b/third_party/julia/julia.BUILD
@@ -1,18 +1,21 @@
load("@rules_pkg//:pkg.bzl", "pkg_tar")
-load(":files.bzl", "LIB_SYMLINKS", "LIBS")
+load(":files.bzl", "LIBS", "LIB_SYMLINKS")
pkg_tar(
name = "runtime",
srcs = LIBS + [
"bin/julia",
- ] + glob([
- "share/julia/**/*.jl",
- "share/julia/**/*.toml",
- "include/julia/**/*",
- ], exclude = [
- "**/test/**",
- ]),
- symlinks = LIB_SYMLINKS,
+ ] + glob(
+ [
+ "share/julia/**/*.jl",
+ "share/julia/**/*.toml",
+ "include/julia/**/*",
+ ],
+ exclude = [
+ "**/test/**",
+ ],
+ ),
strip_prefix = "external/julia",
+ symlinks = LIB_SYMLINKS,
visibility = ["//visibility:public"],
)
diff --git a/third_party/python/BUILD b/third_party/python/BUILD
index 46c464c..5e3278a 100644
--- a/third_party/python/BUILD
+++ b/third_party/python/BUILD
@@ -2,10 +2,6 @@
cc_library(
name = "python",
- deps = [
- "@python3_9_x86_64-unknown-linux-gnu//:python_headers",
- "@python3_9_x86_64-unknown-linux-gnu//:libpython",
- ],
defines = [
"FRC971_UPSTREAM_BUNDLED_PYTHON",
"FRC971_PYTHON_HOME=../python3_9_x86_64-unknown-linux-gnu/",
@@ -15,6 +11,10 @@
"@platforms//os:linux",
],
visibility = ["//visibility:public"],
+ deps = [
+ "@python3_9_x86_64-unknown-linux-gnu//:libpython",
+ "@python3_9_x86_64-unknown-linux-gnu//:python_headers",
+ ],
)
filegroup(
@@ -31,8 +31,8 @@
extract_numpy_headers(
name = "numpy_headers",
- numpy = "@pip//numpy",
header_prefix = "numpy_headers",
+ numpy = "@pip//numpy",
visibility = ["//visibility:private"],
)
@@ -44,8 +44,8 @@
includes = [
"numpy_headers",
],
+ visibility = ["//visibility:public"],
deps = [
":python",
],
- visibility = ["//visibility:public"],
)
diff --git a/third_party/vl53l1x/vl53l1x.BUILD b/third_party/vl53l1x/vl53l1x.BUILD
index 13ea7fd..9d7e776 100644
--- a/third_party/vl53l1x/vl53l1x.BUILD
+++ b/third_party/vl53l1x/vl53l1x.BUILD
@@ -1,26 +1,25 @@
-
cc_library(
- name = "VL53L1X",
- srcs = [
- "core/VL53L1X_api.c",
- "core/VL53L1X_calibration.c",
- "platform/vl53l1_platform.c",
- ],
- hdrs = [
- "core/VL53L1X_api.h",
- "core/VL53L1X_calibration.h",
- "platform/vl53l1_platform.h",
- "platform/vl53l1_types.h",
- ],
- target_compatible_with = [
- "@platforms//os:none",
- "@//tools/platforms/hardware:cortex_m0plus",
- ],
- copts = [
- "-Wno-unused-parameter",
- ],
- visibility = ["//visibility:public"],
- deps = [
- "@//third_party/pico-sdk",
- ],
+ name = "VL53L1X",
+ srcs = [
+ "core/VL53L1X_api.c",
+ "core/VL53L1X_calibration.c",
+ "platform/vl53l1_platform.c",
+ ],
+ hdrs = [
+ "core/VL53L1X_api.h",
+ "core/VL53L1X_calibration.h",
+ "platform/vl53l1_platform.h",
+ "platform/vl53l1_types.h",
+ ],
+ copts = [
+ "-Wno-unused-parameter",
+ ],
+ target_compatible_with = [
+ "@platforms//os:none",
+ "@//tools/platforms/hardware:cortex_m0plus",
+ ],
+ visibility = ["//visibility:public"],
+ deps = [
+ "@//third_party/pico-sdk",
+ ],
)
diff --git a/third_party/websocketpp/websocketpp.BUILD b/third_party/websocketpp/websocketpp.BUILD
index ecf12cd..436e47f 100644
--- a/third_party/websocketpp/websocketpp.BUILD
+++ b/third_party/websocketpp/websocketpp.BUILD
@@ -4,7 +4,10 @@
cc_library(
name = "com_github_zaphoyd_websocketpp",
hdrs = glob(["websocketpp/**/*.hpp"]),
- defines = ["_WEBSOCKETPP_CPP11_STL_", "ASIO_STANDALONE"],
+ defines = [
+ "_WEBSOCKETPP_CPP11_STL_",
+ "ASIO_STANDALONE",
+ ],
includes = ["."],
visibility = ["//visibility:public"],
deps = ["@asio"],
diff --git a/third_party/xvfb/xvfb.BUILD b/third_party/xvfb/xvfb.BUILD
index 91332ff..f03e322 100644
--- a/third_party/xvfb/xvfb.BUILD
+++ b/third_party/xvfb/xvfb.BUILD
@@ -31,13 +31,13 @@
sh_binary(
name = "wrapped_bin/Xvfb",
srcs = ["wrapped_bin/Xvfb.sh"],
- deps = [
- "@bazel_tools//tools/bash/runfiles",
- ],
data = glob([
"usr/lib/**/*",
"lib/**/*",
"usr/bin/*",
]),
visibility = ["//visibility:public"],
+ deps = [
+ "@bazel_tools//tools/bash/runfiles",
+ ],
)
diff --git a/third_party/y2023/field/BUILD b/third_party/y2023/field/BUILD
index de1d382..a806293 100644
--- a/third_party/y2023/field/BUILD
+++ b/third_party/y2023/field/BUILD
@@ -1,14 +1,14 @@
filegroup(
name = "pictures",
srcs = [
- # Picture from the FIRST inspires field drawings.
- # https://www.firstinspires.org/robotics/frc/playing-field
- # Copyright 2023 FIRST
- "2023.png",
- # Picture from FIRST modified by Tea Fazio.
- # https://firstfrc.blob.core.windows.net/frc2023/Manual/2023FRCGameManual.pdf
- # Copyright 2023 FIRST
- "field.jpg",
- ],
+ # Picture from the FIRST inspires field drawings.
+ # https://www.firstinspires.org/robotics/frc/playing-field
+ # Copyright 2023 FIRST
+ "2023.png",
+ # Picture from FIRST modified by Tea Fazio.
+ # https://firstfrc.blob.core.windows.net/frc2023/Manual/2023FRCGameManual.pdf
+ # Copyright 2023 FIRST
+ "field.jpg",
+ ],
visibility = ["//visibility:public"],
)
diff --git a/third_party/y2024/field/BUILD b/third_party/y2024/field/BUILD
index 04db591..4b2bbff 100644
--- a/third_party/y2024/field/BUILD
+++ b/third_party/y2024/field/BUILD
@@ -1,11 +1,11 @@
filegroup(
name = "pictures",
srcs = [
- # Picture from the FIRST inspires field drawings.
- "2024.png",
- # https://www.firstinspires.org/robotics/frc/playing-field
- # Copyright 2024 FIRST
- "2024_field.png",
- ],
+ # Picture from the FIRST inspires field drawings.
+ "2024.png",
+ # https://www.firstinspires.org/robotics/frc/playing-field
+ # Copyright 2024 FIRST
+ "2024_field.png",
+ ],
visibility = ["//visibility:public"],
-)
\ No newline at end of file
+)