Maybe fix zero sized messages
We are seeing occasional zero sized
messages. The only place I can guess these are coming from is a
"partial" buffer from the lzma encoder which is actually 0 length. Add
in both more debugging, and code to potentially fix that cause. We'll
want to revert parts of this patch if this proves not to be the issue
(and make it a CHECK).
F20230502 20:28:21.927556 5914 log_backend.cc:65] Check failed: size > 0 (0 vs. 0) : Nobody should be sending empty messages.
Change-Id: I78609e20d086e43f02a67510c6dd1461ab77ecb9
Signed-off-by: Austin Schuh <austin.schuh@bluerivertech.com>
Signed-off-by: James Kuszmaul <james.kuszmaul@bluerivertech.com>
diff --git a/aos/events/logging/log_backend.cc b/aos/events/logging/log_backend.cc
index ad97f7d..30f6181 100644
--- a/aos/events/logging/log_backend.cc
+++ b/aos/events/logging/log_backend.cc
@@ -52,7 +52,9 @@
const absl::Span<const absl::Span<const uint8_t>> &queue) {
aligned_queue_.clear();
+ size_t queue_index = 0;
for (const auto &span : queue) {
+ ++queue_index;
// Generally, every span might have 3 optional parts (i.e. 2^3 cases):
// 1. unaligned prefix - from start till first aligned block.
// 2. aligned main - block with aligned start and size
@@ -65,7 +67,9 @@
VLOG(2) << "Consider span starting at " << std::hex << start
<< " with size " << size;
- CHECK_GT(size, 0u) << ": Nobody should be sending empty messages.";
+ CHECK_GT(size, 0u)
+ << ": Nobody should be sending empty messages. Queue index "
+ << (queue_index - 1) << " out of " << queue.size();
const auto next_aligned =
IsAligned(start) ? start : AlignToLeft(start) + FileHandler::kSector;