commit 6f7f0b3fff0a378113bab806a16b526134255a96
author Filip Kujawa <filip.j.kujawa@gmail.com> Thu Mar 30 13:26:08 2023 -0700
committer Filip Kujawa <filip.j.kujawa@gmail.com> Thu Mar 30 14:33:49 2023 -0700
tree aa8df17c6feee4e43beb18edebb8725885a2ebc4
parent df482e1a426c95c42aa1a9899a39a57bdaa78def

Scouting: Fix sketchy pickup bug

Note scouts were seeing a solid pickup label but the app was submitting
sketchy pickups instead. Strategy team wants to measure solid pickups, this change
fixes the bug so that the solid pickup keyword is actually submitted.

Signed-off-by: Filip Kujawa <filip.j.kujawa@gmail.com>
Change-Id: I7578b4ddb64f176409b0e666e44675239eb25475

scouting/db/db.go

diff --git a/scouting/db/db.go b/scouting/db/db.go
index 3791596..b879cab 100644
--- a/scouting/db/db.go
+++ b/scouting/db/db.go
@@ -102,7 +102,7 @@
 	Notes          string
 	GoodDriving    bool
 	BadDriving     bool
-	SketchyPickup  bool
+	SolidPickup    bool
 	SketchyPlacing bool
 	GoodDefense    bool
 	BadDefense     bool
@@ -412,7 +412,7 @@
 		Notes:          data.Notes,
 		GoodDriving:    data.GoodDriving,
 		BadDriving:     data.BadDriving,
-		SketchyPickup:  data.SketchyPickup,
+		SolidPickup:    data.SolidPickup,
 		SketchyPlacing: data.SketchyPlacing,
 		GoodDefense:    data.GoodDefense,
 		BadDefense:     data.BadDefense,

scouting/db/db_test.go

diff --git a/scouting/db/db_test.go b/scouting/db/db_test.go
index 72c5f86..267cfb9 100644
--- a/scouting/db/db_test.go
+++ b/scouting/db/db_test.go
@@ -1185,11 +1185,11 @@
 
 	expected := []string{"Note 1", "Note 3"}
 
-	err := fixture.db.AddNotes(NotesData{TeamNumber: 1234, Notes: "Note 1", GoodDriving: true, BadDriving: false, SketchyPickup: false, SketchyPlacing: true, GoodDefense: false, BadDefense: true, EasilyDefended: true})
+	err := fixture.db.AddNotes(NotesData{TeamNumber: 1234, Notes: "Note 1", GoodDriving: true, BadDriving: false, SolidPickup: false, SketchyPlacing: true, GoodDefense: false, BadDefense: true, EasilyDefended: true})
 	check(t, err, "Failed to add Note")
-	err = fixture.db.AddNotes(NotesData{TeamNumber: 1235, Notes: "Note 2", GoodDriving: false, BadDriving: true, SketchyPickup: false, SketchyPlacing: true, GoodDefense: false, BadDefense: false, EasilyDefended: false})
+	err = fixture.db.AddNotes(NotesData{TeamNumber: 1235, Notes: "Note 2", GoodDriving: false, BadDriving: true, SolidPickup: false, SketchyPlacing: true, GoodDefense: false, BadDefense: false, EasilyDefended: false})
 	check(t, err, "Failed to add Note")
-	err = fixture.db.AddNotes(NotesData{TeamNumber: 1234, Notes: "Note 3", GoodDriving: true, BadDriving: false, SketchyPickup: false, SketchyPlacing: true, GoodDefense: true, BadDefense: false, EasilyDefended: true})
+	err = fixture.db.AddNotes(NotesData{TeamNumber: 1234, Notes: "Note 3", GoodDriving: true, BadDriving: false, SolidPickup: false, SketchyPlacing: true, GoodDefense: true, BadDefense: false, EasilyDefended: true})
 	check(t, err, "Failed to add Note")
 
 	actual, err := fixture.db.QueryNotes(1234)