Reduce LOG(INFO) spam in logfile validator
In adding the log readability checks, I copied over some LOG(INFO)'s
from the timestamp_extractor; those logs made since when the tool could
just be run manually at the command line, but don't make much sense in
something that can spam journal logs.
This does not remove any of the warnings/errors that occur if there is
an actual readability issue.
Change-Id: I690bf6e39ca1fb2d9f6eaa890404246a78620dc0
Signed-off-by: James Kuszmaul <james.kuszmaul@bluerivertech.com>
diff --git a/aos/events/logging/logfile_validator.cc b/aos/events/logging/logfile_validator.cc
index 19d11c8..05c881c 100644
--- a/aos/events/logging/logfile_validator.cc
+++ b/aos/events/logging/logfile_validator.cc
@@ -37,12 +37,12 @@
multinode_estimator.set_reboot_found(
[config](distributed_clock::time_point reboot_time,
const std::vector<logger::BootTimestamp> &node_times) {
- LOG(INFO) << "Rebooted at distributed " << reboot_time;
+ VLOG(1) << "Rebooted at distributed " << reboot_time;
size_t node_index = 0;
for (const logger::BootTimestamp &time : node_times) {
- LOG(INFO) << " "
- << config->nodes()->Get(node_index)->name()->string_view()
- << " " << time;
+ VLOG(1) << " "
+ << config->nodes()->Get(node_index)->name()->string_view()
+ << " " << time;
++node_index;
}
});
@@ -94,7 +94,7 @@
// logger on purpose. It loads in *all* the timestamps in 1 go per node,
// ignoring memory usage.
for (const Node *node : configuration::GetNodes(config)) {
- LOG(INFO) << "Reading all data for " << node->name()->string_view();
+ VLOG(1) << "Reading all data for " << node->name()->string_view();
const size_t node_index = configuration::GetNodeIndex(config, node);
TimestampMapper *timestamp_mapper = mappers[node_index].get();
if (timestamp_mapper == nullptr) {
@@ -117,11 +117,11 @@
if (!next_timestamp.has_value() || !next_timestamp.value().has_value()) {
return preempt_destructor(false);
}
- LOG(INFO) << "Starting at:";
+ VLOG(1) << "Starting at:";
for (const Node *node : configuration::GetNodes(config)) {
const size_t node_index = configuration::GetNodeIndex(config, node);
- LOG(INFO) << " " << node->name()->string_view() << " -> "
- << std::get<1>(*next_timestamp.value().value())[node_index].time;
+ VLOG(1) << " " << node->name()->string_view() << " -> "
+ << std::get<1>(*next_timestamp.value().value())[node_index].time;
}
std::vector<monotonic_clock::time_point> just_monotonic(
@@ -148,7 +148,7 @@
std::get<0>(*next_timestamp.value().value()));
}
- LOG(INFO) << "Done";
+ VLOG(1) << "Done";
return preempt_destructor(true);
}