commit 61276dc62e8677702994c53019ef889090beeeac
author colleen <colleen.twitty@bluerivertech.com> Thu Jun 01 09:23:29 2023 -0700
committer James Kuszmaul <jabukuszmaul+collab@gmail.com> Sun Jul 23 08:37:25 2023 -0700
tree 94861dbb793c1bc3010c60447edc93b38e957ba3
parent a6681e22da2b53bb98cb1ba89c0ab809c0f5b9b6

Teach logger about O_DIRECT

Plump the option down through aos.

This will let us (in a future change) detect whether the storage disk
should use O_DIRECT or not, as appropriate.

Change-Id: I2bc68606a4954460a3bcd61e5e649e122ebb1358
Signed-off-by: James Kuszmaul <james.kuszmaul@bluerivertech.com>

aos/events/logging/log_backend_test.cc

diff --git a/aos/events/logging/log_backend_test.cc b/aos/events/logging/log_backend_test.cc
index 2720e46..08b6f1e 100644
--- a/aos/events/logging/log_backend_test.cc
+++ b/aos/events/logging/log_backend_test.cc
@@ -28,7 +28,7 @@
 TEST(LogBackendTest, CreateSimpleFile) {
   const std::string logevent = aos::testing::TestTmpDir() + "/logevent/";
   const std::string filename = "test.bfbs";
-  FileBackend backend(logevent);
+  FileBackend backend(logevent, false);
   auto file = backend.RequestFile(filename);
   ASSERT_EQ(file->OpenForWrite(), WriteCode::kOk);
   auto result = Write(file.get(), "test");
@@ -51,7 +51,7 @@
 
 TEST(LogBackendTest, CreateRenamableFile) {
   const std::string logevent = aos::testing::TestTmpDir() + "/logevent/";
-  RenamableFileBackend backend(logevent);
+  RenamableFileBackend backend(logevent, false);
   auto file = backend.RequestFile("test.log");
   ASSERT_EQ(file->OpenForWrite(), WriteCode::kOk);
   auto result = Write(file.get(), "test");
@@ -63,7 +63,7 @@
 
 TEST(LogBackendTest, UseTempRenamableFile) {
   const std::string logevent = aos::testing::TestTmpDir() + "/logevent/";
-  RenamableFileBackend backend(logevent);
+  RenamableFileBackend backend(logevent, false);
   backend.EnableTempFiles();
   auto file = backend.RequestFile("test.log");
   ASSERT_EQ(file->OpenForWrite(), WriteCode::kOk);
@@ -79,7 +79,7 @@
 
 TEST(LogBackendTest, RenameBaseAfterWrite) {
   const std::string logevent = aos::testing::TestTmpDir() + "/logevent/";
-  RenamableFileBackend backend(logevent);
+  RenamableFileBackend backend(logevent, false);
   auto file = backend.RequestFile("test.log");
   ASSERT_EQ(file->OpenForWrite(), WriteCode::kOk);
   auto result = Write(file.get(), "test");
@@ -100,7 +100,7 @@
 
 TEST(LogBackendTest, UseTestAndRenameBaseAfterWrite) {
   const std::string logevent = aos::testing::TestTmpDir() + "/logevent/";
-  RenamableFileBackend backend(logevent);
+  RenamableFileBackend backend(logevent, false);
   backend.EnableTempFiles();
   auto file = backend.RequestFile("test.log");
   ASSERT_EQ(file->OpenForWrite(), WriteCode::kOk);
@@ -279,7 +279,7 @@
     std::filesystem::remove_all(file);
     VLOG(1) << "Writing to " << file.c_str();
 
-    FileBackend backend(logevent);
+    FileBackend backend(logevent, false);
     auto handler = backend.RequestFile("test.log");
     ASSERT_EQ(handler->OpenForWrite(), WriteCode::kOk);
 
@@ -385,7 +385,7 @@
   std::filesystem::remove_all(file);
   VLOG(1) << "Writing to " << file.c_str();
 
-  FileBackend backend(logevent);
+  FileBackend backend(logevent, false);
   auto handler = backend.RequestFile("test.log");
   ASSERT_EQ(handler->OpenForWrite(), WriteCode::kOk);