commit 5f1cc5c9fb59d5e6807465083127ebd55e0a5c9a
author Austin Schuh <austin.linux@gmail.com> Sun Dec 01 18:01:11 2019 -0800
committer Austin Schuh <austin.linux@gmail.com> Sat Dec 07 13:12:11 2019 -0800
tree 5bbf84f42864867babf7b1516009e2b09903a36d
parent fe4f9d559a33da3defb0de0c4c4b6e1f5938924c

Require a name when making a simulated event loop

We need application names for both timing reports and for maps.  So,
lets require the names everywhere.

Change-Id: I82bf63e2500d0552bc0bb01380f67c5328e9b201

aos/events/shm_event_loop_test.cc

diff --git a/aos/events/shm_event_loop_test.cc b/aos/events/shm_event_loop_test.cc
index 16ac08c..ba0b80d 100644
--- a/aos/events/shm_event_loop_test.cc
+++ b/aos/events/shm_event_loop_test.cc
@@ -1,5 +1,7 @@
 #include "aos/events/shm_event_loop.h"
 
+#include <string_view>
+
 #include "aos/events/event_loop_param_test.h"
 #include "glog/logging.h"
 #include "gtest/gtest.h"
@@ -30,15 +32,18 @@
     unlink((FLAGS_shm_base + "/test2/aos.TestMessage.v0").c_str());
   }
 
-  ::std::unique_ptr<EventLoop> Make() override {
-    return ::std::unique_ptr<EventLoop>(new ShmEventLoop(configuration()));
+  ::std::unique_ptr<EventLoop> Make(std::string_view name) override {
+    ::std::unique_ptr<EventLoop> loop(new ShmEventLoop(configuration()));
+    loop->set_name(name);
+    return loop;
   }
 
-  ::std::unique_ptr<EventLoop> MakePrimary() override {
+  ::std::unique_ptr<EventLoop> MakePrimary(std::string_view name) override {
     ::std::unique_ptr<ShmEventLoop> loop =
         ::std::unique_ptr<ShmEventLoop>(new ShmEventLoop(configuration()));
     primary_event_loop_ = loop.get();
-    return ::std::move(loop);
+    loop->set_name(name);
+    return std::move(loop);
   }
 
   void Run() override { CHECK_NOTNULL(primary_event_loop_)->Run(); }
@@ -77,8 +82,8 @@
 // involved and it's easy to miss one.
 TEST(ShmEventLoopTest, AllHandlersAreRealtime) {
   ShmEventLoopTestFactory factory;
-  auto loop = factory.MakePrimary();
-  auto loop2 = factory.Make();
+  auto loop = factory.MakePrimary("primary");
+  auto loop2 = factory.Make("loop2");
 
   loop->SetRuntimeRealtimePriority(1);
 
@@ -121,7 +126,7 @@
 // running at the right offset.
 TEST(ShmEventLoopTest, DelayedPhasedLoop) {
   ShmEventLoopTestFactory factory;
-  auto loop1 = factory.MakePrimary();
+  auto loop1 = factory.MakePrimary("primary");
 
   ::std::vector<::aos::monotonic_clock::time_point> times;