commit 5e2bfb8269b9b144c68336e133530c546dbab1d3
author Austin Schuh <austin.linux@gmail.com> Sat Mar 13 22:46:55 2021 -0800
committer Austin Schuh <austin.linux@gmail.com> Sun Mar 14 21:23:51 2021 -0700
tree cc085095993216af04ac8e7aaab9e4b0428bcf29
parent 4b2d1e5ab1560e8de5984cb2cd3b5c9e7ffed1d5

Store UUIDs as 16 bytes of data

This makes them much more efficient to write over shared memory to solve
the boot UUID logging problem when we add them.

Change-Id: Idf361d6b096bfa52cbc98f555c90bf1f6b90d3e0

aos/events/logging/log_writer.cc

diff --git a/aos/events/logging/log_writer.cc b/aos/events/logging/log_writer.cc
index 96995e9..400ad8d 100644
--- a/aos/events/logging/log_writer.cc
+++ b/aos/events/logging/log_writer.cc
@@ -432,7 +432,7 @@
     // There are no offsets to compute for ourself, so always succeed.
     SetStartTime(node_index, monotonic_start_time, realtime_start_time,
                  monotonic_start_time, realtime_start_time);
-    node_state_[node_index].SetBootUUID(event_loop_->boot_uuid().string_view());
+    node_state_[node_index].SetBootUUID(event_loop_->boot_uuid());
     return true;
   } else if (server_statistics_fetcher_.get() != nullptr) {
     // We must be a remote node now.  Look for the connection and see if it is
@@ -500,10 +500,10 @@
 
   CHECK(log_event_uuid_ != UUID::Zero());
   const flatbuffers::Offset<flatbuffers::String> log_event_uuid_offset =
-      fbb.CreateString(log_event_uuid_.string_view());
+      log_event_uuid_.PackString(&fbb);
 
   const flatbuffers::Offset<flatbuffers::String> logger_instance_uuid_offset =
-      fbb.CreateString(logger_instance_uuid_.string_view());
+      logger_instance_uuid_.PackString(&fbb);
 
   flatbuffers::Offset<flatbuffers::String> log_start_uuid_offset;
   if (!log_start_uuid_.empty()) {
@@ -516,10 +516,10 @@
   }
 
   const flatbuffers::Offset<flatbuffers::String> logger_node_boot_uuid_offset =
-      fbb.CreateString(event_loop_->boot_uuid().string_view());
+      event_loop_->boot_uuid().PackString(&fbb);
 
   const flatbuffers::Offset<flatbuffers::String> source_node_boot_uuid_offset =
-      fbb.CreateString(event_loop_->boot_uuid().string_view());
+      event_loop_->boot_uuid().PackString(&fbb);
 
   const flatbuffers::Offset<flatbuffers::String> parts_uuid_offset =
       fbb.CreateString("00000000-0000-4000-8000-000000000000");