commit 4d8a46e06f6b121158d743b9f2a2af78ee7b843d
author Austin Schuh <austin.schuh@bluerivertech.com> Fri Oct 07 19:20:20 2022 -0700
committer James Kuszmaul <james.kuszmaul@bluerivertech.com> Wed Oct 26 11:16:27 2022 -0700
tree bb4f991b9d8f74ad62e2308a585ad89a89f690f1
parent b009bfc2c0bab263ce57e0488ddb6c69c5ac3e9f

Make starterd restartable

When cgroups didn't get cleaned up correctly, we didn't clean them up
correctly when starting back up.  They are weird, use rmdir rather then
remove and the kernel is then happy...

Change-Id: I94255d7ef301c14c93078b234ae75a88d005c26f
Signed-off-by: James Kuszmaul <james.kuszmaul@bluerivertech.com>

aos/starter/subprocess.cc

diff --git a/aos/starter/subprocess.cc b/aos/starter/subprocess.cc
index 558e5c7..a05ab74 100644
--- a/aos/starter/subprocess.cc
+++ b/aos/starter/subprocess.cc
@@ -43,7 +43,7 @@
 
   if (ret != 0) {
     if (errno == EEXIST) {
-      PCHECK(remove(cgroup_.c_str()) == 0)
+      PCHECK(rmdir(cgroup_.c_str()) == 0)
           << ": Failed to remove previous cgroup " << cgroup_;
       ret = mkdir(cgroup_.c_str(), 0755);
     }