Make Fetcher operator bool a named method
It is confusing to have the operator bool because it doesn't
check if there is data on the channel, and the dereference operator
returns the data on the channel, so you would think that if the bool
operator returns true then the dereferencing would not return
a nullptr, but it can.
Change-Id: Idf774b2d099992abec1bd825dec7848a172ed24e
diff --git a/aos/starter/starter_rpc_lib.cc b/aos/starter/starter_rpc_lib.cc
index 84b1a55..7b86c0a 100644
--- a/aos/starter/starter_rpc_lib.cc
+++ b/aos/starter/starter_rpc_lib.cc
@@ -133,8 +133,9 @@
auto status_fetcher = event_loop.MakeFetcher<aos::starter::Status>("/aos");
status_fetcher.Fetch();
- auto status =
- status_fetcher ? FindApplicationStatus(*status_fetcher, name) : nullptr;
+ auto status = status_fetcher.get()
+ ? FindApplicationStatus(*status_fetcher, name)
+ : nullptr;
return status ? aos::CopyFlatBuffer(status)
: FlatbufferDetachedBuffer<
aos::starter::ApplicationStatus>::Empty();
@@ -147,8 +148,9 @@
auto status_fetcher = event_loop.MakeFetcher<aos::starter::Status>("/aos");
status_fetcher.Fetch();
- return (status_fetcher ? std::make_optional(status_fetcher.CopyFlatBuffer())
- : std::nullopt);
+ return (status_fetcher.get()
+ ? std::make_optional(status_fetcher.CopyFlatBuffer())
+ : std::nullopt);
}
} // namespace starter