commit 46f4004715b4bca5e5e4fc7740042b1edee60be3
author Philipp Schrader <philipp.schrader@bluerivertech.com> Wed Jan 24 17:16:03 2024 -0800
committer James Kuszmaul <jabukuszmaul+collab@gmail.com> Fri Feb 16 22:20:57 2024 -0800
tree d21354d2b5c457f36b1faa1f096e27c09abee792
parent 1bb30539bc4efe986c4da2d39cbb76ca0bd77db8

Remove flatbuffer's *_generated.h files from runfiles

All the `*_generated.h` files are currently ending up as runfiles.
They are truly unnecessary.

Binaries with a larger number of flatbuffer dependencies have a larger
number of headers in their runfiles.

I encountered this while trying to migrate rules_docker targets to
rules_oci. Looking at the container contents before/after showed these
superfluous files.

Change-Id: I5db02ded6ce38eb5329aecbc4fecd3dda013ba77
Signed-off-by: James Kuszmaul <james.kuszmaul@bluerivertech.com>

third_party/flatbuffers/build_defs.bzl

diff --git a/third_party/flatbuffers/build_defs.bzl b/third_party/flatbuffers/build_defs.bzl
index 5f6d71b..da26cec 100644
--- a/third_party/flatbuffers/build_defs.bzl
+++ b/third_party/flatbuffers/build_defs.bzl
@@ -96,7 +96,7 @@
         mnemonic = "Flatc",
         progress_message = "Generating flatbuffer files for %{input}:",
     )
-    return [DefaultInfo(files = depset(outs), runfiles = ctx.runfiles(files = outs)), FlatbufferLibraryInfo(srcs = ctx.files.srcs)]
+    return [DefaultInfo(files = depset(outs)), FlatbufferLibraryInfo(srcs = ctx.files.srcs)]
 
 _flatbuffer_library_compile = rule(
     implementation = _flatbuffer_library_compile_impl,