commit 464012bcee40d070c64ec2aecee491a22b9a08e0
author James Kuszmaul <james.kuszmaul@bluerivertech.com> Wed Mar 20 14:12:08 2024 -0700
committer Austin Schuh <austin.linux@gmail.com> Sun May 12 17:50:19 2024 -0700
tree c4fab8c955f853ce26460104045c7396e78d5748
parent af21324e8caad78b435ad0bde15de3bf6b962e63

Add tests for individual node loggers to config_validators

This makes it so that you can easily test that each individual node's
logs can be used to replay all of the state on that log. While we
already theoretically had logic to exercise this in the config
validator, said logic was both incorrectly written and not actually
being used by any of the config validators.

Simultaneously: While upstreaming this, start reducing the number of
explicit @repo_name that we have written out in the repository.

Change-Id: I0c7cb634b3d7bbc63503c607a5f8d91bc184d416
Signed-off-by: James Kuszmaul <james.kuszmaul@bluerivertech.com>

aos/util/config_validator_macro.bzl

diff --git a/aos/util/config_validator_macro.bzl b/aos/util/config_validator_macro.bzl
index cd05bab..989ece9 100644
--- a/aos/util/config_validator_macro.bzl
+++ b/aos/util/config_validator_macro.bzl
@@ -1,4 +1,6 @@
-def config_validator_test(name, config, logger_sets = [{}], check_for_not_logged_channels = False, extension = ".bfbs", visibility = None):
+load("//tools/build_rules:clean_dep.bzl", "clean_dep")
+
+def config_validator_test(name, config, logger_sets = [{}], check_for_not_logged_channels = False, validate_individual_node_loggers = False, extension = ".bfbs", visibility = None):
     '''
     Macro to take a config and pass it to the config validator to validate that it will work on a real system.
 
@@ -7,10 +9,10 @@
         config: config rule that needs to be validated, e.g. "//aos/events:pingpong_config",
     '''
     config_file = config + extension
-    config_json = json.encode({"logging": {"all_channels_logged": check_for_not_logged_channels, "logger_sets": logger_sets}})
+    config_json = json.encode({"logging": {"all_channels_logged": check_for_not_logged_channels, "validate_individual_node_loggers": validate_individual_node_loggers, "logger_sets": logger_sets}})
     native.cc_test(
         name = name,
-        deps = ["//aos/util:config_validator"],
+        deps = [clean_dep("//aos/util:config_validator")],
         args = ["--config=$(location %s)" % config_file, "--validation_config='%s'" % config_json],
         data = [config_file],
         visibility = visibility,