commit 432784fb06bc8933edc8ed9fcd96637bced45b2d
author Austin Schuh <austin.linux@gmail.com> Tue Jun 23 17:27:35 2020 -0700
committer Austin Schuh <austin.linux@gmail.com> Wed Jun 24 21:54:38 2020 -0700
tree 058a3201f56288edda782d5b08ba028049cdb93e
parent 7dcbbcb030729833e69c9d512355ded4f4388e89

Log timing report before crashing.

When we die for timing issues, we want to push out the last timing
report.

Change-Id: Ib87013ea6fc5461f64240859ba30acdd93fcd1aa

aos/events/shm_event_loop.cc

diff --git a/aos/events/shm_event_loop.cc b/aos/events/shm_event_loop.cc
index dcb7303..2383050 100644
--- a/aos/events/shm_event_loop.cc
+++ b/aos/events/shm_event_loop.cc
@@ -190,9 +190,10 @@
 
 class SimpleShmFetcher {
  public:
-  explicit SimpleShmFetcher(EventLoop *event_loop, const Channel *channel,
+  explicit SimpleShmFetcher(ShmEventLoop *event_loop, const Channel *channel,
                             bool copy_data)
-      : channel_(channel),
+      : event_loop_(event_loop),
+        channel_(channel),
         lockless_queue_memory_(
             channel,
             chrono::ceil<chrono::seconds>(chrono::nanoseconds(
@@ -263,9 +264,12 @@
            "behind.  "
         << configuration::CleanedChannelToString(channel_);
 
-    CHECK(read_result != ipc_lib::LocklessQueue::ReadResult::TOO_OLD)
-        << ": The next message is no longer available.  "
-        << configuration::CleanedChannelToString(channel_);
+    if (read_result == ipc_lib::LocklessQueue::ReadResult::TOO_OLD) {
+      event_loop_->SendTimingReport();
+      LOG(FATAL) << "The next message is no longer available.  "
+                 << configuration::CleanedChannelToString(channel_);
+    }
+
     return read_result == ipc_lib::LocklessQueue::ReadResult::GOOD;
   }
 
@@ -324,9 +328,12 @@
     // We fell behind between when we read the index and read the value.
     // This isn't worth recovering from since this means we went to sleep
     // for a long time in the middle of this function.
-    CHECK(read_result != ipc_lib::LocklessQueue::ReadResult::TOO_OLD)
-        << ": The next message is no longer available.  "
-        << configuration::CleanedChannelToString(channel_);
+    if (read_result == ipc_lib::LocklessQueue::ReadResult::TOO_OLD) {
+      event_loop_->SendTimingReport();
+      LOG(FATAL) << "The next message is no longer available.  "
+                 << configuration::CleanedChannelToString(channel_);
+    }
+
     return read_result == ipc_lib::LocklessQueue::ReadResult::GOOD;
   }
 
@@ -356,6 +363,7 @@
   }
   bool copy_data() const { return static_cast<bool>(data_storage_); }
 
+  aos::ShmEventLoop *event_loop_;
   const Channel *const channel_;
   MMapedQueue lockless_queue_memory_;
   ipc_lib::LocklessQueue lockless_queue_;
@@ -371,7 +379,7 @@
 
 class ShmFetcher : public RawFetcher {
  public:
-  explicit ShmFetcher(EventLoop *event_loop, const Channel *channel)
+  explicit ShmFetcher(ShmEventLoop *event_loop, const Channel *channel)
       : RawFetcher(event_loop, channel),
         simple_shm_fetcher_(event_loop, channel, true) {}
 

aos/events/shm_event_loop.h

diff --git a/aos/events/shm_event_loop.h b/aos/events/shm_event_loop.h
index 55fc85f..53e6aab 100644
--- a/aos/events/shm_event_loop.h
+++ b/aos/events/shm_event_loop.h
@@ -16,6 +16,7 @@
 class ShmTimerHandler;
 class ShmPhasedLoopHandler;
 class ShmSender;
+class SimpleShmFetcher;
 class ShmFetcher;
 
 }  // namespace shm_event_loop_internal
@@ -99,8 +100,11 @@
   friend class shm_event_loop_internal::ShmTimerHandler;
   friend class shm_event_loop_internal::ShmPhasedLoopHandler;
   friend class shm_event_loop_internal::ShmSender;
+  friend class shm_event_loop_internal::SimpleShmFetcher;
   friend class shm_event_loop_internal::ShmFetcher;
 
+  using EventLoop::SendTimingReport;
+
   static cpu_set_t DefaultAffinity() {
     cpu_set_t result;
     for (int i = 0; i < CPU_SETSIZE; ++i) {