Upgrade from FlatbufferString to FlatbufferSpan
Less copies, and now we can get rid of FlatbufferString
Change-Id: Ic027de4270d7232d0defadc2b193072aa8e4c8e5
diff --git a/y2020/vision/calibration.cc b/y2020/vision/calibration.cc
index 6cf9e8e..4365b60 100644
--- a/y2020/vision/calibration.cc
+++ b/y2020/vision/calibration.cc
@@ -1,5 +1,10 @@
+// These need to come before opencv, or they don't compile. Presumably opencv
+// #defines something annoying.
+// clang-format off
#include "Eigen/Dense"
#include "Eigen/Geometry"
+// clang-format on
+
#include <opencv2/aruco/charuco.hpp>
#include <opencv2/calib3d.hpp>
#include <opencv2/core/eigen.hpp>
@@ -37,17 +42,11 @@
class CameraCalibration {
public:
- CameraCalibration(const std::string_view training_data_bfbs) {
- const sift::TrainingData *const training_data =
- flatbuffers::GetRoot<sift::TrainingData>(training_data_bfbs.data());
- {
- flatbuffers::Verifier verifier(
- reinterpret_cast<const uint8_t *>(training_data_bfbs.data()),
- training_data_bfbs.size());
- CHECK(training_data->Verify(verifier));
- }
-
- camera_calibration_ = FindCameraCalibration(training_data);
+ CameraCalibration(const absl::Span<const uint8_t> training_data_bfbs) {
+ const aos::FlatbufferSpan<sift::TrainingData> training_data(
+ training_data_bfbs);
+ CHECK(training_data.Verify());
+ camera_calibration_ = FindCameraCalibration(&training_data.message());
}
cv::Mat CameraIntrinsics() const {
diff --git a/y2020/vision/camera_reader.cc b/y2020/vision/camera_reader.cc
index 24e9ae1..ed2b4b9 100644
--- a/y2020/vision/camera_reader.cc
+++ b/y2020/vision/camera_reader.cc
@@ -6,7 +6,6 @@
#include "aos/flatbuffer_merge.h"
#include "aos/init.h"
#include "aos/network/team_number.h"
-
#include "y2020/vision/sift/sift971.h"
#include "y2020/vision/sift/sift_generated.h"
#include "y2020/vision/sift/sift_training_generated.h"
@@ -599,15 +598,9 @@
aos::FlatbufferDetachedBuffer<aos::Configuration> config =
aos::configuration::ReadConfig(FLAGS_config);
- const auto training_data_bfbs = SiftTrainingData();
- const sift::TrainingData *const training_data =
- flatbuffers::GetRoot<sift::TrainingData>(training_data_bfbs.data());
- {
- flatbuffers::Verifier verifier(
- reinterpret_cast<const uint8_t *>(training_data_bfbs.data()),
- training_data_bfbs.size());
- CHECK(training_data->Verify(verifier));
- }
+ const aos::FlatbufferSpan<sift::TrainingData> training_data(
+ SiftTrainingData());
+ CHECK(training_data.Verify());
const auto index_params = cv::makePtr<cv::flann::IndexParams>();
index_params->setAlgorithm(cvflann::FLANN_INDEX_KDTREE);
@@ -622,13 +615,12 @@
{
aos::Sender<sift::TrainingData> training_data_sender =
event_loop.MakeSender<sift::TrainingData>("/camera");
- training_data_sender.Send(
- aos::FlatbufferString<sift::TrainingData>(training_data_bfbs));
+ training_data_sender.Send(training_data);
}
V4L2Reader v4l2_reader(&event_loop, "/dev/video0");
- CameraReader camera_reader(&event_loop, training_data, &v4l2_reader,
- &matcher);
+ CameraReader camera_reader(&event_loop, &training_data.message(),
+ &v4l2_reader, &matcher);
event_loop.Run();
}
diff --git a/y2020/vision/tools/python_code/BUILD b/y2020/vision/tools/python_code/BUILD
index 4ff3397..6223d76 100644
--- a/y2020/vision/tools/python_code/BUILD
+++ b/y2020/vision/tools/python_code/BUILD
@@ -49,6 +49,9 @@
],
target_compatible_with = ["@platforms//os:linux"],
visibility = ["//visibility:public"],
+ deps = [
+ "@com_google_absl//absl/types:span",
+ ],
)
py_binary(
@@ -102,6 +105,9 @@
],
target_compatible_with = ["@platforms//os:linux"],
visibility = ["//visibility:public"],
+ deps = [
+ "@com_google_absl//absl/types:span",
+ ],
)
cc_test(
diff --git a/y2020/vision/tools/python_code/load_sift_training.py b/y2020/vision/tools/python_code/load_sift_training.py
index 402e468..2dc5cf2 100644
--- a/y2020/vision/tools/python_code/load_sift_training.py
+++ b/y2020/vision/tools/python_code/load_sift_training.py
@@ -219,13 +219,14 @@
output_prefix = [
b'#ifndef Y2020_VISION_TOOLS_PYTHON_CODE_TRAINING_DATA_H_',
b'#define Y2020_VISION_TOOLS_PYTHON_CODE_TRAINING_DATA_H_',
- b'#include <string_view>',
+ b'#include <stdint.h>',
+ b'#include "absl/types/span.h"',
b'namespace frc971 {',
b'namespace vision {',
- b'inline std::string_view SiftTrainingData() {',
+ b'inline absl::Span<const uint8_t> SiftTrainingData() {',
]
output_suffix = [
- b' return std::string_view(kData, sizeof(kData));',
+ b' return absl::Span<const uint8_t>(reinterpret_cast<const uint8_t *>(kData), sizeof(kData));',
b'}',
b'} // namespace vision',
b'} // namespace frc971',