commit 2bb80e0077c507622a5d83aac0650625b6281180
author Austin Schuh <austin.linux@gmail.com> Sat Mar 20 21:46:17 2021 -0700
committer Austin Schuh <austin.linux@gmail.com> Tue Mar 23 13:31:40 2021 -0700
tree 54a1b1332dfe70cb572aba7411921144403d6043
parent 8302e3c317b689994694b3c088eeb77c0d81c6f3

Warn when a channel isn't logged and terminates reading a log

The Galactic search path message was forwarded to the roboRIO but wasn't
logged.  The end result was that we stopped replaying the log when we
found the first Galactic search path timestamp.  It was very confusing
to debug.

The fix is 2 fold.
  1) Log the message.
  2) Warn in log_reader that this is happening to make it much faster to
     debug.

Change-Id: I4ae48311e4e514e941644bd8d42fd30382b38522

aos/configuration.cc

diff --git a/aos/configuration.cc b/aos/configuration.cc
index 36868c4..25d59ff 100644
--- a/aos/configuration.cc
+++ b/aos/configuration.cc
@@ -1039,21 +1039,25 @@
 }
 
 bool ChannelMessageIsLoggedOnNode(const Channel *channel, const Node *node) {
+  if (channel->logger() == LoggerConfig::LOCAL_LOGGER && node == nullptr) {
+    // Single node world.  If there is a local logger, then we want to use
+    // it.
+    return true;
+  }
+  return ChannelMessageIsLoggedOnNode(
+      channel, CHECK_NOTNULL(node)->name()->string_view());
+}
+
+bool ChannelMessageIsLoggedOnNode(const Channel *channel,
+                                  std::string_view node_name) {
   switch (channel->logger()) {
     case LoggerConfig::LOCAL_LOGGER:
-      if (node == nullptr) {
-        // Single node world.  If there is a local logger, then we want to use
-        // it.
-        return true;
-      }
-      return channel->source_node()->string_view() ==
-             node->name()->string_view();
+      return channel->source_node()->string_view() == node_name;
     case LoggerConfig::LOCAL_AND_REMOTE_LOGGER:
       CHECK(channel->has_logger_nodes());
       CHECK_GT(channel->logger_nodes()->size(), 0u);
 
-      if (channel->source_node()->string_view() ==
-          CHECK_NOTNULL(node)->name()->string_view()) {
+      if (channel->source_node()->string_view() == node_name) {
         return true;
       }
 
@@ -1062,8 +1066,7 @@
       CHECK(channel->has_logger_nodes());
       CHECK_GT(channel->logger_nodes()->size(), 0u);
       for (const flatbuffers::String *logger_node : *channel->logger_nodes()) {
-        if (logger_node->string_view() ==
-            CHECK_NOTNULL(node)->name()->string_view()) {
+        if (logger_node->string_view() == node_name) {
           return true;
         }
       }