commit 2b4404cbb3ebcb2d6a5b7a00fcf786c27b67c3ca
author Milind Upadhyay <milind.upadhyay@gmail.com> Fri Feb 04 21:20:57 2022 -0800
committer milind-u <milind.upadhyay@gmail.com> Sat Feb 05 12:40:57 2022 -0800
tree 079a76db0604b17d6cae3ff250649e95c247aa98
parent 44ec4774dabab75047fae7e9a3314969dca71b76

Fix bugs in blob detector

When passing grayscale images by value, they can't be changed inside a
function. Also, fixed an infinite loop when more than 0 but less than 3
blobs were getting detected.

Signed-off-by: Milind Upadhyay <milind.upadhyay@gmail.com>
Change-Id: I5403d02aa9e3df07800791312f0e18ee81824868

y2022/vision/blob_detector.h

diff --git a/y2022/vision/blob_detector.h b/y2022/vision/blob_detector.h
index f95b217..a0663fd 100644
--- a/y2022/vision/blob_detector.h
+++ b/y2022/vision/blob_detector.h
@@ -45,7 +45,7 @@
       const std::vector<BlobStats> &blob_stats, cv::Point centroid);
 
   static void ExtractBlobs(
-      cv::Mat rgb_image, cv::Mat binarized_image, cv::Mat blob_image,
+      cv::Mat rgb_image, cv::Mat &binarized_image, cv::Mat blob_image,
       std::vector<std::vector<cv::Point>> &filtered_blobs,
       std::vector<std::vector<cv::Point>> &unfiltered_blobs,
       std::vector<BlobStats> &blob_stats, cv::Point &centroid);