commit 13d48d91e5c515f2377d808e1a5922d1c826eb87
author Adam Snaider <adsnaider@gmail.com> Thu Aug 03 12:20:15 2023 -0700
committer James Kuszmaul <james.kuszmaul@bluerivertech.com> Wed Nov 08 08:42:18 2023 -0800
tree 84340df124c24fe768cf2199017b5edf1fa1b0c2
parent fc180b21a8868ce8fac821327d0e51084eacef2a

Setup the message bridge key sharing services

This implements 2 new services that will be used to share the active
SCTP authentication key. For context, if SCTP authentication is wanted,
then we will need a way to securely distribute a shared key across every
node. We use gRPC to distribute the key.

* message_bridge_auth_server

This service should only run in one node. It generates a 128-bit
random-key during initialization. It sets up the gRPC service using
mutual-TLS authentication.

* message_bridge_auth_client

This service will run in every node. It listens for requests
in /aos aos.message_bridge.SctpConfigRequest and requests the
active key from the gRPC server which gets propagated into /aos
aos.message_bridge.SctpConfig. message_bridge reads this value and sets
the authentication key (previous change in relation).

These have some additional side-effects:
* This change also forces us to bring in an appropriate version of GRPC,
  which itself forces updates to protobuf and other dependencies. We
  take the opportunity to remove the protobuf subtree in favor of
  a more sanitized import in the WORKSPACE.
* The various upgrades also upgraded our version of buildifier,
  which now performs more aggressive linting.
* Our version of abseil was upgraded, which now forces you to only
  have access to const references to things stored in absl::btree_set's
  (see https://github.com/abseil/abseil-cpp/commit/a74b796ab3f114f6991479c9ad9e4c1a0dad3a4b).

Change-Id: I870b8f93451056e011cefa3cdf3c5dc01c19a6f9
Signed-off-by: James Kuszmaul <james.kuszmaul@bluerivertech.com>
Signed-off-by: Adam Snaider <adsnaider@gmail.com>

tools/build_rules/js.bzl

diff --git a/tools/build_rules/js.bzl b/tools/build_rules/js.bzl
index 55f440b..4b11ea7 100644
--- a/tools/build_rules/js.bzl
+++ b/tools/build_rules/js.bzl
@@ -57,12 +57,10 @@
 def ng_application(
         name,
         deps = [],
-        test_deps = [],
         extra_srcs = [],
         assets = None,
         html_assets = APPLICATION_HTML_ASSETS,
-        visibility = ["//visibility:public"],
-        **kwargs):
+        visibility = ["//visibility:public"]):
     """
     Bazel macro for compiling an Angular application. Creates {name}, test, serve targets.
 
@@ -81,11 +79,9 @@
     Args:
       name: the rule name
       deps: direct dependencies of the application
-      test_deps: additional dependencies for tests
       html_assets: assets to insert into the index.html, [styles.css, favicon.ico] by default
       assets: assets to include in the file bundle
       visibility: visibility of the primary targets ({name}, 'test', 'serve')
-      **kwargs: extra args passed to main Angular CLI rules
     """
     assets = assets if assets else native.glob(["assets/**/*"])
     html_assets = html_assets if html_assets else []
@@ -231,7 +227,7 @@
     #    visibility = visibility,
     #)
 
-def ng_pkg(name, generate_public_api = True, extra_srcs = [], deps = [], test_deps = [], visibility = ["//visibility:public"], **kwargs):
+def ng_pkg(name, generate_public_api = True, extra_srcs = [], deps = [], visibility = ["//visibility:public"], **kwargs):
     """
     Bazel macro for compiling an npm-like Angular package project. Creates '{name}' and 'test' targets.
 
@@ -247,7 +243,6 @@
     Args:
       name: the rule name
       deps: package dependencies
-      test_deps: additional dependencies for tests
       visibility: visibility of the primary targets ('{name}', 'test')
     """
 
@@ -284,8 +279,7 @@
         name = name,
         srcs = srcs + [":_index"],
         deps = deps + PACKAGE_DEPS,
-        #visibility = ["//visibility:private"],
-        visibility = ["//visibility:public"],
+        visibility = visibility,
         **kwargs
     )