commit 0debde18356ade861c1ca12210eea1ada0d0ac7e
author Austin Schuh <austin.schuh@bluerivertech.com> Wed Aug 17 16:25:17 2022 -0700
committer Austin Schuh <austin.schuh@bluerivertech.com> Thu Aug 18 12:15:47 2022 -0700
tree 060ae628feb76045424a52f6660a3b6e34f4add4
parent 6c066397e8d47890e2c692d56627122ef19a8c5f

Clear Context in EventLoop at construction time

We were exposing uninitialized memory and hoping our users wouldn't try
to access it.  This is an overly bold assumption.

Change-Id: I286fe5e932354581419059d128563c435b16071b
Signed-off-by: Austin Schuh <austin.schuh@bluerivertech.com>

aos/events/event_loop_param_test.cc

diff --git a/aos/events/event_loop_param_test.cc b/aos/events/event_loop_param_test.cc
index 118b9ae..990cbe5 100644
--- a/aos/events/event_loop_param_test.cc
+++ b/aos/events/event_loop_param_test.cc
@@ -2562,6 +2562,17 @@
 TEST_P(AbstractEventLoopTest, SetContextOnRun) {
   auto loop = MakePrimary();
 
+  EXPECT_EQ(loop->context().monotonic_event_time, monotonic_clock::min_time);
+  EXPECT_EQ(loop->context().monotonic_remote_time, monotonic_clock::min_time);
+  EXPECT_EQ(loop->context().realtime_event_time, realtime_clock::min_time);
+  EXPECT_EQ(loop->context().realtime_remote_time, realtime_clock::min_time);
+  EXPECT_EQ(loop->context().source_boot_uuid, loop->boot_uuid());
+  EXPECT_EQ(loop->context().queue_index, 0xffffffffu);
+  EXPECT_EQ(loop->context().remote_queue_index, 0xffffffffu);
+  EXPECT_EQ(loop->context().size, 0u);
+  EXPECT_EQ(loop->context().data, nullptr);
+  EXPECT_EQ(loop->context().buffer_index, -1);
+
   // We want to check that monotonic event time is before monotonic now
   // called inside of callback, but after time point obtained callback.
   aos::monotonic_clock::time_point monotonic_event_time_on_run;
@@ -2574,6 +2585,7 @@
     EXPECT_EQ(loop->context().realtime_remote_time, realtime_clock::min_time);
     EXPECT_EQ(loop->context().source_boot_uuid, loop->boot_uuid());
     EXPECT_EQ(loop->context().queue_index, 0xffffffffu);
+    EXPECT_EQ(loop->context().remote_queue_index, 0xffffffffu);
     EXPECT_EQ(loop->context().size, 0u);
     EXPECT_EQ(loop->context().data, nullptr);
     EXPECT_EQ(loop->context().buffer_index, -1);
@@ -2585,6 +2597,17 @@
       loop->monotonic_now();
   Run();
   EXPECT_GE(monotonic_event_time_on_run, before_run_time);
+
+  EXPECT_EQ(loop->context().monotonic_event_time, monotonic_clock::min_time);
+  EXPECT_EQ(loop->context().monotonic_remote_time, monotonic_clock::min_time);
+  EXPECT_EQ(loop->context().realtime_event_time, realtime_clock::min_time);
+  EXPECT_EQ(loop->context().realtime_remote_time, realtime_clock::min_time);
+  EXPECT_EQ(loop->context().source_boot_uuid, loop->boot_uuid());
+  EXPECT_EQ(loop->context().queue_index, 0xffffffffu);
+  EXPECT_EQ(loop->context().remote_queue_index, 0xffffffffu);
+  EXPECT_EQ(loop->context().size, 0u);
+  EXPECT_EQ(loop->context().data, nullptr);
+  EXPECT_EQ(loop->context().buffer_index, -1);
 }
 
 // Tests that watchers fail when created on the wrong node.